From: Thomas Monjalon <thomas@monjalon.net>
To: "Gributs, Paulis" <paulis.gributs@intel.com>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
dev@dpdk.org, "Li, Xiaoyun" <xiaoyun.li@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix vm_hotplug after removal of rte_eth_devices
Date: Fri, 30 Jul 2021 14:30:45 +0200 [thread overview]
Message-ID: <11464587.amWTtSoWXQ@thomas> (raw)
In-Reply-To: <DM4PR11MB553479398E8B80B10E6C5BDF99EC9@DM4PR11MB5534.namprd11.prod.outlook.com>
> > After removing rte_eth_devices from testpmd the vm_hotplug no longer
> > recovered after removal of a device, this patch fixes this issue.
> >
> > Fixes: 0a0821bcf312 ("app/testpmd: remove most uses of internal ethdev array")
> >
> > Signed-off-by: Paulis Gributs <paulis.gributs@intel.com>
> > ---
> > app/test-pmd/testpmd.c | 8 +++++---
> > 1 file changed, 5 insertions(+), 3 deletions(-)
>
> Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
Adding a bit of explanation:
"because the port was closed before querying it."
About the title, vm_hotplug is nothing in testpmd,
and the problem is not limited to VMs.
Applied with rewording.
prev parent reply other threads:[~2021-07-30 12:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 13:48 Paulis Gributs
2021-07-30 2:17 ` Li, Xiaoyun
2021-07-30 12:30 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11464587.amWTtSoWXQ@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=paulis.gributs@intel.com \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).