From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD65B43DEE; Wed, 3 Apr 2024 18:13:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 90F774025C; Wed, 3 Apr 2024 18:13:43 +0200 (CEST) Received: from fout3-smtp.messagingengine.com (fout3-smtp.messagingengine.com [103.168.172.146]) by mails.dpdk.org (Postfix) with ESMTP id C8B8C40144 for ; Wed, 3 Apr 2024 18:13:41 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfout.nyi.internal (Postfix) with ESMTP id 043A81380092; Wed, 3 Apr 2024 12:13:41 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 03 Apr 2024 12:13:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1712160821; x=1712247221; bh=fJd7woGUK7eM74XrNVQDURvKIWiUDZCGqqh0sS6ZIYw=; b= THn0K8LqGIg2/Vu4kBzv3kJPNM138XebmrGGCcZ2AiiXJnC64bAAhHhZwQdux8L/ CD2uHXxuW3YFt0xNS2OJZ3vehaOWottwLbchcFx/kT6Wi++CrbECCwHw/SfTwghF 5cH11PKbdYX//xCXWmq3/4Zdh6oF3pRaGvjRk53wucfoB+fnMKrTcDVjcsJ2TaWT 22BUxb4koMGob99PkCqrD7U+R1/yfR9PYhuv99BZYOL8xWvKf5qtT9RPoa8Lufpu pinsMXeOUuzllKbu7NGUTNz1DD9ordj4XDhfdbQEbO1FfpxLwGNCN90hDN9J4IyY /zkKubspG/VhvjrItQOJ6g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1712160821; x= 1712247221; bh=fJd7woGUK7eM74XrNVQDURvKIWiUDZCGqqh0sS6ZIYw=; b=g Zg3j6JzN+C7IlBWpH6muJscpsZOHPFd87VCo/GKdpjsmZZ9VOxh9Rm4yDNo+SVuI 2u4XEySEB9oTUOFnpXzGybBKSZHZLbgN4X3eXmATFmWkzbI7Zg5RfjtOj0+wRgI+ LZaBFvfCefboEmQ7ovCvyOoj0iouNXO7TimlozTj8//U8xqrRG/qKpR8faEpMAS9 UVtmm6kglnf2iJu3OIN13HR8FkyTUWkqGdTlHDZ2IlaiWRV7I9CnD/DIrUVaG/4Y 9dQg/wFvdLl5mAH5z9FHiEtt3S4jY0P7o720QAlg4sIkAVHFonEBVrbrnKPoF4Wl hMDQjBfieilP/Fs7aRrMQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudefiedgheehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpefftdeuhfehvdekleelveffvdelhfelhedvgedtvddvudeuieev tdfgjedvudegfeenucffohhmrghinhepughpughkrdhorhhgnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 3 Apr 2024 12:13:39 -0400 (EDT) From: Thomas Monjalon To: Marek Pazdan Cc: Ferruh Yigit , Andrew Rybchenko , dev@dpdk.org Subject: Re: [PATCH] lib: add get/set link settings interface Date: Wed, 03 Apr 2024 18:13:38 +0200 Message-ID: <11571616.jrtcCam0TZ@thomas> In-Reply-To: References: <20240326235909.25276-1-mpazdan@arista.com> <1924573.MyG8hOvIyE@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 03/04/2024 16:59, Marek Pazdan: > Hi Thomas, >=20 > Information like advertising: speed, pause, autonegotiation etc. and that > same for link partner advertising. speed and duplex are already provided in some existing API. > I try to mimic ethtool since it's a common, well known and widely used to= ol > so adding an API which provides the same set of information in case the > interface is passthrough to dpdk will be useful I think. DPDK API is widely used as well :) I am not sure adding a new API for the same thing is a good idea. > I've 2 more patches dependent on the one we are discussing now, but I need > patchwork id to add dependency information. I need moderator approval for > the current patch. I've approved your mails, but you would not need a manual approval if you register. Note that you can disable receiving other threads in ML options. See an explanation here: https://www.dpdk.org/first-patch-submission-to-the-dpdk-open-source-project/ > On Wed, Apr 3, 2024 at 4:48=E2=80=AFPM Thomas Monjalon wrote: >=20 > > 03/04/2024 15:59, Marek Pazdan: > > > There are link settings parameters available from PMD drivers level > > > which are currently not exposed to the user via consistent interface. > > > When interface is available for system level those information can > > > be acquired with 'ethtool DEVNAME' (ioctl: ETHTOOL_SLINKSETTINGS/ > > > ETHTOOL_GLINKSETTINGS). There are use cases where > > > physical interface is passthrough to dpdk driver and is not available > > > from system level. Information provided by ioctl carries information > > > useful for link auto negotiation settings among others. > > > > Which information is missing exactly? > > Why are you trying to mimic ethtool API? > > > > Please let's add what is missing instead of adding a full new API.