From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8840CA054F; Tue, 2 Mar 2021 12:01:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6B5D822A273; Tue, 2 Mar 2021 12:01:17 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 9E1094014E for ; Tue, 2 Mar 2021 12:01:16 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 41831FAF; Tue, 2 Mar 2021 06:01:15 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 02 Mar 2021 06:01:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= /67OqXGt2J3cHTW4AAdtl+IfeBQbUG7XlKXnHcHHvPE=; b=2LD5AP3K5jfWq+Ih cN3TuwpnppG8HK1vjkVPsX5LIcDOyOe2/BYV1PQzWGtGetoQ/M9M9BydFH3WnhRK gORX1o8Czrq+fXtaLW5mqicT2uBtZ3OIw69l5BjZ4ah4RM8dlRQ/mqHMvb1qXitt E9iTWNxlNtCWc1m1fFX7NXpCWNx9XPT4Bpu8TPNPvZ8laR2lD1pIlU4j75kHC7K1 Qe6DujsXCANCKbDB+kFzthFkrb4Gl1G0g7DhitjlNdJu8C01XDhU6isj2Ixr/SpR KTxMODoquJFi4z+w5/aY73HhSjwaenxWIYPMs/YuWIvXyXGfVVf/JfzxpLUjpn+k ZZ8xZA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=/67OqXGt2J3cHTW4AAdtl+IfeBQbUG7XlKXnHcHHv PE=; b=El9enBjSTJMxF4c4WfCx9J3CanyWobANNDn+7dPsds4pI23m4xHAWQ5pT 6p1+90Y2ehxOlxMftv6e1rH/v7Ecfdg4B7MViG6sb9u9xNTTPpIxskkjm/rle/HL xRYqwc2pYm79qlwfNuSwaWPvhhfWjWwZZJRJIow7gHikc+gFrVnb7QZkUFN2TpnN Zmejl81Cq/LJdkNDr1co/B4syC7E/k3AiKQECb4NreOmBJ7olcKr4GCxo5Q1+7z9 dIVKnOqSXrkRp/PhSTrY7RbX5fZdYkk2YQbx6I404uJF/iEQLbc33FUE9ZK1HV9a yUb8R5pDlENZzWI7JrgUlRVXdFNEw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddttddgvddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 75FD31080057; Tue, 2 Mar 2021 06:01:13 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: Kevin Laatz , ciara.power@intel.com, dev@dpdk.org, david.marchand@redhat.com Date: Tue, 02 Mar 2021 12:01:12 +0100 Message-ID: <11617595.khkVX0lYF1@thomas> In-Reply-To: <20210302104232.GC1396@bricha3-MOBL.ger.corp.intel.com> References: <2019455.957uq3bD9f@thomas> <2447657.GpPAYfsJW5@thomas> <20210302104232.GC1396@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] telemetry logs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/03/2021 11:42, Bruce Richardson: > On Tue, Mar 02, 2021 at 11:23:41AM +0100, Thomas Monjalon wrote: > > 02/03/2021 11:14, Bruce Richardson: > > > On Mon, Mar 01, 2021 at 08:22:15PM +0100, Thomas Monjalon wrote: > > > > Hi, > > > > Sorry if I already asked this question. > > > > Would it be possible to use rte_log in rte_telemetry > > > > instead of returning telemetry_log_error at init? > > > > > > > It probably could be made to work by passing in the log function at init > > > time. Haven't delved too much into the details, though. > > > > Actually I think a better question is about the need to init telemetry > > if not used. It can generate an error without a need. > > Instead of the existing option --no-telemetry, > > what do you think of initializing the telemetry on its first use? > > This way we could remove the dependency of EAL on telemetry? > > > There is no real first use - the various libraries all register their callbacks > inside the init functions of the shared libraries. Having it initialized > inside EAL makes things very useful, because it means that all DPDK apps > automatically have telemetry available. Registering libs should be always possible, yes. But the init of the socket can be deffered to its use, no? > For example, end of last week I was able to put together a quick python > script to print out PPS stats for any DPDK app using the telemetry data. > Tested and developed initially using testpmd as a reference app, but ran > perfectly first time using OVS running in the background. Nice