From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54716A0C45; Tue, 21 Sep 2021 21:59:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C06F64003F; Tue, 21 Sep 2021 21:59:39 +0200 (CEST) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by mails.dpdk.org (Postfix) with ESMTP id BEAE14003C for ; Tue, 21 Sep 2021 21:59:37 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id 8F1755809D7; Tue, 21 Sep 2021 15:59:34 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 21 Sep 2021 15:59:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= xFfQGeE7Gk7GIWQXSfMm8baya3/vzONIfOUn/kALUiI=; b=szGeMqPUechSSYe4 /d8mC+kiKxJLSe+YX5u7q0yd9bN5iaP66Hg7a/Nw3II3sukh9IJC7wUaBtaQaDxe JEkErL8QnoaCZ8Mf8O1vChFrfTtMxSIgfsBkKLOeoONnwDqXdPrUKrRtGquKsoq+ tcF1fQkPeBw9juWt8esfpRRUzz1F7UPVfGATyFkB+VRCXvCax1mBoO0fL196Nysv wJHymg88pep2Fq6fzDRqW5o8ZJXT3gFlJ3qjWzGISUy/MSH5NoPwZKpVxlx1q2Xb La3EVnPzQ9dZVzfBrbCqj9N1hkQGZnYUFSr5enpwObFBsMELJqtCMwtRjwTJctDe qGqI5Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=xFfQGeE7Gk7GIWQXSfMm8baya3/vzONIfOUn/kALU iI=; b=GXbG1YY8LpqJ8ANty6eJbh/zOg4h0aFwr1+o4Wm+vfEGaWVljnTLxYVfQ gf5K0gh3Hvfgf6J+1O8l5lW1ruZX4/C8JbaARrpoyCs5ZZuDCTNGtnzG+hJSpv2m q+AmChXiCBkqqQNcWuBizkEizCgMNyolXGy+xjYzX5favG2HcPKNNx3d5QADbfCZ lchu1nY7ZGi7X+fvqpxVwqBHsRfRwrlOPaiHm3vHAVsBvu856LR4Dbo+gygPi08K TB1ZNch41DeudXEqiv3E+FVEMegLFl0HMuDlpUnPaIrYqWICb7HqSMwi+UpL0kuH AikMaQN+gID1dmZPTUoOxW0Y8XJ6A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudeihedgtddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 21 Sep 2021 15:59:32 -0400 (EDT) From: Thomas Monjalon To: Akhil Goyal Cc: Andrew Rybchenko , "dev@dpdk.org" , Anoob Joseph , "radu.nicolau@intel.com" , "declan.doherty@intel.com" , "hemant.agrawal@nxp.com" , "matan@nvidia.com" , "konstantin.ananyev@intel.com" , Ankur Dwivedi , "ferruh.yigit@intel.com" Date: Tue, 21 Sep 2021 21:59:29 +0200 Message-ID: <116591768.hGJlWRUT5y@thomas> In-Reply-To: References: <20210823100259.1619886-1-gakhil@marvell.com> <9ceeb864-f750-8b0b-624b-5f83c79a466e@oktetlabs.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] RFC: ethdev: add reassembly offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 29/08/2021 15:14, Akhil Goyal: > > On 8/23/21 1:02 PM, Akhil Goyal wrote: > > > +#define DEV_RX_OFFLOAD_REASSEMBLY 0x00001000 > > > > I think it should be: > > RTE_ETH_RX_OFFLOAD_IPV4_REASSEMBLY > > > > i.e. have correct prefix similar to > > RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT and mention IPv4. > > > > If we'd like to cover IPv6 as well, it could be > > RTE_ETH_RX_OFFLOAD_IP_REASSEMBLY and have IPv4/6 > > support bits in the offload capabilities below. > > Intention is to update spec for both. > Will update the capabilities accordingly to have both IPv4 and IPv6. > > > > > > #define DEV_RX_OFFLOAD_SCATTER 0x00002000 > > > /** > > > * Timestamp is set by the driver in > > RTE_MBUF_DYNFIELD_TIMESTAMP_NAME > > > @@ -1477,6 +1478,20 @@ struct rte_eth_dev_portconf { > > > */ > > > #define RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID > > (UINT16_MAX) > > > > > > +/** > > > + * Reassembly capabilities that a device can support. > > > + * The device which can support reassembly offload should set > > > + * DEV_RX_OFFLOAD_REASSEMBLY > > > + */ > > > +struct rte_eth_reass_capa { Please add "IP" in flags, struct and comments.