From: Thomas Monjalon <thomas@monjalon.net>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: dev@dpdk.org, Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [dpdk-dev] [PATCH] relicense various bits of the dpdk
Date: Thu, 01 Feb 2018 01:31:34 +0100 [thread overview]
Message-ID: <116736165.vppYjGxc5J@xps> (raw)
In-Reply-To: <2299181.I1Ls4326eD@xps>
05/01/2018 11:53, Thomas Monjalon:
> 04/12/2017 16:55, Neil Horman:
> > +# SPDX-License-Identifier: BSD-3-Clause
> > +# Copyright(c) 2015 Neil Horman. All rights reserved.
> > +# Copyright(c) 2017 6WIND S.A.
> > +# All rights reserved
> [...]
> > /*-
> > - * BSD LICENSE
> > + * SPDX-License-Identifier: BSD-3-Clause
> > *
> > * Copyright(c) 2015 Neil Horman <nhorman@tuxdriver.com>.
> > * All rights reserved.
> > *
> > */
>
> Other SPDX headers use only one space after # or *,
> and no empty line.
>
> Also, SPDX should be on the first line (except for scripts):
> /* SPDX-License-Identifier: BSD-3-Clause
>
> Please, let's take this opportunity to have consistent headers.
> Thanks
Ping.
Please could you do a v2?
Thanks
next prev parent reply other threads:[~2018-02-01 0:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 15:55 Neil Horman
2017-12-05 10:44 ` Hemant Agrawal
2018-01-05 10:53 ` Thomas Monjalon
2018-02-01 0:31 ` Thomas Monjalon [this message]
2018-02-01 1:49 ` Neil Horman
2018-02-01 12:19 ` [dpdk-dev] [PATCH v2] " Neil Horman
2018-02-01 12:49 ` Hemant Agrawal
2018-02-06 22:16 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=116736165.vppYjGxc5J@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).