From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <Santosh.Shukla@cavium.com>
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
(mail-sn1nam02on0042.outbound.protection.outlook.com [104.47.36.42])
by dpdk.org (Postfix) with ESMTP id 8A56F9E3;
Wed, 5 Apr 2017 14:34:01 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
bh=+dj6zcDotMA6AiT936fv6ggY1MGK6CIwL6jiMHOuBwU=;
b=T7KmtHl7aSBEIZTkabzlZalsfPiXWhyHQLH9HnC7DWnw2AoGiYfNDygb28hvpGZ0zB7vbTeOtAfpWwWtHWUG3JhBKopYQmfcQLUYxuTX+2MPX2trO5bhVEKlFTMS+KOYuTzFv37UTYRdMntHMWR0FJlctua5XWSTTKOLUD2Mqaw=
Authentication-Results: dpdk.org; dkim=none (message not signed)
header.d=none;dpdk.org; dmarc=none action=none
header.from=caviumnetworks.com;
Received: from [10.160.0.42] (111.93.218.67) by
BLUPR0701MB1715.namprd07.prod.outlook.com (10.163.85.141) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id
15.1.1005.10; Wed, 5 Apr 2017 12:33:57 +0000
To: Shreyansh Jain <shreyansh.jain@nxp.com>
References: <1491382264-23489-1-git-send-email-santosh.shukla@caviumnetworks.com>
<adff3d3a-a6bc-ea1b-ae9c-266a772fa21a@nxp.com>
Cc: olivier.matz@6wind.com, dev@dpdk.org, hemant.agrawal@nxp.com,
stable@dpdk.org
From: santosh <santosh.shukla@caviumnetworks.com>
Message-ID: <11699bfc-4a59-31ed-1d68-098389f1350c@caviumnetworks.com>
Date: Wed, 5 Apr 2017 18:03:43 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <adff3d3a-a6bc-ea1b-ae9c-266a772fa21a@nxp.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Originating-IP: [111.93.218.67]
X-ClientProxiedBy: MA1PR01CA0076.INDPRD01.PROD.OUTLOOK.COM (10.174.56.16) To
BLUPR0701MB1715.namprd07.prod.outlook.com (10.163.85.141)
X-MS-Office365-Filtering-Correlation-Id: a786c0d8-66ef-4a1e-488f-08d47c2008b5
X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0;
RULEID:(22001)(201703131423075)(201703031133081); SRVR:BLUPR0701MB1715;
X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715;
3:RahyHKSzadlQQ7mz64JszRhpK2YgvTUfjc7F8/gAYVLbiUnd434MwEujkMYY6OginDYNI6JkzWZnA2h+xmKl8lSG4TQelrRsIErAGbHSwovt7HfILsYq/DHo0C77kTJtp2cUQlEv5veHcJV5Xma5nc+NcBjGavGgaJPiQF69Zt2Z1p+PLVwEPGzkwZRA+JFjUDZVZDMz+ChR1wTIZnJRIOXKL1e95/F6XJuIuMi3rCDn2yTT/FZCcfKY72n1Eu2XWzkNf2N1UjnWqu9kFJTuZAKmkrQi7EDcJHbRBAy7rF7Spj57t0ev25vAm/GAybnSYTUeMfm2mbPy8t/qA8BSRA==;
25:RhjEAB29iwyOmnnDJBmTjw7w71rC5R+nkKOxD/8DYFKUMjaSh5eLnRV534jx7n6cSSyg4tusaKXB3m1E2TmB5QIBwMP22Ee4SRXc8brGgphPbTnHN4tnMrBUWQbW+AHNoiePJagIT8q/m5DbQWjGqlzNvPbmsHbpbPxOybsywJ834HlZ5IZdX1CER5rytOZ/SB7ZDSj3/Apl9tG7A2MmhHHt5Yint5Au4d/4ta7EFy8i6CxGP+7xslj1clQnuGZ38wCoklFUW+qGCGNGwjuBoOHGmD31wSzAE9YJi+jL9yTzdfoALriIpo5/eBBXauSI5h9F/XWyJ+hqy4sY1oXtbZ+y/5iLbnZjIqQlb5OqXm6X/Qw2eirga5C8vn0ZTGdh+o0L8tAXCTu6Cyy6pHQO/rHm5GjEOKoBp6AfbLErK2ruZ25rslYrm8XLkhMb59NViz2iX+UwyWHiFGKC5EtlZg==
X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715;
31:HKzbK3yCCCf2xasMijclRCeNkt0VnWKK5kTR/+WiqrGNxehPq1ebcZS24hFFIzf6BKVVXcaGb6LwY+5aczsZlOPyrjFd9p5kvpAGT8Dzh1Nkum6sF62ZJ2Mqy0joNbaLFqV1eo1BKX+LaH0Ci4ZZ5VLFFAiBTFw2aMMTBXOr72kf5VTj9dHwhoq3d7Bew35IZgI676N7mMtmbgmCPzpBWu/RaJo+/US5kWHjqx6Ewf5R89fzR6BekT9iTcrUg7yNtQjunbj/MfbVzgOrig/oXgkjg2nyiawN5BWvNdDhCbc=;
20:pdSpQiveV0h/UeaL3Hu4gBvDg3J3tm9VPDSCiucfznulohzCs5lm8x8S3ibG/fTiArz7z6Yz0YcY+4ZIJ5lQl0K+GVFIxOwVP3cUMBvJc+q2h26HHIvl0ksZ7DKjp81PrTAgW1j5Euy+P70UhCygck3OMcfgnqVD2AbpbunulQEIURe787jJLK/pewgmUvA/YNsRn+jpEc+8PqR01eUFpXu7gZlfZzfM0ATKAg/08ilV0VT94lfZf02gY/DvfN81Apmct3Iv9zDUyhiAPBT5SFvTGmaPDNqsnZkekBkjTJnCwQz1VUMonlGbCBG2xAe6hfjfFo17d8guNhUuc764Lox64p8acQbvUBbCGrcI9WRIq0tUwOiqeT1oOacPcW+/z8gfDNMpkNgQ+Xj78q6p/xdLAMEeRYK+Hj38nzRKU43tzL78O+SJIXErIxNS2AA86/tQZZUo+Vp7ypTNzQzThmr++iQeGj6Pc0iwTmhjSQOA80GquRwBIeTMKC3covnRjykYPsTRXlLXiiStNJlnix88KuxTpJ9YOpd/ZOeDp6Csb9N65YZvlfmB4sFTh8z/4TWfr5AZXxpDz9QPGmJ4trQNQMyeFnfIm7ODU+mIEvY=
X-Microsoft-Antispam-PRVS: <BLUPR0701MB1715339CA47DB2D97C19DA45EA0A0@BLUPR0701MB1715.namprd07.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:(185117386973197);
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(10201501046)(3002001)(6041248)(201703131423075)(201702281528075)(201703061421075)(20161123555025)(20161123564025)(20161123562025)(20161123560025)(6072148);
SRVR:BLUPR0701MB1715; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1715;
X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715;
4:3tQNmjLQ+IIYQj+JW/8G5FKAtpjCCdBpUJBhQExkOz9nNw7tnmD0AiaBzIlOYTU4QZJGNRloY2jHRYeEwkhLK/PcY9J5blB/1HDQOpFnHgfNpyJW81y+YB1y4bGqAGVJiow508VLGyCKlzDORTRpHs5qxVooF9vOq91CoJC9Wr4yN29o5LNBo1416wEaprJCuiNIswOLIXolPlmEVY7FgHIXw+vWQ5SHLsasX+a0lwh9l9v/QTV8iHoa9Qz0WSkYBXF9Mw63zr6RDVfr0SKJgvXmM1itKCZUif5mQX/AODVD4eDLZsTYHo9xB2QUa45Vv8OUKIQ3HWVo9d/CCU9GOlM1450NLJOKWSG/zjqI+D4YC972vbQHG4odgXejq7Y/nBwipfRclqa+ujMeEtPY/AXGIIWyH0TdSrHCJ19rAUS9UXoWs0h9wftxjIuyXRU3t2XNF4NUxzbIyWwZtchYBmebAKperzNoRo5VesduMg+uyi/HGajtlz/kAjY20OJW/Z6mat/4lmyrftc41QoB8ayJ+BC2fafvi5P0+pyDqGS/I+jEIzXJx9dPYPUcroCMNJAMU0rZ+fYkGdCL4cCCfPLn7yQzugWK6jSeMFcsZaPoQAgU50wRQr1KwUqpuG63ya8tdYSHGGIvurSb2PY/tgHVF/GkRkXq1hDltj0UD9YVoPz/fRGm1dNHbvQt9XT1udSGEaIn0VtFBjkerT4RlJOj/B0/BPxPJKh4RzM52b96J2DZ6mMU46KJtXqL+Cmf
X-Forefront-PRVS: 0268246AE7
X-Forefront-Antispam-Report: SFV:NSPM;
SFS:(10009020)(4630300001)(6049001)(6009001)(39410400002)(39450400003)(39850400002)(39400400002)(39840400002)(377454003)(24454002)(25786009)(50466002)(47776003)(2950100002)(42882006)(305945005)(6666003)(33646002)(4001350100001)(64126003)(36756003)(7736002)(42186005)(8676002)(54356999)(76176999)(81166006)(229853002)(50986999)(6916009)(23746002)(5009440100003)(6246003)(38730400002)(110136004)(90366009)(6486002)(77096006)(53936002)(8656002)(86152003)(66066001)(230700001)(3846002)(31696002)(65956001)(189998001)(65826007)(6116002)(4326008)(65806001);
DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1715; H:[10.160.0.42]; FPR:;
SPF:None; MLV:sfv; LANG:en;
X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BLUPR0701MB1715;
23:VlolaswVDjfSLJuM7rohyZcRCmBS6OTtw7a?=
=?Windows-1252?Q?elLlcNgh0vKsihsStD7gPaZkLEsvU7TwboTg8YG02VQKTBfoIssafNB3?=
=?Windows-1252?Q?inDsYuTLPmCEod+SAGLqaM1jV8f/OF656//M0r6DjVTN1EA5Tsl5kAAV?=
=?Windows-1252?Q?hPciwmEFRElsCNuEvgbDZSeDnIybutKeKS3VDClbACDB/lOCRTfUx3sw?=
=?Windows-1252?Q?vWkRSa2a0UI/SA8kOMy8HGUYW+syeQz4fVEHOTIWtWe8Q0cJBEqrom58?=
=?Windows-1252?Q?rK+An7P3bpKKU3Ny8LVx9DGkfky1uUVZl+oz2y+6BI50dWPrmTANgI66?=
=?Windows-1252?Q?JbH6QnhMI0bRUkn0QN6RD0BduDvGSvVm6zHZK01aBe3cccnr7WJYFIqy?=
=?Windows-1252?Q?776MQ7gxwnMmjpwN+Cu26PlsFZJndfU7xA3uqO7Bgxmj9tgOJR3sRvvD?=
=?Windows-1252?Q?TG1u5aQhtkniGIsk0+gjeSp9Tx8TOSRIXqJpjekuvfmDuJM9KAMD+6P6?=
=?Windows-1252?Q?8Q1osyadhEe5Hy60za9MAzxylg/pUlL4ifaak6WOtgWbve6qm5g3L+CI?=
=?Windows-1252?Q?AOXdwbAVTiULZ2CVkTw5aI1icly7PXCW/pHeDkJDfv17MaoxajX74Ilb?=
=?Windows-1252?Q?UiXDROZScX5QXVxkfstxKgMKhILONnoDw5yFj9jq2WdzkMT/V5l3aL+9?=
=?Windows-1252?Q?HiEeYgUb2Y3+PNBD4K7pWNYlxLs3ru0phzvYHgF0kR8u9kEcT/DvMv9N?=
=?Windows-1252?Q?N7SFLRLLIc0obqOCFPBMr01EjUiwyNTapMKvjHY8t/CZUiW5XRgjYxwm?=
=?Windows-1252?Q?t7j5BR73lY+AS1/wGjwZowX0O/x6kDtG4zz9MJGE1wM8g5EKxC7+KNja?=
=?Windows-1252?Q?jfLwPv+BUcr+b4OjAB4bn62UedGw8SA2n/p2LljGNb2rhwudU2egfrbO?=
=?Windows-1252?Q?OFnYSAsAiVLoa2IRRvZcy/qqRVeJIbpa3sRw7WAfeKJmKt+pgLHJ7NHo?=
=?Windows-1252?Q?o+mXYf/JxjDNGTHKS7o/ikRuWrLvM4MCtDjJfRzt/9/4K/DluqRKdZ4/?=
=?Windows-1252?Q?YgwhjJTSfSv3Uu8SYZoddULYRRUG69YST5fngGhVCU0X5/6YnFAGqiIk?=
=?Windows-1252?Q?GkAxYMT+4IfUpBG3YeboszHmMtS8yAlNoe3fT5F50jlI622RlD900j59?=
=?Windows-1252?Q?9eLCUg8fNX3RkN0DMZM5ud651CH3ou35fYeW87XlJdHy5MK+oc/aNPPr?=
=?Windows-1252?Q?58/i13LXZOccnYxiZC4fAotLIEspSj/+Ahu2UhLklqmRmVZiNOgm5iSQ?=
=?Windows-1252?Q?iHUs2DCofV/7/KmPzNcXC3JWg9Du+58Py5WDzyuiPugMfV3YDGyS27Ga?=
=?Windows-1252?Q?rpYCU//XSO5w2?=
X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715;
6:n6lcBRaMFmjWHOm4IDADmpyJlstH8UltU9koSxg3nMwiLI355EA2tL0vEE0r9ASKTQL7qX/1W35PcdX+Q3CRoxw/9Wug5OocFojwenPuTh0dzSdf1B+XP8ICsHbXn4slyI5kkKTGjjMu5NP5NjlIGtZ1SRS5W6ARcjBjV3dDfcTMy3JJNHIKPUV6IcNktkt51F8Xs9y0OEdZJCoavWv2/q1xwI6K5uh1vCGzFSp2uVa7ddi4OlzyzQdXw7wUQI3cKsPmt8e9lqPD47D+8gpNrjfAunuj/81jvLSlTCt2HNSJ9Fq5bCdUB8GGQavU8JfhYkFS4iYWtD3zbbl0dxziAehNgHL67Nhb4nrfAal6ns6Rg7rmX/QsYA8qH9fsQBB1NPDFFLBTf6iqEMWSGXBkFg==;
5:9LR7vHDoQVTayPlYQchYJIoh3EaUF7C0dxpxRfpjppeDELHOsF4e5H5QnmPk9bhTk+l6nBpHrLhjuuxrccpTVlZASDdqUsrZaqnFsk37Ljpl+nAeAIZDrN1NyfRSTWechMoRZ9FGG4gRH4QuWXUw3Q==;
24:NSPtB9gZZ1NlZ1FgfAD2wrkhKAb/qEzmyJIeba5I2ltQK1aDeNTB0Y1AjhlWssosiv8qq9RX1HLirED4zDnEt5i8gn5PEsVYC0yq/a/XcTE=
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715;
7:RkeY0sBzb5ZT43b5CyGwPtlbpq00yDZSD8JXAGc20cpzQNd/Hy9/paIj69aO/rmKoDuWW4PGCmWNKsmpju3k8653RZVUiUv+Tpagx9joQUmfXycBBQKqQLJHAU8Cu1qGZA9sLYEQySSpYhG/ABiJC21eMPDsf6YyvDx3hiZLwwy+fYoWL5nmvOTVOu4DpX0GmJUjPABI3SKbrRp9NpNZ7R/ofz2d0yqzAOZVnUYb4WLTuV0iz0z+nd1LwWevblJkt0d1Y5xFXKC5OdFI7so010hAAOD6s6ZJXKOoQe/giYC0YRDAxUDMm/jn2s9UvkjBqPM2t1AAubX2tSoARcvpXg==
X-OriginatorOrg: caviumnetworks.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2017 12:33:57.2400 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1715
Subject: Re: [dpdk-dev] [PATCH 1/2] test/mempool_perf: Free mempool on exit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Apr 2017 12:34:02 -0000
Hi Shreyansh,
On Wednesday 05 April 2017 03:27 PM, Shreyansh Jain wrote:
> Hello Santosh,
> On Wednesday 05 April 2017 02:21 PM, Santosh Shukla wrote:
>> Mempool_perf test not freeing pool memory.
>> Cc: stable@dpdk.org
>> Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
>> ---
>> test/test/test_mempool_perf.c | 31 +++++++++++++++++++------------
>> 1 file changed, 19 insertions(+), 12 deletions(-)
>> diff --git a/test/test/test_mempool_perf.c b/test/test/test_mempool_perf.c
>> index ebf1721..3c45971 100644
>> --- a/test/test/test_mempool_perf.c
>> +++ b/test/test/test_mempool_perf.c
>> @@ -312,6 +312,8 @@ struct mempool_test_stats {
>> static int
>> test_mempool_perf(void)
>> {
>> + int ret = -1;
>> +
>> rte_atomic32_init(&synchro);
>> /* create a mempool (without cache) */
>> @@ -322,7 +324,7 @@ struct mempool_test_stats {
> Can you check why the patch is showing "struct mempool_test_stats" as
> the context?
> I tried creating this patch and it shows "test_mempool_perf(void)" as
> context.
> off the topic, does it matter to maintainers if context is not correct?
> t
That was because of older git-version i.e. < 2.x.
I upgraded to 2.11.0 and applied same patch then did 'git show' shows
correct context.
So in short; Posted patch won't break anything. if end user has
git version < 2.x then he'll see disparity in patch context however
> 2.x won't.
In anycase I will post v2. Thanks for pointing out.
diff --git a/test/test/test_mempool_perf.c b/test/test/test_mempool_perf.c
index ebf1721ac..3c45971ab 100644
--- a/test/test/test_mempool_perf.c
+++ b/test/test/test_mempool_perf.c
@@ -312,6 +312,8 @@ do_one_mempool_test(unsigned cores)
static int
test_mempool_perf(void)
{
+ int ret = -1;
+
rte_atomic32_init(&synchro);
/* create a mempool (without cache) */
@@ -322,7 +324,7 @@ test_mempool_perf(void)
my_obj_init, NULL,
SOCKET_ID_ANY, 0);
if (mp_nocache == NULL)
- return -1;
+ goto err;
[...]
> Other than that:
> Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>
Thanks!,
>