From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52CF2A0C48; Wed, 7 Jul 2021 08:39:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 041D041312; Wed, 7 Jul 2021 08:39:31 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 8D389406FF for ; Wed, 7 Jul 2021 08:39:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625639968; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q6vIDP0NLjfoepQLSTiX4EhOpa0gsBHoTrqnQRPXmqY=; b=DAQDfHMDmLv1DWy4BNPyPrygwGrln0SISq6JnlWp/0pFLIJZJC9E+FadYBm3T/ihE1V/2e 4hM/OBG8Vv1yYlGimPJOhDJVLgbhaxsQ7bA2c1EjZUHdC08XBJ6mx5JMJ7/CuL4jRXetuw fHoXvRDbAcxfGZVe7u5+XvCQyAtmCBg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-479-PcGI2nXEMJuATEwtyLGGdA-1; Wed, 07 Jul 2021 02:39:25 -0400 X-MC-Unique: PcGI2nXEMJuATEwtyLGGdA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1C9DA800C78; Wed, 7 Jul 2021 06:39:24 +0000 (UTC) Received: from [10.36.110.10] (unknown [10.36.110.10]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 025391017CE5; Wed, 7 Jul 2021 06:39:15 +0000 (UTC) To: Jiayu Hu , dev@dpdk.org Cc: chenbo.xia@intel.com, yinan.wang@intel.com References: <1622189463-392610-2-git-send-email-jiayu.hu@intel.com> <1625656687-40604-1-git-send-email-jiayu.hu@intel.com> <1625656687-40604-3-git-send-email-jiayu.hu@intel.com> From: Maxime Coquelin Message-ID: <116a2773-2028-aa04-9028-13e1bd8aeee9@redhat.com> Date: Wed, 7 Jul 2021 08:39:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <1625656687-40604-3-git-send-email-jiayu.hu@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 2/3] vhost: rework async feature struct X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Jiayu, On 7/7/21 1:18 PM, Jiayu Hu wrote: > No need to use bitfields in the structure rte_vhost_async_features. > This patch reworks the structure to improve code readability. In > addition, add preserved padding fields on the structure for future > usage. > > Signed-off-by: Jiayu Hu > --- > examples/vhost/main.c | 4 ++-- > lib/vhost/rte_vhost_async.h | 24 ++++++++---------------- > lib/vhost/vhost.c | 13 +++++-------- > 3 files changed, 15 insertions(+), 26 deletions(-) > > diff --git a/examples/vhost/main.c b/examples/vhost/main.c > index d2179ea..ec1a5b4 100644 > --- a/examples/vhost/main.c > +++ b/examples/vhost/main.c > @@ -1468,7 +1468,7 @@ new_device(int vid) > vid, vdev->coreid); > > if (async_vhost_driver) { > - struct rte_vhost_async_features f; > + struct rte_vhost_async_features f = {0}; > struct rte_vhost_async_channel_ops channel_ops; > > if (dma_type != NULL && strncmp(dma_type, "ioat", 4) == 0) { > @@ -1480,7 +1480,7 @@ new_device(int vid) > f.async_threshold = 256; > > return rte_vhost_async_channel_register(vid, VIRTIO_RXQ, > - f.intval, &channel_ops); > + f, &channel_ops); > } > } > > diff --git a/lib/vhost/rte_vhost_async.h b/lib/vhost/rte_vhost_async.h > index 6faa31f..12c6962 100644 > --- a/lib/vhost/rte_vhost_async.h > +++ b/lib/vhost/rte_vhost_async.h > @@ -93,18 +93,13 @@ struct async_inflight_info { > }; > > /** > - * dma channel feature bit definition > + * dma channel features > */ > struct rte_vhost_async_features { Give the struct also contains config/tuning stuff, I don't think rte_vhost_async_features is a good name, maybe rte_vhost_async_config? > - union { > - uint32_t intval; > - struct { > - uint32_t async_inorder:1; > - uint32_t resvd_0:15; > - uint32_t async_threshold:12; > - uint32_t resvd_1:4; > - }; > - }; > + uint32_t async_threshold; > + uint32_t resvd_0[13]; That's a lot of padding! I hope the application won't have to use that much to configure the async feature one day :) > + uint8_t async_inorder; I would prefer a uint32_t features bitfield for consistency with Vhost library, with enums for the features definition. > + uint8_t resvd_1[7]; > }; > > /** > @@ -115,11 +110,7 @@ struct rte_vhost_async_features { > * @param queue_id > * vhost queue id async channel to be attached to > * @param features > - * DMA channel feature bit > - * b0 : DMA supports inorder data transfer > - * b1 - b15: reserved > - * b16 - b27: Packet length threshold for DMA transfer > - * b28 - b31: reserved > + * DMA channel feature structure > * @param ops > * DMA operation callbacks > * @return > @@ -127,7 +118,8 @@ struct rte_vhost_async_features { > */ > __rte_experimental > int rte_vhost_async_channel_register(int vid, uint16_t queue_id, > - uint32_t features, struct rte_vhost_async_channel_ops *ops); > + struct rte_vhost_async_features features, > + struct rte_vhost_async_channel_ops *ops); > > /** > * unregister a dma channel for vhost > diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c > index 53a470f..835aad8 100644 > --- a/lib/vhost/vhost.c > +++ b/lib/vhost/vhost.c > @@ -1620,18 +1620,15 @@ int rte_vhost_extern_callback_register(int vid, > } > > int rte_vhost_async_channel_register(int vid, uint16_t queue_id, > - uint32_t features, > - struct rte_vhost_async_channel_ops *ops) > + struct rte_vhost_async_features features, > + struct rte_vhost_async_channel_ops *ops) > { > struct vhost_virtqueue *vq; > struct virtio_net *dev = get_device(vid); > - struct rte_vhost_async_features f; > > if (dev == NULL || ops == NULL) > return -1; > > - f.intval = features; > - > if (queue_id >= VHOST_MAX_VRING) > return -1; > > @@ -1640,7 +1637,7 @@ int rte_vhost_async_channel_register(int vid, uint16_t queue_id, > if (unlikely(vq == NULL || !dev->async_copy)) > return -1; > > - if (unlikely(!f.async_inorder)) { > + if (unlikely(!features.async_inorder)) { > VHOST_LOG_CONFIG(ERR, > "async copy is not supported on non-inorder mode " > "(vid %d, qid: %d)\n", vid, queue_id); > @@ -1720,8 +1717,8 @@ int rte_vhost_async_channel_register(int vid, uint16_t queue_id, > vq->async_ops.check_completed_copies = ops->check_completed_copies; > vq->async_ops.transfer_data = ops->transfer_data; > > - vq->async_inorder = f.async_inorder; > - vq->async_threshold = f.async_threshold; > + vq->async_inorder = features.async_inorder; > + vq->async_threshold = features.async_threshold; > > vq->async_registered = true; > >