From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id DCBEB1B1BC for ; Sat, 11 Nov 2017 15:53:09 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6410720CE9; Sat, 11 Nov 2017 09:53:09 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Sat, 11 Nov 2017 09:53:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=uSCmzJmBZQe/dCV5+1vDtt2bn8 OhQX9J+duZw36RubM=; b=P4vVLxIXSHYkEZZ4rZwsB2GHfLtnZtG/am4MEzy7F9 LUW3lOVx1DGSkINFTIooKgTVeyve8TEPmaHHJJiQj87Epy2OD+xFyfYQalC0Pfu1 H0v5ksU2S/g0d3QiwIn8k1A7LMUwle78El9IQ9VsMRRPo1KMhuEIc6iOj0hsEJfF k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=uSCmzJ mBZQe/dCV5+1vDtt2bn8OhQX9J+duZw36RubM=; b=D+IRRoTRC1+oQ9c/C/HaxD Iz4c2sRbJYAVuqHa5WnwTiT16GGNPST85dAMuhjBYs498EwBfHx3iQUiFrcOJHWS p1H0TRzcIU5dSDFDvfCmu1rsRWiIEMmXm5EDp7eNR6qRr2D9u35lBrCA9B+egeD6 Pmx1nPcPjB5g5SL4lEGxiYFfzbcSpDs43/zApuFwcbwOK6KtmlOJ1G0gP1jjR0UZ fjYbxSi6V/9+iuS2RKLm04nRiN71p/WQX4tvv+VM/7nVWioGhGF8o7KV1inUS/nT t/enIiMt9JSAMIwbEHpQgfMrPMyq4KHI9eJFFFyygJhr+4aOuCCIUTsTI15WxCcA == X-ME-Sender: Received: from xps.localnet (unknown [89.248.140.13]) by mail.messagingengine.com (Postfix) with ESMTPA id 063057F8FC; Sat, 11 Nov 2017 09:53:09 -0500 (EST) From: Thomas Monjalon To: Adrien Mazarguil , Matan Azrad Cc: dev@dpdk.org, Ophir Munk , Moti Haimovsky , Olga Shern Date: Sat, 11 Nov 2017 15:53:07 +0100 Message-ID: <11709391.GH4dFWTqEr@xps> In-Reply-To: <20171110150241.GI24849@6wind.com> References: <1510302438-29138-1-git-send-email-matan@mellanox.com> <20171110150241.GI24849@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/mlx4: fix last Tx wqe stamping lack X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Nov 2017 14:53:10 -0000 10/11/2017 16:02, Adrien Mazarguil: > On Fri, Nov 10, 2017 at 08:27:18AM +0000, Matan Azrad wrote: > > When Tx pakcet HW processing is done, SW should stamp all the completion > > burst WQEs. > > > > Stamp missed last completion burst WQE. > > > > Fixes: c3c977bbecbd ("net/mlx4: add Tx bypassing Verbs") > > > > Signed-off-by: Matan Azrad > > This reads like you were in a hurry :) > > Took me a while to understand the problem and how you addressed it. So in > short, wqe_index is consumed but its TXBBs aren't stamped because the loop > stops at its index without processing it. > > Patch looks good but could have been simpler by directly initializing > nr_txbbs to sq->tail, not use sq->tail as an offset afterward and get rid of > sq_tail. It's OK as this wouldn't have resulted in a smaller patch anyway. > > Commit log rewording suggestion: > > net/mlx4: fix missing stamp during Tx completion > > After processing completed packets, the owner bit of each TXBB comprised > in its WQEs must be invalidated. The loop stops short of processing the > last WQE. > > Other than that, > > Acked-by: Adrien Mazarguil Applied with suggested commit log, thanks