From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A82CA0C41; Sat, 9 Oct 2021 11:54:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4396040040; Sat, 9 Oct 2021 11:54:02 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 9AFBD4003C for ; Sat, 9 Oct 2021 11:54:00 +0200 (CEST) Received: from dggeme756-chm.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4HRKz131p6zYkNp; Sat, 9 Oct 2021 17:49:33 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by dggeme756-chm.china.huawei.com (10.3.19.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.8; Sat, 9 Oct 2021 17:53:54 +0800 To: Thomas Monjalon CC: , , References: <20210922033630.41130-1-humin29@huawei.com> <2236789.hR5l6LFQDr@thomas> <5857742.MVTgjyL6ng@thomas> From: "Min Hu (Connor)" Message-ID: <117602c7-b6d3-f4e3-1b3d-c12da6dca113@huawei.com> Date: Sat, 9 Oct 2021 17:53:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <5857742.MVTgjyL6ng@thomas> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggeme756-chm.china.huawei.com (10.3.19.102) X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH] ethdev: fix one MAC address occupies two index in mac addrs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Thomas, The dev->data->mac_addrs[0] will be changed to a new MAC address when applications modify the default MAC address by rte_eth_dev_default_mac_addr_set() API. However, If the new default MAC address has been added as a non-default MAC address by rte_eth_dev_mac_addr_add() API, the rte_eth_dev_default_mac_addr_set() API doesn't remove it from dev->data->mac_addrs[]. As a result, one MAC address occupies two index capacities in dev->data->mac_addrs[]. This patch adds the logic of removing MAC addresses for this scenario. Is that will be more clear? Hope for your reply 在 2021/10/8 18:04, Thomas Monjalon 写道: > 08/10/2021 09:02, Min Hu (Connor): >> Hi, Thomas, >> >> 在 2021/10/6 3:21, Thomas Monjalon 写道: >>> 22/09/2021 05:36, Min Hu (Connor): >>>> From: Huisong Li >>>> >>>> Use the testpmd to perform the following operations: >>>> 1) mac_addr add 0 00:18:2D:00:00:90 >>>> 2) mac_addr add 0 00:18:2D:00:00:91 >>>> 3) mac_addr add 0 00:18:2D:00:00:92 >>>> 4) mac_addr set 0 00:18:2D:00:00:91 >>>> 5) show port 0 macs >>>> Number of MAC address added: 4 >>>> 00:18:2D:00:00:91 >>>> 00:18:2D:00:00:90 >>>> 00:18:2D:00:00:91 >>>> 00:18:2D:00:00:92 >>> >>> Please describe with words. >>> Reading similar MAC addresses is not a fun game. >> >> I do not catch you, could you please be >> more detailed, thanks. > > Me too, I don't catch you. > Please explain the problem in the commit log > so we can understand without the example. > >>>> This is due to the reason that if the address has been added as a >>>> non-default MAC address by rte_eth_dev_mac_addr_add API, it doesn't remove >>>> from dev->data->mac_addrs[] when set default MAC address with the same >>>> address. >>>> >>>> Fixes: 854d8ad4ef68 ("ethdev: add default mac address modifier") >>>> Cc: stable@dpdk.org >>>> >>>> Signed-off-by: Huisong Li >>>> Signed-off-by: Min Hu (Connor) > > > > . >