From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 637FFA04DB; Mon, 16 Nov 2020 10:24:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BE600323E; Mon, 16 Nov 2020 10:23:59 +0100 (CET) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id C95BC2BF1 for ; Mon, 16 Nov 2020 10:23:57 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 6F04B5800FE; Mon, 16 Nov 2020 04:23:54 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 16 Nov 2020 04:23:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= hOTnPU2AYV1y4AX7aRMQiJz6rbqb03D0vJ5C5J1gkuM=; b=aHmLv/Ek2jd4QTQF E7gUYb+642BdG3JEAbPfB76dmi/9EnYcmFJiGYO2NtJ8Vjij0tjket+uqN/MxWL5 nix4juotfLYZKGKLlqmaRuiHBcCpdZYasQT+HxFQDz3x1KSgdV/DRCXiuEdfRy0k T/Pv2+tOjDUNal5c8oRilI/Pv8lvuZWJfyPW+ThtU+ja+3azR3TNUib+seDZo6oO QsXsen9iAqCaa6kknCkucWI6ajcNRaWHxSSScTIcNA/jNu3ZSQdJ0eB07DhwyEM7 EKC4lAXMEFXgVHFVIlTTib7vuKHHfANMjVUzggxuugA+Et7iqrC+9hrtniHcX9rc FjLlxA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=hOTnPU2AYV1y4AX7aRMQiJz6rbqb03D0vJ5C5J1gk uM=; b=YtUwayh9Jtreb0WxluegouGkMqlK6Oh7snvgSDPDtnTK00mK00wR7zEpE QT7IwN/eyj9C91TpUFaFEpEmwHM3cA7sj/4vlFtX02f5nnMKSFIyepsQUaA9fDvt 3QAwBgzPNEYkVrW4XDPOpwcmcs/9nLiS4huW/k+UmLaKbq+RfoofgD0PY56u5M5G ZBJeFb0ogHB1JbOfqyRrR+SKtw1kXq+nRYlyAwLBXld5zn+808QHe3z63uoFqsZL EptPKam2nov9bHdni+kU453ZkuYQ3/z5082HAwKg5pxjekkZ5IgJyPiajpJppXLn HY+/yBoOSW7dPE+iJ1EqhUYHSIczw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudefuddgtdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepueehueeuvdfggefftdeilefgtdfggfejfeehveekieegvdduieei uddtuedufeeunecuffhomhgrihhnpeguvghtvggtthhiohhnrdhsohenucfkphepjeejrd dufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehm rghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0B51B3064AAA; Mon, 16 Nov 2020 04:23:51 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: Juraj =?utf-8?B?TGlua2XFoQ==?= , Ruifeng.Wang@arm.com, Honnappa.Nagarahalli@arm.com, Phil.Yang@arm.com, vcchunga@amazon.com, Dharmik.Thakkar@arm.com, jerinjacobk@gmail.com, hemant.agrawal@nxp.com, ajit.khaparde@broadcom.com, ferruh.yigit@intel.com, dev@dpdk.org Date: Mon, 16 Nov 2020 10:23:50 +0100 Message-ID: <11763925.GOiJPSdkav@thomas> In-Reply-To: <20201116091303.GA1469@bricha3-MOBL.ger.corp.intel.com> References: <1605267483-13167-1-git-send-email-juraj.linkes@pantheon.tech> <6632500.QiOchURiYm@thomas> <20201116091303.GA1469@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v12 09/14] build: optional NUMA and cpu counts detection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/11/2020 10:13, Bruce Richardson: > On Mon, Nov 16, 2020 at 08:24:48AM +0100, Thomas Monjalon wrote: > > 13/11/2020 15:31, Juraj Linke=C5=A1: > > > +option('max_lcores', type: 'integer', value: 0, > > > + description: 'maximum number of cores/threads supported by EAL. Set= to positive integer to overwrite per-arch or cross-compilation defaults. S= et to -1 to detect the number of cores on the build machine.') > > > +option('max_numa_nodes', type: 'integer', value: 0, > > > + description: 'maximum number of NUMA nodes supported by EAL. Set to= positive integer to overwrite per-arch or cross-compilation defaults. Set = to -1 to detect the number of numa nodes on the build machine.') > >=20 > > First comment: I don't like having so long description. > > Second: I don't understand. > >=20 > > It is said the default value is 0 so I expect it means automatic detect= ion. > > But later it is said -1 is for detection. So ? > >=20 > Zero is for the "per-arch or cross-compilation default". This was discuss= ed > quite a bit in previous versions and this was te best compromise we could > come up with. Having a default of auto-detect is definitely not something= I > think we should go with - just thinking of all the build CI jobs running = on > 2 or 4 core VMs! However, Juraj really felt there was value in having > auto-detection, so it's set as a -1 value, which I'm ok with. The problem is that I don't understand what 0 means. > As I flagged in a previous mail thread, the whole config of DPDK builds is > something we need to take a bigger look at in 21.02 and beyond. Yes definitely.