From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A10CDA00C5; Tue, 7 Jul 2020 01:38:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 801761DC50; Tue, 7 Jul 2020 01:38:55 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id EC5201DC0F for ; Tue, 7 Jul 2020 01:38:53 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 6FF915C0179; Mon, 6 Jul 2020 19:38:53 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 06 Jul 2020 19:38:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= C9mkH1yYAV7DzAtIvRbfoF2GNLE89qARqEhlZkc6bHE=; b=H+KpwY4RZ1p6RQ9z gOX3TEkZ2dWJdoN7rH/utuCqWpCf/w6MjMVv5HTkyciSWmFoXVCx8X1Xey0+h19k WaZs9vxdaCS+3sDHoTO1MHfv/trRST/BnpDB9R7FIBBZtFKKrv8tZ6snJCRvq1LB LuCeg1Mug15KhgPbHnrEkDn1pwQvaQFua32oPYFCcY1nE4Hh2BpKLA3XaK4fsSXz Ba0/adTrNycZpEBhYxC+0NAj+m9Yrca/hY+2YHFopgTbckrdb7HSEw1oueQNZ0Y4 xSz/lv9mmnrm2XWPKvzijPgC9Zuoc7ymJ9/myFnBjXZjVUJwz/WcblpIOKY6Pr5+ HvuOJQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=C9mkH1yYAV7DzAtIvRbfoF2GNLE89qARqEhlZkc6b HE=; b=rDzS9iRFEakfNy6JyuuH1lSYzVNaW+0fWpr/SnFtjSk2t1pJZsW9Ikpg0 OXpBAfZdxH0Fx1s6xtV6C0vZ2zm2IUA+vfFU3NXXN5ylKtDKLTAaoiFQcyxHwh0n SPuwzTw0vJH2Tvey3xBhWKpLURNFui7jbyONYJPf3GsO8DCsON9K+s7EwJNQ489O muE9D8Seh4FM4682fZKnc8pAVSIVISmUDcOUwSlD/NmLNeMb7rclf7HUreWEF1fm jB48R4GD1cW00vK8ZHF1bageqEZOgdbgXVeLJg3H9ry7OF2Rq9CtUpKZgnhXuDAt sxv19YG+Bro+jbc4Ycp2TlUhbU8sw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrudeggddvhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4758E30653F9; Mon, 6 Jul 2020 19:38:51 -0400 (EDT) From: Thomas Monjalon To: pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com, ranjit.menon@intel.com, navasile@linux.microsoft.com, harini.ramakrishnan@microsoft.com Cc: dev@dpdk.org, david.marchand@redhat.com, grive@u256.net, ocardona@microsoft.com, Tal Shnaiderman Date: Tue, 07 Jul 2020 01:38:50 +0200 Message-ID: <11810299.sBPFmhH6xa@thomas> In-Reply-To: <20200624145621.26604-2-talshn@mellanox.com> References: <20200624145621.26604-1-talshn@mellanox.com> <20200624145621.26604-2-talshn@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/2] eal/windows: Add needed calls to detect vdev PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Windows team, I am expecting at least 2 reviews on this patch. 24/06/2020 16:56, talshn@mellanox.com: > From: Tal Shnaiderman > > Add needed function calls in rte_eal_init to detect vdev PMD. > > eal_option_device_parse() > rte_service_init() > rte_bus_probe() > > Signed-off-by: Tal Shnaiderman > --- > lib/librte_eal/common/meson.build | 1 + > lib/librte_eal/windows/eal.c | 19 +++++++++++++++++++ > 2 files changed, 20 insertions(+) > > diff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build > index dc9b1d2feb..a38b66a2d0 100644 > --- a/lib/librte_eal/common/meson.build > +++ b/lib/librte_eal/common/meson.build > @@ -30,6 +30,7 @@ if is_windows > 'malloc_heap.c', > 'rte_malloc.c', > 'eal_common_timer.c', > + 'rte_service.c', > ) > subdir_done() > endif > diff --git a/lib/librte_eal/windows/eal.c b/lib/librte_eal/windows/eal.c > index d8cfe5cc4d..8e89560aba 100644 > --- a/lib/librte_eal/windows/eal.c > +++ b/lib/librte_eal/windows/eal.c > @@ -270,6 +270,11 @@ rte_eal_init(int argc, char **argv) > if (fctret < 0) > exit(1); > > + if (eal_option_device_parse()) { > + rte_errno = ENODEV; > + return -1; > + } > + > /* Prevent creation of shared memory files. */ > if (internal_conf->in_memory == 0) { > RTE_LOG(WARNING, EAL, "Multi-process support is requested, " > @@ -359,6 +364,20 @@ rte_eal_init(int argc, char **argv) > rte_panic("Cannot create thread\n"); > } > > + /* initialize services so vdevs register service during bus_probe. */ > + if (rte_service_init()) { > + rte_eal_init_alert("rte_service_init() failed"); > + rte_errno = ENOEXEC; > + return -1; > + } > + > + /* Probe all the buses and devices/drivers on them */ > + if (rte_bus_probe()) { > + rte_eal_init_alert("Cannot probe devices"); > + rte_errno = ENOTSUP; > + return -1; > + } > + > /* > * Launch a dummy function on all slave lcores, so that master lcore > * knows they are all ready when this function returns.