Re: vmxnet3 no longer functional on DPDK 21.11

[Lewis Donzis <lew@perftech.com>]

Hi, Bruce.

I'm even less familiar with it, but we do quite a lot of testing using VMs, so it's been quite handy.

Your patch seems very reasonable, however it also produces a warning:

../drivers/net/vmxnet3/vmxnet3_ethdev.c:264:1: warning: unused function 'vmxnet3_enable_all_intrs' [-Wunused-function]

Adding an #ifndef around vmxnet3_enable_all_intrs() eliminates that warning.

Please pardon the uninformed view, but we've been using FreeBSD + DPDK for nearly a decade, and I thought the whole point was to avoid using interrupts.  We have no need or desire for them in our applications, so we just hope the sprinkling of interrupt support code throughout the drivers doesn't cause any harm.  But I also realize we're probably in the minority on this.

Thanks for the help,
lew



> I'm not at all familiar with the vmxnet3 driver, so apologies for the lack
> of response up till now. Does something like the below simple fix work for
> you? If so, I'm happy enough to submit as a patch for upstream merge and
> then backport.
> 
> /Bruce
> 
> diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c
> b/drivers/net/vmxnet3/vmxnet3_ethdev.c
> index e49191718a..d088b42d35 100644
> --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
> +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
> @@ -1129,6 +1129,7 @@ vmxnet3_dev_start(struct rte_eth_dev *dev)
>        /* Setting proper Rx Mode and issue Rx Mode Update command */
>        vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_BCAST, 1);
> 
> +#ifndef RTE_EXEC_ENV_FREEBSD
>        /* Setup interrupt callback  */
>        rte_intr_callback_register(dev->intr_handle,
>                                   vmxnet3_interrupt_handler, dev);
> @@ -1140,6 +1141,7 @@ vmxnet3_dev_start(struct rte_eth_dev *dev)
> 
>        /* enable all intrs */
>        vmxnet3_enable_all_intrs(hw);
> +#endif
> 
>         vmxnet3_process_events(dev);