From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 669D743881; Wed, 10 Jan 2024 11:22:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DA4AA40298; Wed, 10 Jan 2024 11:22:10 +0100 (CET) Received: from smtp-gw.pt.net (smtp-gw.pt.net [206.210.192.15]) by mails.dpdk.org (Postfix) with ESMTP id 977704013F for ; Tue, 9 Jan 2024 14:46:50 +0100 (CET) X-ASG-Debug-ID: 1704808008-09411a10bb23085e0001-TfluYd Received: from mail.pt.net (mail.pt.net [206.210.194.11]) by smtp-gw.pt.net with ESMTP id FjajEp9vncRhXqqB (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 09 Jan 2024 07:46:48 -0600 (CST) X-Barracuda-Envelope-From: lew@perftech.com X-Barracuda-Effective-Source-IP: mail.pt.net[206.210.194.11] X-Barracuda-Apparent-Source-IP: 206.210.194.11 Received: from localhost (localhost [IPv6:::1]) by mail.pt.net (Postfix) with ESMTP id 8F2211B0BE17; Tue, 9 Jan 2024 07:46:48 -0600 (CST) Received: from mail.pt.net ([IPv6:::1]) by localhost (mail.pt.net [IPv6:::1]) (amavis, port 10032) with ESMTP id J67s3a4gHm8r; Tue, 9 Jan 2024 07:46:48 -0600 (CST) Received: from localhost (localhost [IPv6:::1]) by mail.pt.net (Postfix) with ESMTP id 3007A1B0BD7C; Tue, 9 Jan 2024 07:46:48 -0600 (CST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.pt.net 3007A1B0BD7C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=perftech.com; s=B15A3A56-ABEA-11EE-9719-5F12F125680F; t=1704808008; bh=ArrvjjDBxix+98Xf1cn4OLOLqyKdSSacAkb3+Hfje0k=; h=Date:From:To:Message-ID:MIME-Version; b=a8ekDPeqvv+wcXjCf5jWdNyVEwCfWVIcATIWFEtEUmDUUM+noJaGuDbITHG+3S07B 8xUoXhDPbRSlPaot++rUavXSlJHVEGhJun2kbtJ0vF4BfW5HFWuGErYRn4n7joDbTy ctr1p68jyI6BS1Y1e7cN7EFY1kkMHkE0gEtgRIo7BlM62jeqdGnNOrvxx1O72Le4aJ Sa/9ZHo6MvOPlZHipq64YUr66tkrgMO+apcBa5fXT9lLPjBEDy4pkCci84kTA48q7y sD2G+m/PivQFIkUBhh6ycRhHsMtUujWBU12YBMle5uweFNEH6jpbpYkrcQLaZ0jEla Ma3tQUhafO3og== X-Virus-Scanned: amavis at pt.net Received: from mail.pt.net ([IPv6:::1]) by localhost (mail.pt.net [IPv6:::1]) (amavis, port 10026) with ESMTP id DRYmQjFp8Hdl; Tue, 9 Jan 2024 07:46:48 -0600 (CST) Received: from mail.pt.net (mail.pt.net [206.210.194.11]) by mail.pt.net (Postfix) with ESMTP id 1BC941B0BE15; Tue, 9 Jan 2024 07:46:48 -0600 (CST) Date: Tue, 9 Jan 2024 07:46:47 -0600 (CST) From: Lewis Donzis To: Bruce Richardson Cc: Konstantin Ananyev , dev , "Wang, Yong" Message-ID: <1182416671.1246287.1704808007894.JavaMail.zimbra@donzis.com> In-Reply-To: References: <2134779104.413217.1638218715124.JavaMail.zimbra@donzis.com> <1909271468.2730688.1638755553311.JavaMail.zimbra@donzis.com> <1796133353.5470017.1654262374494.JavaMail.zimbra@donzis.com> <12922153.12944.1704552603431.JavaMail.zimbra@donzis.com> Subject: Re: vmxnet3 no longer functional on DPDK 21.11 MIME-Version: 1.0 X-ASG-Orig-Subj: Re: vmxnet3 no longer functional on DPDK 21.11 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Originating-IP: [206.210.194.11] X-Mailer: Zimbra 8.8.15_GA_4581 (ZimbraWebClient - GC120 (Mac)/8.8.15_GA_4581) Thread-Topic: vmxnet3 no longer functional on DPDK 21.11 Thread-Index: 1gaKRMH57cTWqS5+BLg9YrYyHEDrvQ== X-Barracuda-Connect: mail.pt.net[206.210.194.11] X-Barracuda-Start-Time: 1704808008 X-Barracuda-Encrypted: TLS_AES_256_GCM_SHA384 X-Barracuda-URL: https://smtp-gw.pt.net:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at pt.net X-Barracuda-Scan-Msg-Size: 1922 X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=9.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.119187 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Mailman-Approved-At: Wed, 10 Jan 2024 11:22:09 +0100 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Bruce. I'm even less familiar with it, but we do quite a lot of testing using VMs, so it's been quite handy. Your patch seems very reasonable, however it also produces a warning: ../drivers/net/vmxnet3/vmxnet3_ethdev.c:264:1: warning: unused function 'vmxnet3_enable_all_intrs' [-Wunused-function] Adding an #ifndef around vmxnet3_enable_all_intrs() eliminates that warning. Please pardon the uninformed view, but we've been using FreeBSD + DPDK for nearly a decade, and I thought the whole point was to avoid using interrupts. We have no need or desire for them in our applications, so we just hope the sprinkling of interrupt support code throughout the drivers doesn't cause any harm. But I also realize we're probably in the minority on this. Thanks for the help, lew > I'm not at all familiar with the vmxnet3 driver, so apologies for the lack > of response up till now. Does something like the below simple fix work for > you? If so, I'm happy enough to submit as a patch for upstream merge and > then backport. > > /Bruce > > diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c > b/drivers/net/vmxnet3/vmxnet3_ethdev.c > index e49191718a..d088b42d35 100644 > --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c > +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c > @@ -1129,6 +1129,7 @@ vmxnet3_dev_start(struct rte_eth_dev *dev) > /* Setting proper Rx Mode and issue Rx Mode Update command */ > vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_BCAST, 1); > > +#ifndef RTE_EXEC_ENV_FREEBSD > /* Setup interrupt callback */ > rte_intr_callback_register(dev->intr_handle, > vmxnet3_interrupt_handler, dev); > @@ -1140,6 +1141,7 @@ vmxnet3_dev_start(struct rte_eth_dev *dev) > > /* enable all intrs */ > vmxnet3_enable_all_intrs(hw); > +#endif > > vmxnet3_process_events(dev);