From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85B4CA00C2; Wed, 2 Nov 2022 13:29:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6481940223; Wed, 2 Nov 2022 13:29:56 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id DD03940041 for ; Wed, 2 Nov 2022 13:29:54 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 284815C0089; Wed, 2 Nov 2022 08:29:53 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 02 Nov 2022 08:29:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1667392193; x= 1667478593; bh=ZMxD1vVRPWVrcAYxofvULR2NEjSl0+rf/uLbRlFzGUQ=; b=k cxuxtJIg4N2dyMfmWmDDWKER8DYruLOXEDQRau1Rl3ARiyeuaKnWIxjUqse0tqK9 Uj1yCAPItRMzrp+PSF94dmBfmmjok4w7qTbxq77gHoaDmDPfTTb3tccveFbBGLnd +EHP4P+ytvYXsqZsYVd2AfVbpPBY+TYUjQnXlmt91Rm9alQpG9Dt+zcPmb6uIjrK ANOa9abK4OwjwAXQJ9bTPYbBGe7v/zfqBnrHOhaa76PgaPYwClX6/vUojYLTUy5/ ixCYI4RFCigWuFPr4XYUr3zPmyEgomWjvRcRQDxjw8nubAelac4Upm1+ycGqhiRB Y7ONZ3dAjDXUZ4QxmD3Ig== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1667392193; x= 1667478593; bh=ZMxD1vVRPWVrcAYxofvULR2NEjSl0+rf/uLbRlFzGUQ=; b=t zKCnFF0S9CKzsaHyvvDVHJkzZPFstOZ8vsjRw8bYy9Yjhoyw2rslokeDU1Uit+v2 aSRQy7m7/qZe6s3O4AJrHKRc/AL0/tS10cVUnkhqvnEdEzt5SXmwoWFzmced6Czb DGPgjL+uXXMdRFGMsmvTF+EICBPp0ZcDaw/ns163eUGSwkPmAuFd4ehF6GTBjGr5 SdQsihS/4y7PzlvQrQGLkXx1+t6qoINNnIUC3M+nT8fN0SFXAB8RkzWAgGy2N8iF n3FP0cpGHnCGThEqfMDvSz1Ivqm7iA3uhvB7Dxe5RTFi1WVHUR7e/lUeKG0LD9Bx ykaumUdODTDSh0GjjDHYg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrudejgdegtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 2 Nov 2022 08:29:51 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, valex@nvidia.com, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru, rasland@nvidia.com, david.marchand@redhat.com, Matan Azrad , Fan Zhang , Ashish Gupta , Viacheslav Ovsiienko , Ori Kam Subject: Re: [PATCH v2 1/2] common/mlx5: fix build disabling Date: Wed, 02 Nov 2022 13:29:49 +0100 Message-ID: <11826899.zAa99ISigo@thomas> In-Reply-To: References: <20221030082722.1333530-2-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 02/11/2022 13:10, Bruce Richardson: > On Sun, Oct 30, 2022 at 09:27:21AM +0100, Thomas Monjalon wrote: > > If the dependency common/mlx5 is explicitly disabled, > > but net/mlx5 is not explicitly disabled, > > Meson will read the full recipe of net/mlx5 > > and will fail when accessing a variable from common/mlx5: > > drivers/net/mlx5/meson.build:76:4: ERROR: Unknown variable "mlx5_config". > > > > The solution is to stop parsing net/mlx5 if common/mlx5 is disabled. > > The deps array must be defined before stopping, in order to automatically > > disable the build of net/mlx5 and print the reason. > > > > The same protection is applied to other mlx5 drivers, > > so it will allow using the variable mlx5_config in future. > > > > Fixes: 22681deead3e ("net/mlx5/hws: enable hardware steering") > > > > Reported-by: Andrew Rybchenko > > Signed-off-by: Thomas Monjalon > > Tested-by: Andrew Rybchenko > > --- > > drivers/compress/mlx5/meson.build | 5 +++++ > > drivers/crypto/mlx5/meson.build | 5 +++++ > > drivers/net/mlx5/meson.build | 5 +++++ > > drivers/regex/mlx5/meson.build | 5 +++++ > > drivers/vdpa/mlx5/meson.build | 5 +++++ > > 5 files changed, 25 insertions(+) > > > > diff --git a/drivers/compress/mlx5/meson.build b/drivers/compress/mlx5/meson.build > > index 7aac329986..49ce3aff46 100644 > > --- a/drivers/compress/mlx5/meson.build > > +++ b/drivers/compress/mlx5/meson.build > > @@ -9,6 +9,11 @@ endif > > > > fmt_name = 'mlx5_compress' > > deps += ['common_mlx5', 'eal', 'compressdev'] > > +if not ('mlx5' in common_drivers) > > While this is fine as-is, I think the more usual way for checking the > presence of a component in DPDK is to check dpdk_conf. In this case the > check would be "if not dpdk_conf.has('RTE_COMMON_MLX5')". You may want to > consider using that for consistency. Yes, I've forgotten this: lib_name = '_'.join(['rte', class, name]) dpdk_conf.set(lib_name.to_upper(), 1) Then what is the usage of this? set_variable(class + '_drivers', enabled_drivers)