From: "Chautru, Nicolas" <nicolas.chautru@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
"Pattan, Reshma" <reshma.pattan@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Laatz, Kevin" <kevin.laatz@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] lib/telemetry: add support to fetch global metrics
Date: Mon, 24 Jun 2019 17:36:30 +0000 [thread overview]
Message-ID: <1183128033837D43A851F70F33ED5C575C1C08BD@FMSMSX109.amr.corp.intel.com> (raw)
In-Reply-To: <2244847.ebtGzxeqCD@xps>
Hi Reshma,
I am still seeing build issue when rebasing to this : ie. checking uint32_t is negative in rte_telemetry.c:558
Thanks
Nic
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
Sent: Monday, June 24, 2019 7:54 AM
To: Pattan, Reshma <reshma.pattan@intel.com>
Cc: dev@dpdk.org; Laatz, Kevin <kevin.laatz@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] lib/telemetry: add support to fetch global metrics
18/06/2019 15:49, Reshma Pattan:
> telemetry has support for fetching port based stats from metrics
> library.
>
> Metrics library also has global stats which are not fetched by
> telemetry, so extend telemetry to fetch the global metrics.
>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> Acked-by: Kevin Laatz <kevin.laatz@intel.com>
> ---
> v2: fix GCC compilation issues.
> rebase with latest release notes.
Applied, thanks
next prev parent reply other threads:[~2019-06-24 17:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 16:07 [dpdk-dev] [PATCH] " Reshma Pattan
2019-05-31 12:41 ` Laatz, Kevin
2019-06-18 9:44 ` Thomas Monjalon
2019-06-18 11:46 ` Pattan, Reshma
2019-06-18 15:55 ` Pattan, Reshma
2019-06-18 20:07 ` Thomas Monjalon
2019-06-18 13:49 ` [dpdk-dev] [PATCH v2] " Reshma Pattan
2019-06-19 16:02 ` Ferruh Yigit
2019-06-20 8:59 ` Laatz, Kevin
2019-06-24 14:54 ` Thomas Monjalon
2019-06-24 17:36 ` Chautru, Nicolas [this message]
2019-06-25 8:39 ` Pattan, Reshma
2019-06-25 11:28 ` Pattan, Reshma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1183128033837D43A851F70F33ED5C575C1C08BD@FMSMSX109.amr.corp.intel.com \
--to=nicolas.chautru@intel.com \
--cc=dev@dpdk.org \
--cc=kevin.laatz@intel.com \
--cc=reshma.pattan@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).