From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id F0D3BA046B
	for <public@inbox.dpdk.org>; Mon, 24 Jun 2019 19:36:35 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 5CB0D1BC1B;
	Mon, 24 Jun 2019 19:36:35 +0200 (CEST)
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 94F3C1BC1A
 for <dev@dpdk.org>; Mon, 24 Jun 2019 19:36:33 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga007.jf.intel.com ([10.7.209.58])
 by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 24 Jun 2019 10:36:32 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.63,412,1557212400"; d="scan'208";a="152016140"
Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202])
 by orsmga007.jf.intel.com with ESMTP; 24 Jun 2019 10:36:32 -0700
Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by
 fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Mon, 24 Jun 2019 10:36:31 -0700
Received: from FMSMSX109.amr.corp.intel.com ([169.254.15.43]) by
 fmsmsx118.amr.corp.intel.com ([169.254.1.75]) with mapi id 14.03.0439.000;
 Mon, 24 Jun 2019 10:36:31 -0700
From: "Chautru, Nicolas" <nicolas.chautru@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, "Pattan, Reshma"
 <reshma.pattan@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Laatz, Kevin" <kevin.laatz@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v2] lib/telemetry: add support to fetch
 global metrics
Thread-Index: AQHVKpzHYl0WiWKrDE6pgnhtYd84rqarEFOA
Date: Mon, 24 Jun 2019 17:36:30 +0000
Message-ID: <1183128033837D43A851F70F33ED5C575C1C08BD@FMSMSX109.amr.corp.intel.com>
References: <20190517160757.28098-1-reshma.pattan@intel.com>
 <20190618134917.25526-1-reshma.pattan@intel.com> <2244847.ebtGzxeqCD@xps>
In-Reply-To: <2244847.ebtGzxeqCD@xps>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmJhMzE5YzEtNGJkYi00ZjBmLTlmYzYtNDAwOGM4MWQ1OTZkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibkYxREdNVkprV1wvSzE3TlpXb0prdTJVUlcxNDd4dXZIbThwcTMzOE9Oc1NxSEZkQ3R5bTgrbjB1WGU3YWR1OEwifQ==
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.600.7
dlp-reaction: no-action
x-originating-ip: [10.1.200.107]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2] lib/telemetry: add support to
	fetch	global metrics
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Reshma,=20
I am still seeing build issue when rebasing to this : ie. checking uint32_t=
 is negative in rte_telemetry.c:558
Thanks
Nic

-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
Sent: Monday, June 24, 2019 7:54 AM
To: Pattan, Reshma <reshma.pattan@intel.com>
Cc: dev@dpdk.org; Laatz, Kevin <kevin.laatz@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] lib/telemetry: add support to fetch glob=
al metrics

18/06/2019 15:49, Reshma Pattan:
> telemetry has support for fetching port based stats from metrics=20
> library.
>=20
> Metrics library also has global stats which are not fetched by=20
> telemetry, so extend telemetry to fetch the global metrics.
>=20
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> Acked-by: Kevin Laatz <kevin.laatz@intel.com>
> ---
> v2: fix GCC compilation issues.
> rebase with latest release notes.

Applied, thanks