From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ADC7DA2EEB for ; Mon, 7 Oct 2019 20:29:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C4BCE1C0D5; Mon, 7 Oct 2019 20:29:30 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 160211BE81 for ; Mon, 7 Oct 2019 20:29:28 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Oct 2019 11:29:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,269,1566889200"; d="scan'208";a="222997552" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 07 Oct 2019 11:29:27 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 7 Oct 2019 11:29:27 -0700 Received: from FMSMSX109.amr.corp.intel.com ([169.254.15.226]) by FMSMSX114.amr.corp.intel.com ([169.254.6.218]) with mapi id 14.03.0439.000; Mon, 7 Oct 2019 11:29:26 -0700 From: "Chautru, Nicolas" To: "Richardson, Bruce" , "dev@dpdk.org" CC: Akhil Goyal , Andrzej Ostruszka Thread-Topic: [PATCH 5/5] app/test-bbdev: enable fpga_lte_fec support in shared builds Thread-Index: AQHVetfxwWXNUEjE+UK8DcegmLaGpadPga8g Date: Mon, 7 Oct 2019 18:29:25 +0000 Message-ID: <1183128033837D43A851F70F33ED5C575C2ABB12@FMSMSX109.amr.corp.intel.com> References: <20191004171913.59574-1-bruce.richardson@intel.com> <20191004171913.59574-6-bruce.richardson@intel.com> In-Reply-To: <20191004171913.59574-6-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWNhYjk1NGItYmE2Zi00NTQ3LWE0OWUtYjJiNzdjMGM4ZTNkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQStcL3JCcnROVlV1ZXErWEdOVDZxZTljdk5EeDNoazlzSGZIdkNmamY4UW5WeFN1WTBaZksxeE9iMmdBQzdXODAifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.1.200.108] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 5/5] app/test-bbdev: enable fpga_lte_fec support in shared builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Richardson, Bruce=20 > Sent: Friday, October 4, 2019 10:19 AM > To: dev@dpdk.org; Chautru, Nicolas > Cc: Akhil Goyal ; Andrzej Ostruszka ; Richardson, Bruce > Subject: [PATCH 5/5] app/test-bbdev: enable fpga_lte_fec support in share= d builds >=20 > Now that the necessary function is exported from the fpga_lte_fec driver,= we can enable the code paths using it in shared-library builds. >=20 > Signed-off-by: Bruce Richardson > --- > app/test-bbdev/Makefile | 3 +++ > app/test-bbdev/test_bbdev_perf.c | 2 -- > 2 files changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/app/test-bbdev/Makefile b/app/test-bbdev/Makefile index 6da0= c8e0c..c53982ffc 100644 > --- a/app/test-bbdev/Makefile > +++ b/app/test-bbdev/Makefile > @@ -21,5 +21,8 @@ SRCS-$(CONFIG_RTE_TEST_BBDEV) +=3D test_bbdev_perf.c > SRCS-$(CONFIG_RTE_TEST_BBDEV) +=3D test_bbdev_vector.c > =20 > LDLIBS +=3D -lm > +ifeq ($(CONFIG_RTE_LIBRTE_PMD_BBDEV_FPGA_LTE_FEC),y) > +LDLIBS +=3D -lrte_pmd_bbdev_fpga_lte_fec > +endif > =20 > include $(RTE_SDK)/mk/rte.app.mk > diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev= _perf.c > index fb9045fc5..d8db58ea0 100644 > --- a/app/test-bbdev/test_bbdev_perf.c > +++ b/app/test-bbdev/test_bbdev_perf.c > @@ -519,7 +519,6 @@ add_bbdev_dev(uint8_t dev_id, struct rte_bbdev_info *= info, > /* Configure fpga lte fec with PF & VF values > * if '-i' flag is set and using fpga device > */ > -#ifndef RTE_BUILD_SHARED_LIB > #ifdef RTE_LIBRTE_PMD_BBDEV_FPGA_LTE_FEC > if ((get_init_device() =3D=3D true) && > (!strcmp(info->drv.driver_name, FPGA_PF_DRIVER_NAME))) { @@ -563,7 +56= 2,6 @@ add_bbdev_dev(uint8_t dev_id, struct rte_bbdev_info *info, > "Failed to configure 4G FPGA PF for bbdev %s", > info->dev_name); > } > -#endif > #endif > nb_queues =3D RTE_MIN(rte_lcore_count(), info->drv.max_num_queues); > nb_queues =3D RTE_MIN(nb_queues, (unsigned int) MAX_QUEUES); > -- > 2.21.0 >=20 Thanks Bruce, I did review the serie and it is better and cleaner this way.= =20 This is a non backward compatible change due to the rename of driver librar= y but worth the update notably given more similar drivers being upstreamed = next quarter. Acked-by: Nic Chautru