From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 43003A058E; Thu, 26 Mar 2020 03:50:29 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 287961C036; Thu, 26 Mar 2020 03:50:29 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id A25591C02D for ; Thu, 26 Mar 2020 03:50:27 +0100 (CET) IronPort-SDR: STT0mL89/IP3RLPO4s7xKgopSHwtn+5+6DOXr68p6cMtW9MOT7rchVBEZunWEu6KPgffDIvH6y 06TVsRTDVq3A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2020 19:50:26 -0700 IronPort-SDR: 7EW3wx9LxjXfQ//S+3GnwJ5I/8PzvXHxI1QT1Yz+k1EfeuxdiqN07opaXnw7aD3gy+iJcSFjmm bgD0Yd203ZCA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,306,1580803200"; d="scan'208";a="293507824" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by FMSMGA003.fm.intel.com with ESMTP; 25 Mar 2020 19:50:24 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 25 Mar 2020 19:50:25 -0700 Received: from FMSMSX109.amr.corp.intel.com ([169.254.15.183]) by FMSMSX154.amr.corp.intel.com ([169.254.6.41]) with mapi id 14.03.0439.000; Wed, 25 Mar 2020 19:50:25 -0700 From: "Chautru, Nicolas" To: Akhil Goyal , "thomas@monjalon.net" , "dev@dpdk.org" CC: "Yigit, Ferruh" Thread-Topic: [PATCH v3 04/14] baseband/turbo_sw: support large size code block Thread-Index: AQHV8lZy2kAmj+yY7UKVIxD//nL4tqhZrg+AgACfGZA= Date: Thu, 26 Mar 2020 02:50:25 +0000 Message-ID: <1183128033837D43A851F70F33ED5C576EFD2698@FMSMSX109.amr.corp.intel.com> References: <1582778348-113547-15-git-send-email-nicolas.chautru@intel.com> <1583348102-13253-1-git-send-email-nicolas.chautru@intel.com> <1583348102-13253-5-git-send-email-nicolas.chautru@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.1.200.106] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 04/14] baseband/turbo_sw: support large size code block X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Akhil Goyal =20 >> + if (seg->length > 64000) { >Shouldn't this be seg->length + RTE_PKTMBUF_HEADROOM and you don't need A = check again in assert. >64000 should be a MACRO Adding macro for this at rte_bbdev level in new version uploaded today. >> + data =3D rte_malloc(NULL, 128 * 1024, 0); >Again hard coding. Define some macros to know the basis of this value. > >> + Updated the ``turbo_sw`` bbdev driver with changes including: >> + >> + * Support for large size code block not fitting in one mbuf segment. >> + * Exposes the accurate LLR decimal assumption. > >Is it really worth to highlight this in release note? You even suggested n= ot to Backport it to stable. I am not sure if it is really that important t= o be highlighted In release notes. >If at all, this patch is not changing the LLR decimal. This should be move= d to Appropriate patch. Removed. Thanks