From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CBDB3A058E; Thu, 26 Mar 2020 03:56:22 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A74AB1C037; Thu, 26 Mar 2020 03:56:21 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 003A31C036 for ; Thu, 26 Mar 2020 03:56:19 +0100 (CET) IronPort-SDR: AYP5bCEtkcmZBUp64WmRDnHzd0S9zB3CmHPnWGoIKERI7rdq4UePUYwQBUuxTCTE3FhLVlEsrX h5RfKuqVRwWA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2020 19:56:19 -0700 IronPort-SDR: suB6tZp+csC8eGcoqiD+Emw8kAdNDJGZ9QyjDu/U49vnuudJ8zE7zL+PNj6/TbfAnUSshVrCrv jSmzeURUOpOA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,306,1580803200"; d="scan'208";a="393828510" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 25 Mar 2020 19:56:19 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 25 Mar 2020 19:56:19 -0700 Received: from FMSMSX109.amr.corp.intel.com ([169.254.15.183]) by FMSMSX151.amr.corp.intel.com ([169.254.7.223]) with mapi id 14.03.0439.000; Wed, 25 Mar 2020 19:56:18 -0700 From: "Chautru, Nicolas" To: Akhil Goyal , "thomas@monjalon.net" , "dev@dpdk.org" CC: "Yigit, Ferruh" Thread-Topic: [PATCH v3 07/14] test-bbdev: support for performance tests Thread-Index: AQHV8lZzE0kEClRHDEK0ofWUkBn1YahZ6HCAgABmeHA= Date: Thu, 26 Mar 2020 02:56:18 +0000 Message-ID: <1183128033837D43A851F70F33ED5C576EFD26F6@FMSMSX109.amr.corp.intel.com> References: <1582778348-113547-15-git-send-email-nicolas.chautru@intel.com> <1583348102-13253-1-git-send-email-nicolas.chautru@intel.com> <1583348102-13253-8-git-send-email-nicolas.chautru@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.1.200.106] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 07/14] test-bbdev: support for performance tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Akhil Goyal =20 >>=20 >> From: Nic Chautru >>=20 >> Includes support for BLER wireless performance test with new arguments=20 >> for SNR and number of iterations for 5G. >>=20 >It would be better to add more info in the commit log. >You can add reference to some standard link which is being Followed so tha= t patch can be reviewed. >There should be some documentation about the test cases in this Patch. I have added a bit more details in code and documentation but these are not= really standard specific. Purely adding gaussian and deriving LLR for the sake of quantifying decodin= g performance and comparing across different PMD implementations. > >> + >> +static inline double >> +maxstar(double A, double B) >> +{ >> + if (fabs(A - B) > 5) >> + return fmax(A, B); >> + else >> + return fmax(A, B) + log1p(exp(-fabs(A - B))); } >> + >I think you can use RTE_MAX here. > I doesn't hurt. Thanks Nic