From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3AC62A058E; Thu, 26 Mar 2020 04:16:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1BEFE1C02C; Thu, 26 Mar 2020 04:16:24 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id F11DA1C028 for ; Thu, 26 Mar 2020 04:16:22 +0100 (CET) IronPort-SDR: xbn4NN90HD6H4cNAviFvuyzYh/tVUvJnIPNzd8FIuwhkHXtdUR5spUbgsqP/LBZWtiDbvqJLoJ Y6IUpwSxAcZg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2020 20:16:21 -0700 IronPort-SDR: mwIjbR0yHJLVaFCtnNpoYNXPUFfiFAlK7NMT7c+HfKDmhFn2Btq8xttuewJjda1jzy95DN6YA5 tQrHcjXcYLDg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,306,1580803200"; d="scan'208";a="240556944" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga008.fm.intel.com with ESMTP; 25 Mar 2020 20:16:21 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 25 Mar 2020 20:16:21 -0700 Received: from FMSMSX109.amr.corp.intel.com ([169.254.15.183]) by FMSMSX155.amr.corp.intel.com ([169.254.5.71]) with mapi id 14.03.0439.000; Wed, 25 Mar 2020 20:16:21 -0700 From: "Chautru, Nicolas" To: Akhil Goyal , "thomas@monjalon.net" , "dev@dpdk.org" CC: "Yigit, Ferruh" Thread-Topic: [PATCH v3 12/14] drivers/baseband: add PMD for FPGA 5GNR FEC Thread-Index: AQHV8lZ1LRB6WY6pbUOkEwpazCFlfahZ/JyAgABUp0A= Date: Thu, 26 Mar 2020 03:16:20 +0000 Message-ID: <1183128033837D43A851F70F33ED5C576EFD27B4@FMSMSX109.amr.corp.intel.com> References: <1582778348-113547-15-git-send-email-nicolas.chautru@intel.com> <1583348102-13253-1-git-send-email-nicolas.chautru@intel.com> <1583348102-13253-13-git-send-email-nicolas.chautru@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.1.200.106] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 12/14] drivers/baseband: add PMD for FPGA 5GNR FEC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Akhil Goyal =20 >>=20 >> From: Nic Chautru >>=20 >> Supports for FEC 5G PMD Driver on FPGA card PAC N3000 >>=20 >> Signed-off-by: Nic Chautru >> --- > >I cannot review this patch. This patch should be a separate series. >This should be split into logical parts as a new PMD is submitted for revi= ew. > I will push this PMD in a new serie and keep existing serie for the rest. Note that this new PMD has quite a lot of similarity with the fpga_lte_fec = PMD, no quite created incrementally from scratch. Still I can create an after-the-fact split : one patchset with empty PMD fo= r build purpose then a couple of patchsets for the ldpc processing operatio= ns and configuration. Would that be helpful and sufficient? > I can see that all the MACROS, enums, structures are defined in the .c fi= le which Is not correct. Please move the relevant code in .h files and spli= t the whole patch Along with documentation. This is following the exact same structure as the existing fpga_lte_fec PMD= . Still makes sense to change it as suggested. Thanks Nic