From: "Chautru, Nicolas" <nicolas.chautru@intel.com>
To: Akhil Goyal <akhil.goyal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 05/13] baseband/fpga_5gnr_fec: add device info_get function
Date: Thu, 16 Apr 2020 21:20:25 +0000 [thread overview]
Message-ID: <1183128033837D43A851F70F33ED5C57893CA269@ORSMSX155.amr.corp.intel.com> (raw)
In-Reply-To: <VI1PR04MB31685D8755CCC05B7C583DCBE6D80@VI1PR04MB3168.eurprd04.prod.outlook.com>
Hi Akhil,
> > Add in the "info_get" function to the driver, to allow us to query the
> > device.
> > No capability are available yet.
> > Linking bbdev-test to support the PMD with null capability.
> >
> > Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> > ---
> > app/test-bbdev/Makefile | 3 ++
> > app/test-bbdev/meson.build | 3 ++
> > drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 62
> > ++++++++++++++++++++++
> > 3 files changed, 68 insertions(+)
> >
> > diff --git a/app/test-bbdev/Makefile b/app/test-bbdev/Makefile index
> > c53982f..e951302 100644
> > --- a/app/test-bbdev/Makefile
> > +++ b/app/test-bbdev/Makefile
> > @@ -24,5 +24,8 @@ LDLIBS += -lm
> > ifeq ($(CONFIG_RTE_LIBRTE_PMD_BBDEV_FPGA_LTE_FEC),y)
> > LDLIBS += -lrte_pmd_bbdev_fpga_lte_fec endif
> > +ifeq ($(CONFIG_RTE_LIBRTE_PMD_BBDEV_FPGA_5GNR_FEC),y)
> > +LDLIBS += -lrte_pmd_bbdev_fpga_5gnr_fec endif
> >
> > include $(RTE_SDK)/mk/rte.app.mk
> > diff --git a/app/test-bbdev/meson.build b/app/test-bbdev/meson.build
> > index 4f53a2e..e57e019 100644
> > --- a/app/test-bbdev/meson.build
> > +++ b/app/test-bbdev/meson.build
> > @@ -10,3 +10,6 @@ deps += ['bbdev', 'bus_vdev'] if
> > dpdk_conf.has('RTE_LIBRTE_PMD_BBDEV_FPGA_LTE_FEC')
> > deps += ['pmd_bbdev_fpga_lte_fec']
> > endif
> > +if dpdk_conf.has('RTE_LIBRTE_PMD_BBDEV_FPGA_5GNR_FEC')
> > + deps += ['pmd_bbdev_fpga_5gnr_fec']
> > +endif
> > \ No newline at end of file
>
> Changes in test-bbdev should not be in this patch.
This was done so that to be able to run unit-test from that point on since we can run info_get and pick up supported hw. Similar logic was used with raw driver which I used for inspiration (http://patches.dpdk.org/patch/55878/).
I can split into 2 commits still. Thanks
next prev parent reply other threads:[~2020-04-16 21:20 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 0:02 [dpdk-dev] [PATCH v2 00/13] drivers/baseband: add PMD for FPGA 5GNR FEC Nicolas Chautru
2020-03-30 0:02 ` [dpdk-dev] [PATCH v2 01/13] bbdev: add capability flag for filler bits inclusion in HARQ Nicolas Chautru
2020-03-30 0:02 ` [dpdk-dev] [PATCH v2 02/13] bbdev: expose device HARQ buffer size at device level Nicolas Chautru
2020-03-30 0:02 ` [dpdk-dev] [PATCH v2 03/13] drivers/baseband: add PMD for FPGA 5GNR FEC Nicolas Chautru
2020-03-30 0:02 ` [dpdk-dev] [PATCH v2 04/13] baseband/fpga_5gnr_fec: add register definition file Nicolas Chautru
2020-03-30 0:02 ` [dpdk-dev] [PATCH v2 05/13] baseband/fpga_5gnr_fec: add device info_get function Nicolas Chautru
2020-04-16 18:15 ` Akhil Goyal
2020-04-16 21:20 ` Chautru, Nicolas [this message]
2020-03-30 0:02 ` [dpdk-dev] [PATCH v2 06/13] baseband/fpga_5gnr_fec: add queue configuration Nicolas Chautru
2020-04-11 3:13 ` Xu, Rosen
2020-04-14 0:16 ` Chautru, Nicolas
2020-04-15 6:13 ` Xu, Rosen
2020-04-15 15:51 ` Chautru, Nicolas
2020-04-16 1:09 ` Xu, Rosen
2020-03-30 0:02 ` [dpdk-dev] [PATCH v2 07/13] baseband/fpga_5gnr_fec: add LDPC processing functions Nicolas Chautru
2020-03-30 0:02 ` [dpdk-dev] [PATCH v2 08/13] baseband/fpga_5gnr_fec: add HW error capture Nicolas Chautru
2020-03-30 0:02 ` [dpdk-dev] [PATCH v2 09/13] baseband/fpga_5gnr_fec: add debug functionality Nicolas Chautru
2020-03-30 0:02 ` [dpdk-dev] [PATCH v2 10/13] baseband/fpga_5gnr_fec: add configure function Nicolas Chautru
2020-04-15 15:40 ` Power, Niall
2020-04-16 19:30 ` Akhil Goyal
2020-04-16 21:45 ` Chautru, Nicolas
2020-05-01 23:15 ` Chautru, Nicolas
2020-05-04 17:19 ` Thomas Monjalon
2020-06-25 0:30 ` Chautru, Nicolas
2020-06-25 8:13 ` Thomas Monjalon
2020-06-26 1:14 ` Chautru, Nicolas
2020-06-26 10:08 ` Thomas Monjalon
2020-07-10 22:48 ` Chautru, Nicolas
2020-03-30 0:02 ` [dpdk-dev] [PATCH v2 11/13] baseband/fpga_5gnr_fec: add harq loopback capability Nicolas Chautru
2020-03-30 0:02 ` [dpdk-dev] [PATCH v2 12/13] baseband/fpga_5gnr_fec: add interrupt support Nicolas Chautru
2020-04-16 18:43 ` Akhil Goyal
2020-03-30 0:03 ` [dpdk-dev] [PATCH v2 13/13] doc: add feature matrix table for bbdev devices Nicolas Chautru
2020-04-15 15:40 ` [dpdk-dev] [PATCH v2 00/13] drivers/baseband: add PMD for FPGA 5GNR FEC Power, Niall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1183128033837D43A851F70F33ED5C57893CA269@ORSMSX155.amr.corp.intel.com \
--to=nicolas.chautru@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).