From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 025C6A0598; Sat, 18 Apr 2020 22:51:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4AC721D534; Sat, 18 Apr 2020 22:51:37 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id CD82C1D166 for ; Sat, 18 Apr 2020 22:51:34 +0200 (CEST) IronPort-SDR: OJvKYYMZIHqzCsg0fIaFek/Tpz/IMw0/C5tc5EzqBKSlarxfrIgBu7qWpJQl9fAu489iNmczAz kzpyGYuWcbGg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Apr 2020 13:51:33 -0700 IronPort-SDR: kGXWT9y9nGYXaiTro1UFTmLZcp83jQxdlDHpnAmhx/SvmtYlIS+YAy1jdezgsAaTG3ps3SBEFP lM7nNl+PKQpQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,400,1580803200"; d="scan'208";a="257934253" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga006.jf.intel.com with ESMTP; 18 Apr 2020 13:51:33 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 18 Apr 2020 13:51:32 -0700 Received: from FMSMSX109.amr.corp.intel.com ([169.254.15.84]) by FMSMSX110.amr.corp.intel.com ([169.254.14.169]) with mapi id 14.03.0439.000; Sat, 18 Apr 2020 13:51:32 -0700 From: "Chautru, Nicolas" To: Akhil Goyal , "dev@dpdk.org" CC: "Richardson, Bruce" Thread-Topic: [PATCH v4 00/11] drivers/baseband: PMD for FPGA 5GNR FEC Thread-Index: AQHWFS41S3DguwBE60+Sh2P/zAh1lKh+65GAgABKqkA= Date: Sat, 18 Apr 2020 20:51:31 +0000 Message-ID: <1183128033837D43A851F70F33ED5C57893DC790@FMSMSX109.amr.corp.intel.com> References: <1587179056-133714-1-git-send-email-nicolas.chautru@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.1.200.107] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 00/11] drivers/baseband: PMD for FPGA 5GNR FEC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil,=20 > I am seeing some compilation issues again on individual patches. Please b= e > careful. This is causing a lot of duplicate effort. Yes I missed that one unfortunately, something seems to be wrong in our CI = for patch by patch build. I am checking manually for each commit this time.= =20 > 1. Rebase your release note just below the other baseband PMD change. ok > 2. remove DALLOW_EXPERIMENTAL_API from Makefile=20 > 3. remove > allow_experimental_apis =3D true from meson.build=20 OK I see the related change. I am missing something about it but still will= change for the sake of the rebase.=20 > 4. header installation in > meson.build is not correct -headers =3D files( > - 'rte_pmd_fpga_5gnr_fec.h', > -) > +install_headers('rte_pmd_fpga_5gnr_fec.h') ok > Please do the above changes and make sure you check meson build/clang/gcc > shared/static builds on all patches separately. I don't want to spend mor= e time > on this. Got it.=20 >=20 > Regards, > Akhil > > > > v4: Fix incremental patch build and expose PMD header file to meson. > > v3: Incremental changes from reviews : file name change, moving few > > inline function to .h, adding missing inline, doxygen markup fix. > > > > Adding new baseband PMD for FPGA 5GNR FEC implementation. > > > > > > Nicolas Chautru (11): > > drivers/baseband: add PMD for FPGA 5GNR FEC > > baseband/fpga_5gnr_fec: add register definition file > > baseband/fpga_5gnr_fec: add info_get function > > baseband/fpga_5gnr_fec: add queue configuration > > baseband/fpga_5gnr_fec: add LDPC processing functions > > baseband/fpga_5gnr_fec: add HW error capture > > baseband/fpga_5gnr_fec: add debug functionality > > baseband/fpga_5gnr_fec: add configure function > > baseband/fpga_5gnr_fec: add harq loopback capability > > baseband/fpga_5gnr_fec: add interrupt support > > doc: add feature matrix table for bbdev devices > > > > .gitignore | 1 + > > app/test-bbdev/Makefile | 3 + > > app/test-bbdev/meson.build | 3 + > > app/test-bbdev/test_bbdev_perf.c | 57 + > > config/common_base | 5 + > > doc/guides/bbdevs/features/default.ini | 16 + > > doc/guides/bbdevs/features/fpga_5gnr_fec.ini | 11 + > > doc/guides/bbdevs/features/fpga_lte_fec.ini | 10 + > > doc/guides/bbdevs/features/mbc.ini | 14 + > > doc/guides/bbdevs/features/null.ini | 7 + > > doc/guides/bbdevs/features/turbo_sw.ini | 11 + > > doc/guides/bbdevs/fpga_5gnr_fec.rst | 297 +++ > > doc/guides/bbdevs/index.rst | 2 + > > doc/guides/bbdevs/overview.rst | 15 + > > doc/guides/conf.py | 5 + > > doc/guides/rel_notes/release_20_05.rst | 5 + > > drivers/baseband/Makefile | 2 + > > drivers/baseband/fpga_5gnr_fec/Makefile | 29 + > > drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h | 388 ++++ > > drivers/baseband/fpga_5gnr_fec/meson.build | 10 + > > drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 2186 > > ++++++++++++++++++++ > > .../rte_pmd_bbdev_fpga_5gnr_fec_version.map | 10 + > > .../baseband/fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h | 74 + > > drivers/baseband/meson.build | 2 +- > > mk/rte.app.mk | 1 + > > 25 files changed, 3163 insertions(+), 1 deletion(-) create mode > > 100644 doc/guides/bbdevs/features/default.ini > > create mode 100644 doc/guides/bbdevs/features/fpga_5gnr_fec.ini > > create mode 100644 doc/guides/bbdevs/features/fpga_lte_fec.ini > > create mode 100644 doc/guides/bbdevs/features/mbc.ini > > create mode 100644 doc/guides/bbdevs/features/null.ini > > create mode 100644 doc/guides/bbdevs/features/turbo_sw.ini > > create mode 100644 doc/guides/bbdevs/fpga_5gnr_fec.rst > > create mode 100644 doc/guides/bbdevs/overview.rst create mode 100644 > > drivers/baseband/fpga_5gnr_fec/Makefile > > create mode 100644 drivers/baseband/fpga_5gnr_fec/fpga_5gnr_fec.h > > create mode 100644 drivers/baseband/fpga_5gnr_fec/meson.build > > create mode 100644 drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c > > create mode 100644 > > > drivers/baseband/fpga_5gnr_fec/rte_pmd_bbdev_fpga_5gnr_fec_version.map > > create mode 100644 > > drivers/baseband/fpga_5gnr_fec/rte_pmd_fpga_5gnr_fec.h > > > > -- > > 1.8.3.1