From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C6AD4A058B; Wed, 25 Mar 2020 15:18:54 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AF95C2C15; Wed, 25 Mar 2020 15:18:53 +0100 (CET) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id BE47B2BCE for ; Wed, 25 Mar 2020 15:18:51 +0100 (CET) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 196045800E1; Wed, 25 Mar 2020 10:18:51 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 25 Mar 2020 10:18:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Bbu0rd+lBFU6tVvkd9E+Rx7PDmUI6GUBH6TiEhFvHDc=; b=prT1EopReWAk XiNyAebHwOnZDxpA5Q5t1akK+zUgt4OOgR4B7n4oTHyd+UzQTzIvaGTRJpijw9sc VkGqjUMMqlOr8HQihxChjhLtmUNSq5xfZloKbAkvJZR2Q1VK2AQpH8claD8OqI8q yT/oTO3UptoRhMghtSz4kF5YjeWi4MM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Bbu0rd+lBFU6tVvkd9E+Rx7PDmUI6GUBH6TiEhFvH Dc=; b=VKP5ewIWc5kSnfnkgyx65PvPGRvWnEYWhq6zv4veHhlX1hRuKkW+cb2vO ksiLIR6CvN7/PQZ5XFjOlM6UY1Qna3om1PHe4GKHzlb5L5Zq0W4sY9UcIZRJKJJv V1tn2POYS8Lqdsl2wYKxwQhiFlnBJfD7Al2zj8rxMoCqvPVaL9f9ANhfEBU2J6rN 9Hbh4W0zVnF9+BY+9wFDwWzWp4AzdKiP9SlgsW7b2g7EbuSyIDqURuk7EDkNhdET QwTIuG4lTWwkB+tcz1t6FHD9cDHZutkMkM8M+xWzFtAQkFMgTMrQ+5lMyzIDHUIr gTU5P6Er3aIZv0ZlZEyEyNU3eTtxg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudehgedgfeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrddvtdefrddukeegnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrg hssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4FA7D3066192; Wed, 25 Mar 2020 10:18:48 -0400 (EDT) From: Thomas Monjalon To: Kevin Traynor Cc: dev@dpdk.org, bruce.richardson@intel.com, ravi1.kumar@amd.com, g.singh@nxp.com, hemant.agrawal@nxp.com, akhil.goyal@nxp.com, johndale@cisco.com, hyonkim@cisco.com, jingjing.wu@intel.com, wenzhuo.lu@intel.com, rmody@marvell.com, shshaikh@marvell.com, matan@mellanox.com, shahafs@mellanox.com, declan.doherty@intel.com, cristian.dumitrescu@intel.com, Kevin Traynor Date: Wed, 25 Mar 2020 15:18:47 +0100 Message-ID: <11831469.VsHLxoZxqI@xps> In-Reply-To: <20200325141137.7088-1-ktraynor@redhat.com> References: <20200325141137.7088-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [RFC 0/2] gcc 10 disable stringop-overflow warning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/03/2020 15:11, Kevin Traynor: > This is a blunt way to remove this warning. > > Some alternatives are: > - disable the warning for individual components > - components rework to statically allocate memory for parts of structs impacted > > Maybe there's some other solutions? In general, I am against disabling warnings, neither globally nor specifically. Is there a way to hide false positives without disabling the warning? > Impacted components: > ../drivers/crypto/caam_jr/caam_jr_pvt.h > ../drivers/crypto/ccp/ccp_crypto.h > ../drivers/crypto/dpaa_sec/dpaa_sec.h > ../drivers/crypto/virtio/virtio_cryptodev.h > ../drivers/net/enic/base/vnic_dev.c > ../drivers/net/iavf/../../common/iavf/virtchnl.h > ../drivers/net/ice/base/ice_adminq_cmd.h > ../drivers/net/mlx4/mlx4_rxtx.c > ../drivers/net/qede/base/ecore_mcp.c > ../lib/librte_cryptodev/rte_cryptodev.h > ../lib/librte_pipeline/rte_table_action.c > > Full details in the Bugzilla: > https://bugs.dpdk.org/show_bug.cgi?id=421 Would be easier to provide explanations here. I think we need at least one false positive example. > Kevin Traynor (2): > meson: gcc 10 disable stringop-overflow warnings > mk: gcc 10 disable stringop-overflow warnings You don't need to split in 2 patches.