From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <shemming@brocade.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] enic: replace use of printf with log
Date: Tue, 24 Feb 2015 03:37:56 +0100 [thread overview]
Message-ID: <11873508.VEDXbTx7T3@xps13> (raw)
In-Reply-To: <CALwxeUti=ykMWDLA0X4jKRv9MTwv9tfbsBefhRRuj=QyYu-=NQ@mail.gmail.com>
> > > Device driver should log via DPDK log, not to printf which is
> > > sends to /dev/null in a daemon application.
> > >
> > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> >
> > Series
> > Acked-by: Neil Horman <nhorman@tuxdriver.com>
>
> Use of rte_log would be better for init messages, but since the driver
> makes no difference, this looks good enough to me.
> Thanks Stephen.
>
> Acked-by: David Marchand <david.marchand@6wind.com>
Applied, thanks
prev parent reply other threads:[~2015-02-24 2:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-14 15:32 Stephen Hemminger
2015-02-14 15:32 ` [dpdk-dev] [PATCH 2/2] enic: change probe log message level Stephen Hemminger
2015-02-14 16:28 ` [dpdk-dev] [PATCH 1/2] enic: replace use of printf with log Neil Horman
2015-02-23 16:43 ` David Marchand
2015-02-24 2:37 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11873508.VEDXbTx7T3@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=shemming@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).