DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Megha Ajmera <megha.ajmera@intel.com>
Cc: dev@dpdk.org, jasvinder.singh@intel.com,
	cristian.dumitrescu@intel.com, stable@dpdk.org
Subject: Re: [PATCH v2] sched: fix for incorrect alignment of bitmap, pipe and queue structs in subport
Date: Sun, 19 Feb 2023 23:40:10 +0100	[thread overview]
Message-ID: <11894451.zAa99ISigo@thomas> (raw)
In-Reply-To: <20230207061008.773757-1-megha.ajmera@intel.com>

07/02/2023 07:10, Megha Ajmera:
> Big structures like bitmap, pipes and queues in subport are addressed
> using offset of 'memory' field in subport structures. This means no other
> variable should be added after 'memory' variable or else addressing of such
> structs like bitmap etc. become incorrect.
> 
> Realigned tc_ov_enabled variable in subport structure.
> 
> Fixes: f5e60154ade ("sched: enable traffic class oversubscription conditionally")
> 
> Signed-off-by: Megha Ajmera <megha.ajmera@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

I bet the impact is wrongly explained, but I don't want to look deeper.
Applied.




  reply	other threads:[~2023-02-19 22:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-09 14:54 [PATCH] sched: fix for tc_ov_enable flag position in subport structure Megha Ajmera
2023-01-10 11:12 ` Dumitrescu, Cristian
2023-01-10 11:27 ` David Marchand
2023-02-06  7:43   ` Thomas Monjalon
2023-02-06  9:32     ` Dumitrescu, Cristian
2023-02-07  9:09       ` Ajmera, Megha
2023-02-07  6:10   ` [PATCH v2] sched: fix for incorrect alignment of bitmap, pipe and queue structs in subport Megha Ajmera
2023-02-19 22:40     ` Thomas Monjalon [this message]
2023-02-19 22:43       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11894451.zAa99ISigo@thomas \
    --to=thomas@monjalon.net \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=jasvinder.singh@intel.com \
    --cc=megha.ajmera@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).