From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E3E5441CE4; Sun, 19 Feb 2023 23:40:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 478BD42D64; Sun, 19 Feb 2023 23:40:14 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id A641940698; Sun, 19 Feb 2023 23:40:12 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 479E55C00D0; Sun, 19 Feb 2023 17:40:12 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 19 Feb 2023 17:40:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1676846412; x= 1676932812; bh=6dLOdc5AiVRMOX0FlxaWyTzskZbL/UAKiy2mUiQy3Kw=; b=h d5QT01IWhfNoVb42ltlQ3W31kf7Dl9quWTJ0NWYvprfvmI6tKgbphQEk4j9+jKMk PSl+s111JrG9o+a9enleRVLNOtw57zRIDKrr8toP7qJJotDdyrno1OVymoGvApVs igUe9Otgbs67G4WIkViUVxhSHyhyDb2FJzmXQ8mv7Y2z6wjNWEhh4x5Gt9zwE4me GOGo9ay4KX0WaiV41EiUGfZrHs0HjRbP9Cstm01Wq5h1hVwcuBA9ZdnN/XfZSGlW pyyvTBtHePasXXp94jqGOH5D2yAbKYsb4X2ZzITo2EhMv0oKQNHHccmByQPpM1sR 08M5Mzel5w5OF3qYM1nzQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1676846412; x= 1676932812; bh=6dLOdc5AiVRMOX0FlxaWyTzskZbL/UAKiy2mUiQy3Kw=; b=R wNTNSaMmZZizYB6Yk5+Wm7u/4DeEPenHuRvU3p+Utp9XxzgA/8S/rPTVPs+1xfMr ktnV/OLA9SQtT/tBsHHflWhzG9cZqk3IHtV8x4K5XO5OwiSYM+d/6rR8o0pZjS2P qis375NWM3l/WlufdM5v6c7Vq3krdhXTsaGt3ln4FISPXwpaOo0VhMjlWxAk3qgd yTooprdIBr0X/tYTr3vGCyx5umUMcdhIHa5C1PN3UP1sbStYZn/u1RhQYMWl1AR0 gweOpI2KMwRcfeVtqg03OFHDfdq+otSO0mn9801Uf8FfRsVQQbguCYGz/tDnHuCw w7eS9/zFBypizcVJjm3Eg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudejfedgudeiiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 19 Feb 2023 17:40:11 -0500 (EST) From: Thomas Monjalon To: Megha Ajmera Cc: dev@dpdk.org, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, stable@dpdk.org Subject: Re: [PATCH v2] sched: fix for incorrect alignment of bitmap, pipe and queue structs in subport Date: Sun, 19 Feb 2023 23:40:10 +0100 Message-ID: <11894451.zAa99ISigo@thomas> In-Reply-To: <20230207061008.773757-1-megha.ajmera@intel.com> References: <20230207061008.773757-1-megha.ajmera@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 07/02/2023 07:10, Megha Ajmera: > Big structures like bitmap, pipes and queues in subport are addressed > using offset of 'memory' field in subport structures. This means no other > variable should be added after 'memory' variable or else addressing of such > structs like bitmap etc. become incorrect. > > Realigned tc_ov_enabled variable in subport structure. > > Fixes: f5e60154ade ("sched: enable traffic class oversubscription conditionally") > > Signed-off-by: Megha Ajmera > Acked-by: Cristian Dumitrescu I bet the impact is wrongly explained, but I don't want to look deeper. Applied.