[dpdk-dev] [PATCH] eal/pci: reduce log verbosity

[dpdk-dev] [PATCH] eal/pci: reduce log verbosity

[Ferruh Yigit]

When debug level logging enabled (--log-level=8) each driver failed to
probe the device printed, like:

EAL: Driver (net_ark) doesn't match the device
EAL: Driver (net_avp) doesn't match the device
EAL: Driver (net_bnxt) doesn't match the device
EAL: Driver (net_cxgbe) doesn't match the device
EAL: Driver (net_e1000_igb) doesn't match the device
EAL: Driver (net_e1000_igb_vf) doesn't match the device
EAL: Driver (net_e1000_em) doesn't match the device
EAL: Driver (net_ena) doesn't match the device
EAL: Driver (net_enic) doesn't match the device
EAL: Driver (net_fm10k) doesn't match the device
EAL: Driver (net_i40e) doesn't match the device
EAL: Driver (net_i40e_vf) doesn't match the device
....

Overall hundreds of similar lines printed, because all drivers printed
for all devices. This is too much noise and there is already a log
message printed when device matched.

Removing the debug log completely.

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 lib/librte_eal/common/eal_common_pci.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c
index 78b097e61..479c62d67 100644
--- a/lib/librte_eal/common/eal_common_pci.c
+++ b/lib/librte_eal/common/eal_common_pci.c
@@ -183,12 +183,9 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,
 	loc = &dev->addr;
 
 	/* The device is not blacklisted; Check if driver supports it */
-	if (!rte_pci_match(dr, dev)) {
+	if (!rte_pci_match(dr, dev))
 		/* Match of device and driver failed */
-		RTE_LOG(DEBUG, EAL, "Driver (%s) doesn't match the device\n",
-			dr->driver.name);
 		return 1;
-	}
 
 	RTE_LOG(INFO, EAL, "PCI device "PCI_PRI_FMT" on NUMA socket %i\n",
 			loc->domain, loc->bus, loc->devid, loc->function,
-- 
2.13.0

Re: [dpdk-dev] [PATCH] eal/pci: reduce log verbosity

[Thomas Monjalon]

27/06/2017 16:23, Ferruh Yigit:
> When debug level logging enabled (--log-level=8) each driver failed to
> probe the device printed, like:
> 
> EAL: Driver (net_ark) doesn't match the device
> EAL: Driver (net_avp) doesn't match the device
> EAL: Driver (net_bnxt) doesn't match the device
> EAL: Driver (net_cxgbe) doesn't match the device
> EAL: Driver (net_e1000_igb) doesn't match the device
> EAL: Driver (net_e1000_igb_vf) doesn't match the device
> EAL: Driver (net_e1000_em) doesn't match the device
> EAL: Driver (net_ena) doesn't match the device
> EAL: Driver (net_enic) doesn't match the device
> EAL: Driver (net_fm10k) doesn't match the device
> EAL: Driver (net_i40e) doesn't match the device
> EAL: Driver (net_i40e_vf) doesn't match the device
> ....
> 
> Overall hundreds of similar lines printed, because all drivers printed
> for all devices. This is too much noise and there is already a log
> message printed when device matched.
> 
> Removing the debug log completely.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks