From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE9DFA04A3; Mon, 7 Feb 2022 14:02:13 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 623D8410F3; Mon, 7 Feb 2022 14:02:13 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 706B4410EA for ; Mon, 7 Feb 2022 14:02:12 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id EA3DC32009F3; Mon, 7 Feb 2022 08:02:08 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 07 Feb 2022 08:02:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=zDrPjtwsWI/K3N Ei/sBtoJNWYz5kHcxrOix7mzmG+q0=; b=jGquf/verhHyrFbKZKKBR+f3gxqdjQ mP97pVcnQJP0WnlWFjrlYIFFS7gIQYBlPhmsxPPmSJ9/bjgV77fX8zmpT/iOBLVN 1kt6Bvkh0zx69gmtHyLVCKm8iV/dOp8FzDtHHzuKw6yzalUp7TZwIo7vAnsue3wp T1WU9uxVYw04MblEvM7at8GUfIM+xFPYnZ1DV0+Qc9HnX+LqSVK8uv/6b54c9SGt BO3qN5zoEroAJOSkfR/pvQHhpCu6NfGVsWsqkf2cCk1suou3gGz1+90YqBVhwH5g ZyPMizvtUhnA+ECgmZ9hNqBKfg56ATPOLA5r1ObL9NSw/TRdbWHlxWfg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=zDrPjtwsWI/K3NEi/sBtoJNWYz5kHcxrOix7mzmG+ q0=; b=P4IboUX81b7Hjp/JARn5Xy2c240wx4V4NKy6AFLqkll3jAiT8a6pbxo3o uYMJ4tE9YJAYZhZVtVniQEUFFQMH3705CCy6LgWVWj/gTAhlv+EylTGdp8btuNHp e3z6lSBhNvSIqSUtwPf4lNzisV03ttkILHxt9ip6+NH1Dg5CTh9xM0gS3FB/FB7e T5hQ7rPTAJrktBsXlxmJGcYHwKfznX/Wi5uizxhlljEH/CBaOKuImBMBFlazrcLV Y/6gDIpmYenPGo9r6Dc0euKZs27g0l7FJzel8XZ5ACy70/TvfztUG5lIhiT1BSa6 exjFZ4cnvWnMuaEfn0MA0L2mqsxWA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrheehgdeghecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeffvdffjeeuteelfeeileduudeugfetjeelveefkeejfeeigeehteff vdekfeegudenucffohhmrghinhepughpughkrdhorhhgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdr nhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 7 Feb 2022 08:02:06 -0500 (EST) From: Thomas Monjalon To: Ciara Power , Akhil Goyal Cc: "dev@dpdk.org" , "roy.fan.zhang@intel.com" , Anoob Joseph , "mdr@ashroe.eu" , Declan Doherty Subject: Re: [EXT] [PATCH v3 4/4] crypto: modify return value for asym session create Date: Mon, 07 Feb 2022 14:02:03 +0100 Message-ID: <11916826.O9o76ZdvQC@thomas> In-Reply-To: References: <20220203160449.1638311-1-ciara.power@intel.com> <20220203160449.1638311-5-ciara.power@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 07/02/2022 10:04, Akhil Goyal: > > diff --git a/doc/guides/prog_guide/cryptodev_lib.rst > > b/doc/guides/prog_guide/cryptodev_lib.rst > > index 62bd3577f5..8e16461dc6 100644 > > --- a/doc/guides/prog_guide/cryptodev_lib.rst > > +++ b/doc/guides/prog_guide/cryptodev_lib.rst > > @@ -1236,10 +1236,10 @@ crypto operations is similar except change to > > respective op and xform setup). > > * Create asym crypto session and initialize it for the crypto device. > > * The session structure is hidden from the app, so void * is used. > > */ > > - void *asym_session; > > - asym_session = > > rte_cryptodev_asym_session_create(asym_session_pool, > > + void *asym_session = NULL; > > + ret = rte_cryptodev_asym_session_create(&asym_session, > > asym_session_pool, > > cdev_id, &modex_xform); > > - if (asym_session == NULL) > > + if (ret < 0) > > rte_exit(EXIT_FAILURE, "Session could not be created\n"); > > Sample Code in the rst files is no more added. @Thomas: Could you please confirm? > Probably a separate patch is required to clean this up. Yes the target is to remove them. Instead we want to include parts of examples with a specific syntax. See literalinclude here: https://doc.dpdk.org/guides/contributing/documentation.html#code-and-literal-block-sections