From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1BDA342368; Wed, 11 Oct 2023 19:03:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AF150400EF; Wed, 11 Oct 2023 19:03:01 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2071.outbound.protection.outlook.com [40.107.93.71]) by mails.dpdk.org (Postfix) with ESMTP id C6CB8400D7 for ; Wed, 11 Oct 2023 19:03:00 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WtxMwEImcX+ZQRiV5rluX4MQto93DLPBWERAY7Tnt2UWxxM5bsw332VOIgey+dZRKJYw7ZOqHnMio9ZSOKt57xy0yBQYyRyYH6CDXWabpSAU4i3OnXxsjD7p+BLK+yBq+SJv8TZs+E1i2eWtxweMvPryoZ9sb9CnFNf7rs7by3zUL+vlRqrVgw2rtRLvwykVfQzT9Grv/iaHApZ2EKIXOAe+xlLK46IOu7FwTfJxr0cEmFCjiGqOWhwm6dVwO7dQhDOxt2h+tiNEKER0aDc3tuh96TppVCxlXp8jOApbQhXWvKTl7dQOxvSXyBGq8av0xwkPCxZmu2MDtQliXOKeRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vle2ZXdkb/tXWs9+uq6KGQfE6DuKV/DtHkV3k8MYd0g=; b=mqjgfK5EENfEcgvHoGlJgnorR4tzDaLt/DavudPkBclDB9SSx7Oe0oyhImi6fd2hAT48zrBqK7g1SvsFmUO7EoQQwRLCi36eQF16VZFVaOMBKEqDr/ZCXSsP8xVD9Dxzd8pmkNXuBOix9+OGp8eqwKhM4Cv1XoOV0PTqxwiF+TAZ9LVcOQNXf6HF81CdzvE9xXzwiXwmSdfMBp4MtPnCWlE4KV/5qygns7BOTdlFyBbPMK9iGuUIw+DFloSxpTVZBW9xb+U3ZIWIYnu9R5u1xdZqClz2+M30Fpn1PIF89fN06OfmYR4sRunuklWJmURq0UlHW6hZIT82Boq6uyGmZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vle2ZXdkb/tXWs9+uq6KGQfE6DuKV/DtHkV3k8MYd0g=; b=eZ1BvXmD/plrswVoGX7WFieWVnuRJqxQY7HkqZRRSnC5llaOqbiTXH7QYrSxcYUB+TSsWuUan9yHLAIa1uftvI8YPBtu/Y/zgWunNSKa+qZFiCnAN5B9GmWVblG899TdVoQVR+IIBMycMZtRYnzM6GSPohc7STDF8OcMxxihZlg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.44; Wed, 11 Oct 2023 17:02:57 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6863.032; Wed, 11 Oct 2023 17:02:56 +0000 Message-ID: <11931c5f-dd90-4a10-aa61-a5a60b4478b8@amd.com> Date: Wed, 11 Oct 2023 18:02:51 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 05/40] net/bnx2x: check RSS hash algorithms Content-Language: en-US To: Jie Hai , dev@dpdk.org, Julien Aube Cc: lihuisong@huawei.com, fengchengwen@huawei.com, liudongdong3@huawei.com References: <20230908080030.3837515-1-haijie1@huawei.com> <20231011092805.693171-1-haijie1@huawei.com> <20231011092805.693171-6-haijie1@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <20231011092805.693171-6-haijie1@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0449.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a9::22) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM4PR12MB5229:EE_ X-MS-Office365-Filtering-Correlation-Id: 7fa57a8d-101d-4fd0-bc3a-08dbca7bea4b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C1RayIgLEw1cxC4pN2HW82rWxn/yvT6uQ3j477wRnio18pBSJw2QLyerENEihmE/SGZIuelX7Q7PN8Y7azsE7oM5tOUP5B7CbxU+RrBvUi+71fL1MEtwNBidqnvfT87abZi9UpARS69AmT11tYUiJ6os1vwMNltNq8oorifA4OX3gF3xnhMlDUkm2YBdYD4tmlA6H6kPZ4RwPr+NMPf2TkE7jjCxhPvqcxcM31B5vncjvh9BYfmwShSDx/D0rw9SKDmONlKD0DoZmGzn/278jgVigACEXlxS62xV48k0H6daZrq7/AEd6cn0qRQ0lIxVK9vEQawJLnh6uHG0obs7HUdNlDpCpMoRMWORQvyCbn1gt3o6TnR8ODxJTKubemSdm+GL2hmr7p5EInMdAnsGL8zHy44LcueAr7peaAwga38VEWGXHIyLCP0GLXhYWLiABuTj2BI3mXq6snm9Xbe2+Q7x7enG18JhYyigAjUqEiaxhFOtMLib07gCRues4ICqVfNQbJTaWcKYc8TyQo3T0A+6syvOseh3XYVYeGIgVEaJnDwfmUA+Y1mLMst4TV2jTjt78Ne7eKmsAUobFlO2L31lyP7WDunmuzqn5CreaN+lp54JscfAdYv/724UJYV/iPQsE0t5ybI+oK8VFfC6rg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(396003)(366004)(39860400002)(136003)(346002)(230922051799003)(64100799003)(451199024)(1800799009)(186009)(6512007)(26005)(6506007)(53546011)(2616005)(31686004)(6666004)(6486002)(478600001)(8936002)(8676002)(31696002)(36756003)(38100700002)(5660300002)(4326008)(41300700001)(2906002)(4744005)(86362001)(44832011)(66476007)(66556008)(66946007)(110136005)(316002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?djVFMjBNanI5b3o3OXVud0w5WXM2L0d3T3EyOHZ3aUpmYnRTVWJTMU5ud09M?= =?utf-8?B?SDRlZU1JWWE1Y0NnS0l3MDVZV2RpZ1JjSUkveXJHc3A3MHJ0V3o5M0MvUXl4?= =?utf-8?B?d0lhak8xaGllb1BGV3VHRGFiN2xJczFYOWFBeUhsNVRYeDBWZTJhMmRRd0pq?= =?utf-8?B?SU5rbHBjK3pIOFc3elJxb2VOTG12WXd3VTB0LzFSdnU2bXY2MjNmOTBsOG1U?= =?utf-8?B?VnpiUytSdmhINjFkQXZWS1F0b1FmNFBORHFQMnpEcnY3Y3dUOWc1ZjlxRW84?= =?utf-8?B?cWt5NmltR0ZqUCszb3FVU3JFbVYyQnhEOUFoVnRUNzQvU3NQdVVBaGZYdC9u?= =?utf-8?B?d2FiR3NnZnhGRHBzdzNrWW14NGJPVWp3T2JDSTBncUlmSVdQYnRTdkRCUity?= =?utf-8?B?dGFlSDVZRXNaL0JxSi9TWWEvbXcyUE8yVFdUSUpTeEtBbndGb1VrMmxxTW10?= =?utf-8?B?ZTlLOExBSXdhNGQ4Vk1wQkdZdlYzcUxkVkRFVDUvSzYwYW9VWUhCckFQWm1M?= =?utf-8?B?NHJPYzR6VUxuanVsUVI0QjcydU9FekROQ0JUakUyamJuUkQ0WVdQR3F1ZERR?= =?utf-8?B?S2I2QjN5V25ZRmoyYVJZTHY3cGdKTldFQzR1N2x1aG9mNTdUOG51cC9zdHZn?= =?utf-8?B?c1R2S1RmM3BPZlphQXVBQnRZM0paYmkvbUxMYW5pZkNLa2JVQmlmOFhuU0tu?= =?utf-8?B?MEwya0ZFWlZSUWxBOFhVVXplandrT3dYRXR1WTFSbmRwU2ZxNEVTMlFnSXBB?= =?utf-8?B?eEd5YUFNQTVqOVM0Y0RyaEFPdTdqOFZxM1M4R2ZWZElmd1NhbDFhbUhDQ3Vl?= =?utf-8?B?Ly9rZ0c5NjlrRnVGdzlBY3RzM3NxclpJM2VCUTQzSnc3TVBVbFZwNWp5SVJq?= =?utf-8?B?UU95eW0xWHU3NCtHOW1zWk9PWWZIelliYndJNGtLcHZ3ZnAzeHZXNEMrYmt6?= =?utf-8?B?VkJXa2NIOTJvR0lHK1VPTGk2dFI0NUljTkVBdHo5UGxUTWRYMUZCTDR2dklM?= =?utf-8?B?MXFnd3N1SGtJc3FQS3FYdDV6YkhldE9WU2tXRXl4RTY5VHlwTUI1OUw3OGFV?= =?utf-8?B?clpVaUhCbHFkUnNFMmJWVUZzOFEwd0N0aXppZk9rTEpTQmh2ejBjZ2Z5YkVI?= =?utf-8?B?Mk5rSFpPTUR4MWM2VVdQb0pPRWZreHBDRkRXTmlDTE1USGdCejNHOXpCUUo2?= =?utf-8?B?VWJGMlhrM1hFMnNicWlEWWhjMFhHWWl3UFdlSXltL2JNUXJFTlNub2YrQ2pk?= =?utf-8?B?NnVBNXJhcGdPYjR4ZXR1M084UHhCdE9qRVZMdlBod0RYdC9maW96OUF0QzZm?= =?utf-8?B?YTNwZUM1R1NwVlBIV1hScVJaODFqd1VUSzk1RmpnRlBSdW11R3RFZXVQZSt6?= =?utf-8?B?ZUdBWGZuK2E5VFZLd295N283SVdYQ2ZKVjY1WjFtSUNNbjRucFNCcTU3S0Vq?= =?utf-8?B?WnZtOWh4amxQQ0drZ1BEY0dQMC9PVlhRN0poK3R3eVAzeWVBRUxQWlZNTjI1?= =?utf-8?B?em0yZkhlc1NnaWNxb2YrZ1FCaGxQQjc3RHFuVnNnVmJaUFQxZ1pzY0JHNGxY?= =?utf-8?B?RGlxL0NCNU9GY2hxVlZ0SDdsTUJWZGU2MjZmeHkvWWExSXJSYk82T2x1VzZ4?= =?utf-8?B?bm1obWRadUpZZHJ2Sk9sOEdPOVRqZUJXTWk0ZzBDVkJLWWg5NTd2dVlBTmIy?= =?utf-8?B?SlJtcW9jV1h5OStLYXdTTiswQXJ0VzdxSHJFWnVid1lZY3BTL2d3Wjc3TnFH?= =?utf-8?B?cmRETDA5djBDQ1QyY25qQzMrNU9qQ0R6M1kxVi9kSTJXYllMbVpVSDlqUG53?= =?utf-8?B?ZXREd1R4d3dHYStET3pjbUdOS0ZWM0VsZkxtZnZmcWFKVytkaUVDdEdxelc3?= =?utf-8?B?N3FRYjlXQjVNSjFLWVh6ZlEvSStkWUwxM2xHYmhUQU9vcTUzQVUrZFFpZnVX?= =?utf-8?B?bSs2WlBycVJZUnhyVW1YTWxCUWw1ak9wTWhUd0VmYW51YUMrM2dVRmRhaStM?= =?utf-8?B?TkJkb3Jmd3BZSkFlMW0xREZCOVpBN0I2d09WcjRyYXZlWHljNnltU1l0ZHU2?= =?utf-8?B?Ujk5L0RPcjJDdXB4aS9VbjNqNFpYYmZydXhxVERCcTV1UTJWUGFYZTZIM2Fw?= =?utf-8?Q?/bnYD9n8c0xcKhwVkfLMAGrUC?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7fa57a8d-101d-4fd0-bc3a-08dbca7bea4b X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2023 17:02:56.5998 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fSliL1RQVW8dRJwBsOVq1kFKTRe764aBxol1PvhSi9uwblrvv90Eb9jZ97TTewpy X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5229 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/11/2023 10:27 AM, Jie Hai wrote: > A new field 'algorithm' has been added to rss_conf, check it > in case of ignoring unsupported values. > > Signed-off-by: Jie Hai > --- > drivers/net/bnx2x/bnx2x_ethdev.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c > index 4448cf2de2d7..078d6db75d1b 100644 > --- a/drivers/net/bnx2x/bnx2x_ethdev.c > +++ b/drivers/net/bnx2x/bnx2x_ethdev.c > @@ -196,6 +196,10 @@ bnx2x_dev_configure(struct rte_eth_dev *dev) > PMD_DRV_LOG(DEBUG, sc, "num_queues=%d, mtu=%d", > sc->num_queues, sc->mtu); > > + if (dev->data->dev_conf.rx_adv_conf.rss_conf.algorithm != > + RTE_ETH_HASH_FUNCTION_DEFAULT) > + return -EINVAL; > + > /* allocate ilt */ > if (bnx2x_alloc_ilt_mem(sc) != 0) { > PMD_DRV_LOG(ERR, sc, "bnx2x_alloc_ilt_mem was failed"); bnx2x doesn't claim RSS support (doc/guides/nics/features/bnx2x.ini), so I think it will be reasonable to drop this patch.