From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f174.google.com (mail-wr0-f174.google.com [209.85.128.174]) by dpdk.org (Postfix) with ESMTP id 3671A2E8A for ; Wed, 12 Apr 2017 17:15:58 +0200 (CEST) Received: by mail-wr0-f174.google.com with SMTP id l28so19636949wre.0 for ; Wed, 12 Apr 2017 08:15:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=hc6PCZLrylYGWDrIqOV+lE0soiu3MOWLkRn5+7yapFU=; b=k61G35tLtnuNe43SP/R9gUe7HD0Wd5APW89uBi5hOECIky2cDHqaSRANkZElZbhqSG jybuXKuRy6NmMwPyZRuGvsZdyjCgvmYIRF2vdD56Gi/qdHtlCuZSFDZL+E/7AywCl33d R8/k0ya11NpnHYUfrJoV/t7f9igzhhxo8YOtSIM3oPoD8fAUSXMId5W6f6idWd4e+v+c d/Ee+R2lJo2orwdxzBAJJ4V++DjsWoQML8CPztdZvWOjPkL705F3jlainN6T6InvtjzQ w8VW7RHwyrMHhZGBoc0ETT8nPZ3M33Gz/sRH/h4V0/m9ZXRrSUVwwsyREvNx3ub0D6CN 6Exw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=hc6PCZLrylYGWDrIqOV+lE0soiu3MOWLkRn5+7yapFU=; b=AfSMV2QbAuA9ClS4cpByuAnGa8oY9wEbhg0vfFCFuBvC+FA2SLbAg8Ce/tciENtW7y 5A1Qel0M/F4mdaVpOphCYQAEjbVoJO91uou5IQAZErlG4vghqo43gs7JVTC6nIeRQOC9 VxOJIJ7bYgnQapMZz+Sd+P0/NiOCmBS3vQOzizIDwmxaLDF3V4LZfdW0tuG5LDF/1kgC tDCIzogSD+SiP7agRrOb751XIdRv8CZ6OyHOJNIxAiHtUj2KLO6KokPsT2n7MxpXMEG8 OLK4pPF8V2dTCPyKOQ/+Cz4JiBSRmtgQgq3kzaEYPa2GvPXX4/1BCK9kguj5nxnp5H1b Ks0g== X-Gm-Message-State: AN3rC/75QAvs2wWYoingSSwITSy7frbCQJOLPjxi4uoJX0jeLXhv7fcYtdLN5IW0/Rim5z9A X-Received: by 10.223.181.135 with SMTP id c7mr3887868wre.19.1492010157877; Wed, 12 Apr 2017 08:15:57 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id v7sm25864321wrd.0.2017.04.12.08.15.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Apr 2017 08:15:57 -0700 (PDT) From: Thomas Monjalon To: Pablo de Lara Cc: dev@dpdk.org, olivier.matz@6wind.com Date: Wed, 12 Apr 2017 17:15:56 +0200 Message-ID: <11937147.4rRz3cW7Er@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1492006471-114636-1-git-send-email-pablo.de.lara.guarch@intel.com> References: <1492006471-114636-1-git-send-email-pablo.de.lara.guarch@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: redefine logtype values X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Apr 2017 15:15:58 -0000 2017-04-12 15:14, Pablo de Lara: > After the changes in commit c1b5fa94a46f > ("eal: support dynamic log types"), logtype is not treated as a > bitmask, but a decimal value. Therefore, values have to be > converted. > > Fixes: c1b5fa94a46f ("eal: support dynamic log types") > > Signed-off-by: Pablo de Lara [...] > /* SDK log type, keep sync'd with rte_log_init() */ [...] > +#define RTE_LOGTYPE_EAL 0 /**< Log related to eal. */ > +#define RTE_LOGTYPE_MALLOC 1 /**< Log related to malloc. */ > +#define RTE_LOGTYPE_RING 2 /**< Log related to ring. */ > +#define RTE_LOGTYPE_MEMPOOL 3 /**< Log related to mempool. */ > +#define RTE_LOGTYPE_TIMER 4 /**< Log related to timers. */ > +#define RTE_LOGTYPE_PMD 5 /**< Log related to poll mode driver. */ > +#define RTE_LOGTYPE_HASH 6 /**< Log related to hash table. */ > +#define RTE_LOGTYPE_LPM 7 /**< Log related to LPM. */ > +#define RTE_LOGTYPE_KNI 8 /**< Log related to KNI. */ > +#define RTE_LOGTYPE_ACL 9 /**< Log related to ACL. */ > +#define RTE_LOGTYPE_POWER 10 /**< Log related to power. */ > +#define RTE_LOGTYPE_METER 11 /**< Log related to QoS meter. */ > +#define RTE_LOGTYPE_SCHED 12 /**< Log related to QoS port scheduler. */ > +#define RTE_LOGTYPE_PORT 13 /**< Log related to port. */ > +#define RTE_LOGTYPE_TABLE 14 /**< Log related to table. */ > +#define RTE_LOGTYPE_PIPELINE 15 /**< Log related to pipeline. */ > +#define RTE_LOGTYPE_MBUF 16 /**< Log related to mbuf. */ > +#define RTE_LOGTYPE_CRYPTODEV 17 /**< Log related to cryptodev. */ > +#define RTE_LOGTYPE_EFD 18 /**< Log related to EFD. */ > +#define RTE_LOGTYPE_EVENTDEV 19 /**< Log related to eventdev. */ I think you should use these values in rte_log_init, instead of the hardcoded ones. So the messages about keeping them sync'd could be removed :)