DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] rte_ether: Driver-specific stats getting overwritten
@ 2016-07-14 13:29 Remy Horton
  2016-07-14 13:37 ` Thomas Monjalon
  0 siblings, 1 reply; 4+ messages in thread
From: Remy Horton @ 2016-07-14 13:29 UTC (permalink / raw)
  To: dev; +Cc: thomas.monjalon

'noon,

In rte_eth_stats_get() after doing the driver callout to populate struct 
rte_eth_stats, the rx_nombuf member is overwritten with 
dev->data->rx_mbuf_alloc_failed even though some drivers will have 
filled rx_nombuf with a value from elsewhere. This makes assignment of 
rx_nombuf from within the driver callout redundant. Is this intentional?

..Remy

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] rte_ether: Driver-specific stats getting overwritten
  2016-07-14 13:29 [dpdk-dev] rte_ether: Driver-specific stats getting overwritten Remy Horton
@ 2016-07-14 13:37 ` Thomas Monjalon
  2016-07-14 13:51   ` Igor Ryzhov
  0 siblings, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2016-07-14 13:37 UTC (permalink / raw)
  To: Remy Horton; +Cc: dev

2016-07-14 14:29, Remy Horton:
> 'noon,
> 
> In rte_eth_stats_get() after doing the driver callout to populate struct 
> rte_eth_stats, the rx_nombuf member is overwritten with 
> dev->data->rx_mbuf_alloc_failed even though some drivers will have 
> filled rx_nombuf with a value from elsewhere. This makes assignment of 
> rx_nombuf from within the driver callout redundant. Is this intentional?

Yes it is strange and has always been like that.
Why not moving the assignment before calling the driver callback?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] rte_ether: Driver-specific stats getting overwritten
  2016-07-14 13:37 ` Thomas Monjalon
@ 2016-07-14 13:51   ` Igor Ryzhov
  2016-07-14 15:50     ` Remy Horton
  0 siblings, 1 reply; 4+ messages in thread
From: Igor Ryzhov @ 2016-07-14 13:51 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: Remy Horton, dev

Hello.

How about deleting rx_nombuf from rte_eth_stats?
Do you think this counter is necessary? It just shows enormous numbers in case of a lack of processing speed.
But we already have imissed counter which shows real number of packets, dropped for the same reason.

> 14 июля 2016 г., в 16:37, Thomas Monjalon <thomas.monjalon@6wind.com> написал(а):
> 
> 2016-07-14 14:29, Remy Horton:
>> 'noon,
>> 
>> In rte_eth_stats_get() after doing the driver callout to populate struct 
>> rte_eth_stats, the rx_nombuf member is overwritten with 
>> dev->data->rx_mbuf_alloc_failed even though some drivers will have 
>> filled rx_nombuf with a value from elsewhere. This makes assignment of 
>> rx_nombuf from within the driver callout redundant. Is this intentional?
> 
> Yes it is strange and has always been like that.
> Why not moving the assignment before calling the driver callback?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] rte_ether: Driver-specific stats getting overwritten
  2016-07-14 13:51   ` Igor Ryzhov
@ 2016-07-14 15:50     ` Remy Horton
  0 siblings, 0 replies; 4+ messages in thread
From: Remy Horton @ 2016-07-14 15:50 UTC (permalink / raw)
  To: Igor Ryzhov, Thomas Monjalon; +Cc: dev


On 14/07/2016 14:51, Igor Ryzhov wrote:
[..]
> How about deleting rx_nombuf from rte_eth_stats? Do you think this
> counter is necessary? It just shows enormous numbers in case of a
> lack of processing speed. But we already have imissed counter which
> shows real number of packets, dropped for the same reason.

Deleting it has API/ABI breakage issues. There is also lack of 
consistency between drivers as to what imissed includes, as some don't 
implement it at all whereas others include filtered packets as well.


>> 14 июля 2016 г., в 16:37, Thomas Monjalon
>> <thomas.monjalon@6wind.com> написал(а):
>>
[..]
>> Yes it is strange and has always been like that. Why not moving the
>> assignment before calling the driver callback?

Think I'll do that. Easier than updating all the drivers that don't fill 
it in..

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-07-14 15:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-14 13:29 [dpdk-dev] rte_ether: Driver-specific stats getting overwritten Remy Horton
2016-07-14 13:37 ` Thomas Monjalon
2016-07-14 13:51   ` Igor Ryzhov
2016-07-14 15:50     ` Remy Horton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).