From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <remy.horton@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 4EB8247CD
 for <dev@dpdk.org>; Thu, 14 Jul 2016 15:29:20 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga102.fm.intel.com with ESMTP; 14 Jul 2016 06:29:20 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,362,1464678000"; d="scan'208";a="734192649"
Received: from rhorton-mobl.ger.corp.intel.com (HELO [163.33.230.104])
 ([163.33.230.104])
 by FMSMGA003.fm.intel.com with ESMTP; 14 Jul 2016 06:29:18 -0700
To: dev@dpdk.org
Cc: thomas.monjalon@6wind.com
From: Remy Horton <remy.horton@intel.com>
Organization: Intel Shannon Limited
Message-ID: <1195a38d-8615-03d2-22eb-04f6b071d38b@intel.com>
Date: Thu, 14 Jul 2016 14:29:17 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.1
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [dpdk-dev] rte_ether: Driver-specific stats getting overwritten
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jul 2016 13:29:20 -0000

'noon,

In rte_eth_stats_get() after doing the driver callout to populate struct 
rte_eth_stats, the rx_nombuf member is overwritten with 
dev->data->rx_mbuf_alloc_failed even though some drivers will have 
filled rx_nombuf with a value from elsewhere. This makes assignment of 
rx_nombuf from within the driver callout redundant. Is this intentional?

..Remy