From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B90594579C; Mon, 12 Aug 2024 09:58:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 828654014F; Mon, 12 Aug 2024 09:58:26 +0200 (CEST) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by mails.dpdk.org (Postfix) with ESMTP id 3617C400D7 for ; Mon, 12 Aug 2024 09:58:25 +0200 (CEST) Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-52f04b3cb33so8074167e87.0 for ; Mon, 12 Aug 2024 00:58:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1723449504; x=1724054304; darn=dpdk.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PF9JdMGH+on1cjee1f8TOACIgGSxHmu6Kf42nFdcqBM=; b=U5/URUrdMwE81wzCWvZSZHTDxyqed/eMyF+cxZYAqPW0zwcbYqrDFxMIFcj1hEVam4 yvNrnTGDD3QfMii1ViV+I+B1Y80O8jPdQlgzvTUr9X4SbIe7aAFYnJaJOaMIkXzhb2St lclmqz1gXZMqyuzQq1NsCol+59VHdE/WE0X00FjzJzBOWAxPZu3Y3H24PPrrB25YAmcF MjhIC5+ISm+ctSYGQWz0gs7OtI4Bs+jlf7mhjWmAvAwki/IVFJkM1vaiEMpY60UIjD1l s89EhX3h4vdqNFDQTyNt9boL9cclX7s8HA72hCBcTN8NZRQ0vQjUtNwKyVieWfO6X0Z3 ZY7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723449504; x=1724054304; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PF9JdMGH+on1cjee1f8TOACIgGSxHmu6Kf42nFdcqBM=; b=DAxfAkwLWWov1FGN9AweXCNg8+RQYwhRQxjmavqb2+tgeM6boQWwZjGeVoarcOV0lT zacKnX0aE42p77lUk17Lp/FVRDY5t5I/yl21wgkHs4icwUfxxeUKyI4+pmA5D7ePdlwx QEcojyejokkuCUOXVYU5AczFl4sVdqg51Av72Sx15gwM2M9m4cpezB6PGcIuhfoOZqsd HJ4GLuDweFWEGl7yW+2WFSLOMnvD9q/w7pVrxhQdWzc+S5/59unSE/eHF/J7vvId6+sx rXh/XfXIAQ2Smr3/6Fgd8woKqvZ9MARsMuIxZQJ9nfCF2Y9XX9/xwsCitAcWyQG2rSu2 EJrg== X-Forwarded-Encrypted: i=1; AJvYcCV2N62/XdQio5SaijQLxfywMHXtX4zie0dqDz8PeeWE2CVoQvWRD6AO9qYJwisYdo+L4uqstx11wq5WdA0= X-Gm-Message-State: AOJu0YwAbBZEKbPrIznprz4lbYtOrWerSih2x/AuBbZuVji/LLtkOKj+ PRZz0GRY13U7/+tZZ93FQbBlWlvg4wQtz/qbut11oNJGJNOhtLQiP65JGiQu8Jc= X-Google-Smtp-Source: AGHT+IFNfele3SmnfypCaSdaeuGQdN7o7bOzVRCJoUn9tzLC2eO3A0xxTcTad2AbD/ZbVkH7dMYmYg== X-Received: by 2002:a05:6512:3e03:b0:52f:cd03:a84a with SMTP id 2adb3069b0e04-530ee9ec45emr8180926e87.39.1723449504424; Mon, 12 Aug 2024 00:58:24 -0700 (PDT) Received: from [192.168.200.22] ([84.245.121.236]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a80bb2136f5sm209898766b.179.2024.08.12.00.58.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Aug 2024 00:58:24 -0700 (PDT) Message-ID: <1196c346-f8a2-4021-acce-a08fb022511a@pantheon.tech> Date: Mon, 12 Aug 2024 09:58:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v16 2/5] dts: replace the or operator in third party types To: Jeremy Spewock Cc: thomas@monjalon.net, Honnappa.Nagarahalli@arm.com, bruce.richardson@intel.com, probb@iol.unh.edu, paul.szczepanek@arm.com, Luca.Vizzarro@arm.com, npratte@iol.unh.edu, dev@dpdk.org References: <20231115133606.42081-1-juraj.linkes@pantheon.tech> <20240808085452.426702-1-juraj.linkes@pantheon.tech> <20240808085452.426702-3-juraj.linkes@pantheon.tech> Content-Language: en-US From: =?UTF-8?Q?Juraj_Linke=C5=A1?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9. 8. 2024 21:03, Jeremy Spewock wrote: > This is a funny change I wouldn't have expected the series to need. I > don't doubt that it does need it of course and I don't think there is > any harm in the change, but, out of curiosity, is this because the or > operator is coming from one of the dependencies we are installing? I > thought it was just shipped with later Python versions. Regardless, I think this happens when Paramiko is not installed, as is likely the case in CI. When Paramiko is installed, the issue doesn't crop up. I added the autodoc_mock_imports [0] configuration so that dependencies don't have to be installed. I don't know how exactly autodoc gets around the imports, but that seems to be what's causing the error when Paramiko is missing. [0] https://www.sphinx-doc.org/en/master/usage/extensions/autodoc.html#confval-autodoc_mock_imports > > Reviewed-by: Jeremy Spewock