Re: [dpdk-dev] [PATCH v3 1/8] net/dpaa: add support for fmlib in dpdk

[Thomas Monjalon <thomas@monjalon.net>]

17/07/2020 13:36, Ferruh Yigit:
> On 7/11/2020 9:17 AM, Hemant Agrawal wrote:
> > DPAA platorm MAC interface is known as FMAN i.e. Frame Manager.
> > There are two ways to control it.
> > 1. Statically configure the queues and classification rules before the
> > start of the application using FMC tool.
> > 2. Dynamically configure it within application by making API calls of
> > fmlib.
> > 
> > The fmlib or Frame Manager library provides an API on top of the
> > Frame Manager driver ioctl calls, that provides a user space application
> > with a simple way to configure driver parameters and PCD
> > (parse - classify - distribute) rules.
> > 
> > This patch integrates the base fmlib so that various queue config, RSS
> > and classification related features can be supported on DPAA platform.
> > 
> > This base fmlib is shared across multiple project.
> > - it is not following block comments style for doxygen and other
> > comments.
> > - it usages camel case for naming.
> > - it is not following the 80 char limits in code
> > 
> > Signed-off-by: Sachin Saxena <sachin.saxena@nxp.com>
> > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> Series applied to dpdk-next-net/master, thanks.

Sorry, this time I don't agree with Ferruh's decision of merging this series.

Checkpatch is sending too many warnings.
But most importantly, the licensing has not been agreed in techboard and govboard.

Why dropping this codebase in DPDK instead of pulling it as a dependency?
I don't like seeing DPDK becoming a pile of code duplicated from somewhere else.

I will drop this series from 20.08, waiting for a clear consensus.
Note: I don't remember having heard about such change before,
especially not in the roadmap.