From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C9BD9A0540; Sun, 19 Jul 2020 22:11:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2DA9F23D; Sun, 19 Jul 2020 22:11:01 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id D7D4F1C136; Sun, 19 Jul 2020 22:10:58 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 04EB75C0110; Sun, 19 Jul 2020 16:10:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Sun, 19 Jul 2020 16:10:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 1CwJoovT03a45bqpeBbGVrBCNQ1xW9IPyuMq+ffNyX4=; b=KHC8x2TZwCUrfBJ7 M+ENZh1YC/TvVfYc90sEiX9cMOjg3BJY/aUuM01I5cD3ja21MeaW19wJC6+xr+Gm wcQ+vgjQf6s7l/cGhM12GFaM5jnQcm+gGMIzUmkQRCB5QqyWpAocn1DS/BefrtaE r86/a4/xNITq5Bd86kGsZx5d7x0532Vh9qiI3u0y5q8jIsAaYbgle384Qf3aZCmc NOAiRP8B6GQZYLM63efIFTqborPmlWPojAuAKvlXEpAUvRSUREg7tH+StftbeltG Gyf374Di4L0PVWPS8kjVa5knS1sS3ONhsltD9VkB0tjkdtoxtgODgKRt+oXy/YZU DdcitA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=1CwJoovT03a45bqpeBbGVrBCNQ1xW9IPyuMq+ffNy X4=; b=HMFWpZu/3r4SXp70aLWHu5W8FL6pPtngZ3oNuYo9X0K0RHnikJC4BrwC1 bFug0FXkRor4btVmWypbSSBclsw3eAJeMoOtFZ3xCORVfNg/Fek0sedZhQgCA8BL mKtqLfPsY5aNRviePiBHAmq2YqhIpbfLC3TBmo7w7yT4LKXHDgkc3BVwiOXFVMv3 GGBhLY5XofzWXx89s+0PrDJflingnquN+Zz1h/sr/QSdLH2mHRnPUHzpy45G2Sz2 vMLfQRmZ2nOMZ2+Y6VfpB3a2DRLdaA7JxFuXa/0V56nkWLJFjKTl26ggKpnyYb06 Vvy3ABLBWKHvgbV9VilxkG9UfyJ8A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrgedugddugedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeelfedrvdefrdduiedrjeegnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdr nhgvth X-ME-Proxy: Received: from xps.localnet (74.16.23.93.rev.sfr.net [93.23.16.74]) by mail.messagingengine.com (Postfix) with ESMTPA id 5889A306005F; Sun, 19 Jul 2020 16:10:55 -0400 (EDT) From: Thomas Monjalon To: Hemant Agrawal , Sachin Saxena Cc: dev@dpdk.org, Ferruh Yigit , techboard@dpdk.org Date: Sun, 19 Jul 2020 22:10:52 +0200 Message-ID: <11996214.pnvohz1kia@thomas> In-Reply-To: <69e3b354-ca32-e109-8385-ffc6b973f0cc@intel.com> References: <20200710171946.23246-1-hemant.agrawal@nxp.com> <20200711081716.25173-1-hemant.agrawal@nxp.com> <69e3b354-ca32-e109-8385-ffc6b973f0cc@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 1/8] net/dpaa: add support for fmlib in dpdk X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 17/07/2020 13:36, Ferruh Yigit: > On 7/11/2020 9:17 AM, Hemant Agrawal wrote: > > DPAA platorm MAC interface is known as FMAN i.e. Frame Manager. > > There are two ways to control it. > > 1. Statically configure the queues and classification rules before the > > start of the application using FMC tool. > > 2. Dynamically configure it within application by making API calls of > > fmlib. > > > > The fmlib or Frame Manager library provides an API on top of the > > Frame Manager driver ioctl calls, that provides a user space application > > with a simple way to configure driver parameters and PCD > > (parse - classify - distribute) rules. > > > > This patch integrates the base fmlib so that various queue config, RSS > > and classification related features can be supported on DPAA platform. > > > > This base fmlib is shared across multiple project. > > - it is not following block comments style for doxygen and other > > comments. > > - it usages camel case for naming. > > - it is not following the 80 char limits in code > > > > Signed-off-by: Sachin Saxena > > Signed-off-by: Hemant Agrawal > Series applied to dpdk-next-net/master, thanks. Sorry, this time I don't agree with Ferruh's decision of merging this series. Checkpatch is sending too many warnings. But most importantly, the licensing has not been agreed in techboard and govboard. Why dropping this codebase in DPDK instead of pulling it as a dependency? I don't like seeing DPDK becoming a pile of code duplicated from somewhere else. I will drop this series from 20.08, waiting for a clear consensus. Note: I don't remember having heard about such change before, especially not in the roadmap.