From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9DFE8A0C45; Fri, 3 Dec 2021 13:24:52 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8B5584067B; Fri, 3 Dec 2021 13:24:52 +0100 (CET) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by mails.dpdk.org (Postfix) with ESMTP id 6CE9940041 for ; Fri, 3 Dec 2021 13:24:51 +0100 (CET) Received: by mail-wm1-f47.google.com with SMTP id n33-20020a05600c502100b0032fb900951eso4718018wmr.4 for ; Fri, 03 Dec 2021 04:24:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=bbmjbFn9eXGNuj62yk/SihH5EMOQVao8NzBaW5OQK10=; b=xcZDxPCNEdFYz2HcDCx35oSTJPcskwfdlL2knegtWvBCe+hzqTJ71XwwFWAI19UJUo 6lS0WGoWCrlylk3OKCX3UMHHgqKv1viAcqvFAEn6+TCVwtx2jeGEt4H7eSgM3IeJWxmJ niWTFZce6MyPhHw0i2nCS/y091aZ5op3RVbk2LTsR0GueTP8PGHZMVKIiNLP9VGHFqGl nXpoTgGJ/KqzBxwnNIvNh2byfoch3aAMiadTSEJ5sSKtW0CoTbEx94yXASRenS1853UO v61tjLzwAtH7fd9BdXEC+/h7ul02e7LIRdMcTopNimYGtYNqqyZ8pPgc61fP5Hgyt9nI n55w== X-Gm-Message-State: AOAM531u/P8OK66Aus5FpcSngEXSb6JrRc9eyT3nfJkzMrxguQ+KKHEV 5WViLjqPl5Vl8MJ8pKCkkZ/DEzU4n57kjA== X-Google-Smtp-Source: ABdhPJzTT0Vq/fgPppvrpj077+bNXW+H2HxZrdtFk3IXTB5a8WFoBA9N/0/M9J7v4qM5Z6F7YxPsBA== X-Received: by 2002:a05:600c:1548:: with SMTP id f8mr14542271wmg.67.1638534291190; Fri, 03 Dec 2021 04:24:51 -0800 (PST) Received: from localhost ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id a9sm2547120wrt.66.2021.12.03.04.24.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Dec 2021 04:24:50 -0800 (PST) Message-ID: <119c15e3cc95b3dc9f4da7bb0870362f30ca5639.camel@debian.org> Subject: Re: [PATCH v2 2/2] devtools: report commit id on partial fixes From: Luca Boccassi To: christian.ehrhardt@canonical.com, dev , Thomas Monjalon , Xueming Li , David Marchand , Kevin Traynor , Maxime Coquelin Date: Fri, 03 Dec 2021 12:24:49 +0000 In-Reply-To: <20211203075415.4083502-2-christian.ehrhardt@canonical.com> References: <20211203075415.4083502-1-christian.ehrhardt@canonical.com> <20211203075415.4083502-2-christian.ehrhardt@canonical.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.38.3-1+plugin MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 2021-12-03 at 08:54 +0100, christian.ehrhardt@canonical.com wrote: > From: Christian Ehrhardt >=20 > The candidate list for backports lists partial fixes like: > =C2=A0"(21.02 (partially fixed in 21.08))" > That is useful to identify fixes menat for later releases, but > indirectly applying to older ones as well. >=20 > While the devscript has no access to the stable tree to fully check > if the respective interim commit is present there, reporting the commit > id will still help to check it later - because only if the interim commit > id is in the stable tree, then also the new fix is a real candidate > for backporting. >=20 > The above would become "(21.02 (partially fixed in c30751afc360 @ 21.08))= " >=20 > Signed-off-by: Christian Ehrhardt > --- > =C2=A0devtools/git-log-fixes.sh | 2 +- > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh > index 27ec9088d4..a1b548948a 100755 > --- a/devtools/git-log-fixes.sh > +++ b/devtools/git-log-fixes.sh > @@ -76,7 +76,7 @@ origin_version () # ... > =C2=A0 # look chained fix of fix recursively > =C2=A0 local rootver=3D"$(origin_version $roothashes)" > =C2=A0 [ -n "$rootver" ] || continue > - echo "$rootver (partially fixed in $origver)" > + echo "$rootver (partially fixed in $origin @ $origver)" > =C2=A0 else > =C2=A0 echo "$origver" > =C2=A0 fi Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi