From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31052A00E6 for ; Tue, 9 Jul 2019 12:22:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 049BF1B95A; Tue, 9 Jul 2019 12:22:52 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id EFBB34C8D for ; Tue, 9 Jul 2019 12:22:49 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jul 2019 03:22:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,470,1557212400"; d="scan'208";a="165725231" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.82]) ([10.237.220.82]) by fmsmga008.fm.intel.com with ESMTP; 09 Jul 2019 03:22:47 -0700 To: Thomas Monjalon , David Christensen Cc: dev@dpdk.org, Takeshi Yoshimura , dwilder@us.ibm.com References: <20190607022830.2044-1-tyos@jp.ibm.com> <4027907.MzmCEAoYMI@xps> <66dc5ae0-22f2-86e2-e98a-7629d335c9f4@linux.vnet.ibm.com> <2084101.Qpx90Az0he@xps> From: "Burakov, Anatoly" Message-ID: <11a0b685-9606-9481-9c76-80a10b76cf7b@intel.com> Date: Tue, 9 Jul 2019 11:22:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <2084101.Qpx90Az0he@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] vfio: retry creating sPAPR DMA window X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 08-Jul-19 6:45 PM, Thomas Monjalon wrote: > 08/07/2019 18:47, David Christensen: >>> Please, any review or ack for this patch? >>> >>> 07/06/2019 04:28, Takeshi Yoshimura: >>>> sPAPR allows only page_shift from VFIO_IOMMU_SPAPR_TCE_GET_INFO ioctl. >>>> However, Linux 4.17 or before returns incorrect page_shift for Power9. >>>> I added the code for retrying creation of sPAPR DMA window. >>>> >>>> Signed-off-by: Takeshi Yoshimura >> >> I've shared my comments with Takeshi and I don't think the patch is >> ready in it's current state. It appears to modify x86 functionality and >> I'm not comfortable with signing off on that since it's in an anrea I'm >> not familiar with. > > It is a function specific to sPAPR. > So there is no risk for x86 or Arm. > As you didn't share your comments publicly, > this patch has been merged in 19.08-rc1. > I have a suspicion that David has confused this patch with another one, which did indeed touch a lot of code (but still didn't touch x86 AFAIR). -- Thanks, Anatoly