From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3F8CA0588; Thu, 16 Apr 2020 14:20:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D810D1DC35; Thu, 16 Apr 2020 14:20:37 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 919881DC2C for ; Thu, 16 Apr 2020 14:20:36 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200416122035euoutp014dea553882a7e2b861cbcdc27ebd3abf~GTCPopuna1915419154euoutp01V for ; Thu, 16 Apr 2020 12:20:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200416122035euoutp014dea553882a7e2b861cbcdc27ebd3abf~GTCPopuna1915419154euoutp01V DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1587039635; bh=YKMmaDrGh5TG4ry4cmniTuibDNmSQYwsbH089YCuYbU=; h=Subject:To:From:Date:In-Reply-To:References:From; b=Qn5tkfctzKQ+3nRLUtehA56muu1uPKpArPJjqO8cJsmAVx3He0K6LPYRhVS2pm8iG tgNo43mw6B9+GabT+jIMPktirkLqf8cTlysYVBnmAUTlHuR8BaEKGva0XiTMk3uYX4 GQ/o/JUfUlf06++2FsvVqfv3SoAamilj1JcjidqI= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200416122035eucas1p2759aa5f6240627cfb002eccb6ea23a68~GTCPLKVSE1146711467eucas1p2g; Thu, 16 Apr 2020 12:20:35 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 21.9A.60698.39D489E5; Thu, 16 Apr 2020 13:20:35 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200416122034eucas1p1adf60b6358f0c62d102f8c39e13ceaaa~GTCOkk93b0836708367eucas1p14; Thu, 16 Apr 2020 12:20:34 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200416122034eusmtrp121ca62ed85e5a4b5ec95fbca2071897f~GTCOj405z2645726457eusmtrp1v; Thu, 16 Apr 2020 12:20:34 +0000 (GMT) X-AuditID: cbfec7f5-a29ff7000001ed1a-75-5e984d933a16 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 12.17.08375.29D489E5; Thu, 16 Apr 2020 13:20:34 +0100 (BST) Received: from [106.109.129.29] (unknown [106.109.129.29]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200416122034eusmtip2951655ae93dd988bd5ecf537af40bcf5~GTCOBKKq91866818668eusmtip2U; Thu, 16 Apr 2020 12:20:34 +0000 (GMT) To: Maxime Coquelin , =?UTF-8?Q?Morten_Br=c3=b8rup?= , dev@dpdk.org, v.kuramshin@samsung.com, amorenoz@redhat.com, zhihong.wang@intel.com, xiaolong.ye@intel.com From: Ivan Dyukov Message-ID: <11f70431-ad06-95cf-79bc-89f9996bcd60@samsung.com> Date: Thu, 16 Apr 2020 15:20:33 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Transfer-Encoding: 8bit Content-Language: ru-RU X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBKsWRmVeSWpSXmKPExsWy7djPc7qTfWfEGbzr5LVo3fGAxeLdp+1M Fsc697BY9P26ymhx+uZmdos/b0wtNl+cxOTA7vFrwVJWj8V7XjJ5vN93lc2jb8sqRo9Tj7qZ A1ijuGxSUnMyy1KL9O0SuDJOzL7PVjBTsOLQgUtMDYwz+LoYOTkkBEwkdp3awApiCwmsYJQ4 3SUNYX9hlLgxV6iLkQvI/swosfzScnaYho+X1rNDJJYzSiy81MUE0fEeqGN3DYgtLOAqMfvi HSaQIhGBO4wSe6bfYAZJsAloSJzumAfWwCtgJ7Hm8XkWEJtFQFVib+88RhBbVCBCYtr2f4wQ NYISJ2c+AavhBKo/Pf0q2BXMAvISzVtnM0PY4hIfth9kA1kmIbCMXWLJnlOMEKe6SBzr7WKB sIUlXh3fAvWCjMTpyT1Q8WqJ75uus0M0dzBK3FvUClVkL7Hl9TkgmwNog6bE+l36EGFHid0v XoKFJQT4JG68FYS4gU9i0rbpzBBhXomONiGIaiWJAycvQYUlJP7+5oEIe0gc+3yVdQKj4iwk T85C8tgsJI/NQjhhASPLKkbx1NLi3PTUYuO81HK94sTc4tK8dL3k/NxNjMD0c/rf8a87GPf9 STrEKMDBqMTDm2A/I06INbGsuDL3EKMEB7OSCC+fKVCINyWxsiq1KD++qDQntfgQozQHi5I4 r/Gil7FCAumJJanZqakFqUUwWSYOTqkGxqULvhT6BdzMTfvf4nd71sN8i5fTLsp9erxlquz+ k44zrq/IfuXAtercOjYTnz+66+R5Pa0NH57bm3/qg8Yh3XlrS//FvmBg6lsRnVu23iTHx0Xp beqy3AeXes1ncBTMmn1Ow3TTp4S73T3FIUe1dVS+31Vwf78kzX9NqqzWkaV6bRPZwpiZvyqx FGckGmoxFxUnAgBQfi7zOwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrEIsWRmVeSWpSXmKPExsVy+t/xe7qTfGfEGZx9q2jRuuMBi8W7T9uZ LI517mGx6Pt1ldHi9M3N7BZ/3phabL44icmB3ePXgqWsHov3vGTyeL/vKptH35ZVjB6nHnUz B7BG6dkU5ZeWpCpk5BeX2CpFG1oY6RlaWugZmVjqGRqbx1oZmSrp29mkpOZklqUW6dsl6GWc mH2frWCmYMWhA5eYGhhn8HUxcnJICJhIfLy0nr2LkYtDSGApo8THy9NYuhg5gBISEq+fMEPU CEv8udbFBlHzllHibP8hFpCEsICrxOyLd5hAEiICdxglfj/uZIaoesoksfvtN3aQKjYBDYnT HfOYQGxeATuJNY/Pg3WzCKhK7O2dxwhiiwpESDye2M4IUSMocXLmE7AaTqD609Ovgs1hFjCT mLf5ITOELS/RvHU2lC0u8WH7QbYJjIKzkLTPQtIyC0nLLCQtCxhZVjGKpJYW56bnFhvqFSfm Fpfmpesl5+duYgTG17ZjPzfvYLy0MfgQowAHoxIPb4L9jDgh1sSy4srcQ4wSHMxKIrx8pkAh 3pTEyqrUovz4otKc1OJDjKZAz01klhJNzgfGfl5JvKGpobmFpaG5sbmxmYWSOG+HwMEYIYH0 xJLU7NTUgtQimD4mDk6pBsZI2/UCHIIvz4lUrlwmoevW7V5sx74wqf6jptq+J1NO2aVeW/LZ ZGd9uhfTfakjHpujPGr81gTK1jpv0uR3KVqoXOrdcP/IfZPpihMZBRSjLIsYZutZCNwwOfRr X65Z3usl845c4u56UV7iP8lD8+vZzU1z3NVMOufeeaNSx6+SLz1n6T/lD0osxRmJhlrMRcWJ AAJp1U7FAgAA X-CMS-MailID: 20200416122034eucas1p1adf60b6358f0c62d102f8c39e13ceaaa X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20200416055324eucas1p10b466945b7290cc1e742dd594e95da23 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200416055324eucas1p10b466945b7290cc1e742dd594e95da23 References: <20191212085012.9170-1-i.dyukov@samsung.com> <20200416055309.19679-1-i.dyukov@samsung.com> <20200416055309.19679-2-i.dyukov@samsung.com> <98CBD80474FA8B44BF855DF32C47DC35C60F5C@smartserver.smartshare.dk> Subject: Re: [dpdk-dev] [PATCH v11 1/6] net/virtio: replace default virtio speed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Maxime, Morten, Thank you for comments. I'll prepare one more revision of the change. Best regards, Ivan 16.04.2020 14:58, Maxime Coquelin пишет: > > On 4/16/20 1:55 PM, Morten Brørup wrote: >>> From: Ivan Dyukov [mailto:i.dyukov@samsung.com] >>> Sent: Thursday, April 16, 2020 7:53 AM >>> >>> This patch set speed to unknown >>> >>> Signed-off-by: Ivan Dyukov >>> --- >>> drivers/net/virtio/virtio_ethdev.c | 4 ++-- >>> lib/librte_ethdev/rte_ethdev.h | 27 ++++++++++++++------------- >>> 2 files changed, 16 insertions(+), 15 deletions(-) >>> >>> diff --git a/drivers/net/virtio/virtio_ethdev.c >>> b/drivers/net/virtio/virtio_ethdev.c >>> index f9d0ea70d..e98a76ea2 100644 >>> --- a/drivers/net/virtio/virtio_ethdev.c >>> +++ b/drivers/net/virtio/virtio_ethdev.c >>> @@ -2371,7 +2371,7 @@ virtio_dev_link_update(struct rte_eth_dev *dev, >>> __rte_unused int wait_to_complet >>> >>> memset(&link, 0, sizeof(link)); >>> link.link_duplex = ETH_LINK_FULL_DUPLEX; >>> - link.link_speed = ETH_SPEED_NUM_10G; >>> + link.link_speed = ETH_SPEED_NUM_UNKNOWN; >>> link.link_autoneg = ETH_LINK_FIXED; >>> >>> if (!hw->started) { >>> @@ -2427,7 +2427,7 @@ virtio_dev_info_get(struct rte_eth_dev *dev, >>> struct rte_eth_dev_info *dev_info) >>> uint64_t tso_mask, host_features; >>> struct virtio_hw *hw = dev->data->dev_private; >>> >>> - dev_info->speed_capa = ETH_LINK_SPEED_10G; /* fake value */ >>> + dev_info->speed_capa = ETH_LINK_SPEED_AUTONEG; /* fake value */ >> If you indicate that the NIC supports Auto Negotiation here, >> then I suggest that you also change the link status as follows: >> - link.link_autoneg = ETH_LINK_FIXED; >> + link.link_autoneg = ETH_LINK_AUTONEG; >> >> I considered the opposite change, but if we define that the underlying environment determines the actual speed, then Auto Negotiation seems more correct than Fixed speed. > That's a valid point. > Thank you Morten for spotting this! > > Ivan, I can do the change while applying if you are fine with it. > > Thanks, > Maxime > >> Med venlig hilsen / kind regards >> - Morten Brørup >> >> >> >