DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Huisong Li <lihuisong@huawei.com>
Cc: dev@dpdk.org, ferruh.yigit@amd.com,
	Dongdong Liu <liudongdong3@huawei.com>,
	Jie Hai <haijie1@huawei.com>,
	Chengwen Feng <fengchengwen@huawei.com>,
	liuyonglong@huawei.com
Subject: Re: [PATCH v5 1/3] doc: fix the description of RSS related feature
Date: Tue, 28 Nov 2023 14:54:54 +0100	[thread overview]
Message-ID: <12013941.VV5PYv0bhD@thomas> (raw)
In-Reply-To: <20231128055927.61704-2-lihuisong@huawei.com>

28/11/2023 06:59, Huisong Li:
> This patch fixes the description of RSS feature.
> And the settinf ot hash algorithm is introduced by 23.11, so add it.
> 
> Fixes: 34ff088cc241 ("ethdev: set and query RSS hash algorithm")
> 
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> Acked-by: Chengwen Feng <fengchengwen@huawei.com>
> Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
> ---
>  * **[uses]     user config**: ``dev_conf.rxmode.mq_mode`` = ``RTE_ETH_MQ_RX_RSS_FLAG``.
> -* **[uses]     user config**: ``dev_conf.rx_adv_conf.rss_conf``.
> +* **[uses]     user config**: ``dev_conf.rx_adv_conf.rss_conf.rss_hf``. ``rss_conf.rss_hf``

No need to keep dev_conf.rx_adv_conf

>  * **[uses]     rte_eth_rxconf,rte_eth_rxmode**: ``offloads:RTE_ETH_RX_OFFLOAD_RSS_HASH``.
>  * **[provides] rte_eth_dev_info**: ``flow_type_rss_offloads``.
>  * **[provides] mbuf**: ``mbuf.ol_flags:RTE_MBUF_F_RX_RSS_HASH``, ``mbuf.rss``.
> +* **[related]  API**: ``rte_eth_dev_configure()``, ``rte_eth_dev_rss_hash_update``
> +  ``rte_eth_dev_rss_hash_conf_get()``.
> +
> +Support RSS hash algorithm on Rx.
> +
> +* **[implements] eth_dev_ops**: ``dev_configure``, ``rss_hash_update``, ``rss_hash_conf_get``.
> +* **[uses]     user config**: ``rss_conf.algorithm``
> +* **[provides]   rte_eth_dev_info**: ``rss_algo_capa``.
> +* **[related]    API**: ``rte_eth_dev_configure()``, ``rte_eth_dev_rss_hash_update()``,
> +  ``rte_eth_dev_rss_hash_conf_get()``.

Fixed typos, alignment and applied, thanks.

Note: the rest of the series is not applied in 23.11.
They are additions which may require reviews.



  reply	other threads:[~2023-11-28 13:55 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-23 13:59 [PATCH 0/5] doc/features: fix some features and add new features Huisong Li
2023-11-23 13:59 ` [PATCH 1/5] doc/features: add RSS hash algorithm feature Huisong Li
2023-11-23 13:59 ` [PATCH 2/5] doc/features: add link up/down feature Huisong Li
2023-11-23 13:59 ` [PATCH 3/5] doc/features: add config interface for speed capabilities Huisong Li
2023-11-23 13:59 ` [PATCH 4/5] doc/features: add Traffic Manager features Huisong Li
2023-11-23 13:59 ` [PATCH 5/5] doc/features: add dump device private information feature Huisong Li
2023-11-23 14:18   ` Thomas Monjalon
2023-11-24  2:03     ` lihuisong (C)
2023-11-24  3:12 ` [PATCH 0/6] doc/features: fix some features and add new features Huisong Li
2023-11-24  3:12   ` [PATCH 1/6] doc/features: add RSS hash algorithm feature Huisong Li
2023-11-24  3:12   ` [PATCH 2/6] doc/features: add link up/down feature Huisong Li
2023-11-24  3:12   ` [PATCH 3/6] doc/features: add features for link speeds Huisong Li
2023-11-24  3:12   ` [PATCH 4/6] doc/features: add Traffic Manager features Huisong Li
2023-11-24  3:12   ` [PATCH 5/6] doc/features: add dump device private information feature Huisong Li
2023-11-24  3:12   ` [PATCH 6/6] doc/features: add feature for loopback mode Huisong Li
2023-11-24  3:24   ` [PATCH 0/6] doc/features: fix some features and add new features fengchengwen
2023-11-25  1:47 ` [PATCH v3 " Huisong Li
2023-11-25  1:47   ` [PATCH v3 1/6] doc: add RSS hash algorithm feature Huisong Li
2023-11-27 12:19     ` Ferruh Yigit
2023-11-27 13:12       ` lihuisong (C)
2023-11-27 15:43         ` Ferruh Yigit
2023-11-27 16:35           ` Ferruh Yigit
2023-11-28  1:34             ` lihuisong (C)
2023-11-28 10:23               ` Ferruh Yigit
2023-11-28  1:21           ` lihuisong (C)
2023-11-28 10:09             ` Ferruh Yigit
2023-11-28 11:29               ` lihuisong (C)
2023-11-28 11:52                 ` Ferruh Yigit
2023-11-28 12:46                   ` lihuisong (C)
2023-11-25  1:47   ` [PATCH v3 2/6] doc: add link up/down feature Huisong Li
2023-11-27 12:24     ` Ferruh Yigit
2023-11-27 13:16       ` lihuisong (C)
2023-11-25  1:47   ` [PATCH v3 3/6] doc: add features for link speeds Huisong Li
2023-11-25  1:47   ` [PATCH v3 4/6] doc: add Traffic Manager feature Huisong Li
2023-11-25  1:47   ` [PATCH v3 5/6] doc: add dump device private information feature Huisong Li
2023-11-25  1:47   ` [PATCH v3 6/6] doc: add feature for loopback mode Huisong Li
2023-11-27 12:35   ` [PATCH v3 0/6] doc/features: fix some features and add new features Ferruh Yigit
2023-11-27 13:37     ` lihuisong (C)
2023-11-27 16:19       ` Ferruh Yigit
2023-11-27 14:16 ` [PATCH v4 0/5] " Huisong Li
2023-11-27 14:16   ` [PATCH v4 1/5] doc: fix the description of RSS related feature Huisong Li
2023-11-27 16:36     ` Ferruh Yigit
2023-11-27 14:16   ` [PATCH v4 2/5] doc: add link up/down feature Huisong Li
2023-11-27 14:16   ` [PATCH v4 3/5] doc: add features for link speeds Huisong Li
2023-11-27 14:16   ` [PATCH v4 4/5] doc: add Traffic Manager feature Huisong Li
2023-11-27 14:16   ` [PATCH v4 5/5] doc: add dump device private information ops Huisong Li
2023-11-27 16:37     ` Ferruh Yigit
2023-11-27 16:44   ` [PATCH v4 0/5] doc/features: fix some features and add new features Ferruh Yigit
2023-11-28  2:09     ` lihuisong (C)
2023-11-28  4:07       ` lihuisong (C)
2023-11-27 16:56   ` Ferruh Yigit
2023-11-28  2:23     ` lihuisong (C)
2023-11-28  5:59 ` [PATCH v5 0/3] " Huisong Li
2023-11-28  5:59   ` [PATCH v5 1/3] doc: fix the description of RSS related feature Huisong Li
2023-11-28 13:54     ` Thomas Monjalon [this message]
2023-11-28  5:59   ` [PATCH v5 2/3] doc: add link up/down feature Huisong Li
2023-11-28  5:59   ` [PATCH v5 3/3] doc: add dump device private information ops Huisong Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12013941.VV5PYv0bhD@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=fengchengwen@huawei.com \
    --cc=ferruh.yigit@amd.com \
    --cc=haijie1@huawei.com \
    --cc=lihuisong@huawei.com \
    --cc=liudongdong3@huawei.com \
    --cc=liuyonglong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).