From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38FCA43388; Tue, 21 Nov 2023 04:33:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 254D8402EB; Tue, 21 Nov 2023 04:33:39 +0100 (CET) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id C4D0E40298 for ; Tue, 21 Nov 2023 04:33:37 +0100 (CET) Received: from kwepemm000004.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4SZ8yS341wz1P8X6; Tue, 21 Nov 2023 11:30:08 +0800 (CST) Received: from [10.67.121.59] (10.67.121.59) by kwepemm000004.china.huawei.com (7.193.23.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 21 Nov 2023 11:33:35 +0800 Message-ID: <120433d5-e882-218c-5cac-93d8f07f1939@huawei.com> Date: Tue, 21 Nov 2023 11:33:34 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v2 11/16] app/test: verify strdup return value To: Chengwen Feng , , CC: References: <20231110100117.8350-1-fengchengwen@huawei.com> <20231110100117.8350-12-fengchengwen@huawei.com> From: "lihuisong (C)" In-Reply-To: <20231110100117.8350-12-fengchengwen@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.59] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm000004.china.huawei.com (7.193.23.18) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Huisong Li 在 2023/11/10 18:01, Chengwen Feng 写道: > Add verify strdup return value logic. > > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org > > Signed-off-by: Chengwen Feng > --- > app/test/process.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/app/test/process.h b/app/test/process.h > index af7bc3e0de..c576c42349 100644 > --- a/app/test/process.h > +++ b/app/test/process.h > @@ -59,8 +59,11 @@ process_dup(const char *const argv[], int numargs, const char *env_value) > return -1; > else if (pid == 0) { > /* make a copy of the arguments to be passed to exec */ > - for (i = 0; i < numargs; i++) > + for (i = 0; i < numargs; i++) { > argv_cpy[i] = strdup(argv[i]); > + if (argv_cpy[i] == NULL) > + rte_panic("Error dup args\n"); > + } > argv_cpy[i] = NULL; > num = numargs; >