* [PATCH] ci: fix build for Arm cross compilation in GHA
@ 2023-06-06 10:52 David Marchand
2023-06-06 11:00 ` Bruce Richardson
0 siblings, 1 reply; 4+ messages in thread
From: David Marchand @ 2023-06-06 10:52 UTC (permalink / raw)
To: dev; +Cc: thomas, ferruh.yigit, stable, Aaron Conole, Michael Santana
We are hitting a storage limit when linking binaries statically.
On the other hand, native builds are tested in other part of the CI and
the chance of breaking static linking only is relatively low, so let's
simply test linking against shared libraries.
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
.github/workflows/build.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 7322eb59b7..3b629fcdbd 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -53,6 +53,7 @@ jobs:
cross: mingw
- os: ubuntu-20.04
compiler: gcc
+ library: shared
cross: aarch64
- os: ubuntu-20.04
compiler: gcc
--
2.40.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ci: fix build for Arm cross compilation in GHA
2023-06-06 10:52 [PATCH] ci: fix build for Arm cross compilation in GHA David Marchand
@ 2023-06-06 11:00 ` Bruce Richardson
2023-06-06 13:02 ` Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: Bruce Richardson @ 2023-06-06 11:00 UTC (permalink / raw)
To: David Marchand
Cc: dev, thomas, ferruh.yigit, stable, Aaron Conole, Michael Santana
On Tue, Jun 06, 2023 at 12:52:47PM +0200, David Marchand wrote:
> We are hitting a storage limit when linking binaries statically.
> On the other hand, native builds are tested in other part of the CI and
> the chance of breaking static linking only is relatively low, so let's
> simply test linking against shared libraries.
>
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> .github/workflows/build.yml | 1 +
> 1 file changed, 1 insertion(+)
Yep, with the number of "test" apps now in each build, our build
directories get rather massive!
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ci: fix build for Arm cross compilation in GHA
2023-06-06 11:00 ` Bruce Richardson
@ 2023-06-06 13:02 ` Ferruh Yigit
2023-06-06 13:09 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2023-06-06 13:02 UTC (permalink / raw)
To: Bruce Richardson, David Marchand
Cc: dev, thomas, stable, Aaron Conole, Michael Santana
On 6/6/2023 12:00 PM, Bruce Richardson wrote:
> On Tue, Jun 06, 2023 at 12:52:47PM +0200, David Marchand wrote:
>> We are hitting a storage limit when linking binaries statically.
>> On the other hand, native builds are tested in other part of the CI and
>> the chance of breaking static linking only is relatively low, so let's
>> simply test linking against shared libraries.
>>
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: David Marchand <david.marchand@redhat.com>
>> ---
>> .github/workflows/build.yml | 1 +
>> 1 file changed, 1 insertion(+)
>
> Yep, with the number of "test" apps now in each build, our build
> directories get rather massive!
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
Confirmed that this solves the "running out of disk space" issue seen on
'ubuntu-20.04-gcc-aarch64',
Tested-by: Ferruh Yigit <ferruh.yigit@amd.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ci: fix build for Arm cross compilation in GHA
2023-06-06 13:02 ` Ferruh Yigit
@ 2023-06-06 13:09 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2023-06-06 13:09 UTC (permalink / raw)
To: David Marchand
Cc: Bruce Richardson, Ferruh Yigit, dev, stable, Aaron Conole,
Michael Santana
06/06/2023 15:02, Ferruh Yigit:
> On 6/6/2023 12:00 PM, Bruce Richardson wrote:
> > On Tue, Jun 06, 2023 at 12:52:47PM +0200, David Marchand wrote:
> >> We are hitting a storage limit when linking binaries statically.
> >> On the other hand, native builds are tested in other part of the CI and
> >> the chance of breaking static linking only is relatively low, so let's
> >> simply test linking against shared libraries.
> >>
> >> Cc: stable@dpdk.org
> >>
> >> Signed-off-by: David Marchand <david.marchand@redhat.com>
> >> ---
> >> .github/workflows/build.yml | 1 +
> >> 1 file changed, 1 insertion(+)
> >
> > Yep, with the number of "test" apps now in each build, our build
> > directories get rather massive!
> >
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> >
>
> Confirmed that this solves the "running out of disk space" issue seen on
> 'ubuntu-20.04-gcc-aarch64',
>
> Tested-by: Ferruh Yigit <ferruh.yigit@amd.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-06 13:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-06 10:52 [PATCH] ci: fix build for Arm cross compilation in GHA David Marchand
2023-06-06 11:00 ` Bruce Richardson
2023-06-06 13:02 ` Ferruh Yigit
2023-06-06 13:09 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).