From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id A3F302C5 for ; Fri, 10 Aug 2018 10:58:10 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0ED3921D26; Fri, 10 Aug 2018 04:58:10 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 10 Aug 2018 04:58:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=NQdfJOFJz23I2LwIuJ83u4boNC b98GP3QMZgKLhUpvg=; b=DR3Bl3amhCPTce6kBSHu0DDPhyIHDHKgc6MqYe3Q3H Vq1NRmlJczlHvidTZtSYb+UhigsOZmJS3jMoGb2/jQu+Jres/YbnwjUCoPtYo2pX jv7LCUzvRXMamxZfbX4KGWrsHQbOVzhtkmvVSfs8ExNTeJjURFsRa+Ewy2fKddKE w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=NQdfJO FJz23I2LwIuJ83u4boNCb98GP3QMZgKLhUpvg=; b=Jb8MVMLtXEEb6Orygfz3bm 9RvAqXjpc7uSv48r0oJTxwWvIVU4vpunsnzmXV8nh5n1JwMu6mI0Vt7xiDg35Ifg 1Sh8g1YA6WcH2W1Ig1fbUy0fZ1UszD+VjMTgKmFfVL5XsYUjicWlpo0Lt2a9Gy0v qpvG7IpbuKzzaCQkGNzeC3fkbYPepBlV5Kv3mykW7s0zudfhVHjcr6ZrwxBqmu+j tLQ8SRYocuokTDtqRs0+J4VwfuEBPvgIdM633F6isaAqTPlEX9L2pKUqvGABE5jE bzmixqMO5Zq3qkEQTU2K4aujH5czN0CeT0J85fI18JU+3gCN/CAUwCJBDkZW7zhw == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (114.149.6.93.rev.sfr.net [93.6.149.114]) by mail.messagingengine.com (Postfix) with ESMTPA id 0363810289; Fri, 10 Aug 2018 04:58:08 -0400 (EDT) From: Thomas Monjalon To: "Xing, Beilei" Cc: "dev@dpdk.org" , "Lu, Wenzhuo" , "Wu, Jingjing" Date: Fri, 10 Aug 2018 10:58:07 +0200 Message-ID: <12091596.jMvCybQCOU@xps> In-Reply-To: <94479800C636CB44BD422CB454846E013220D55E@SHSMSX101.ccr.corp.intel.com> References: <1533534335-119817-1-git-send-email-beilei.xing@intel.com> <2252677.DSoj0ZM9iK@xps> <94479800C636CB44BD422CB454846E013220D55E@SHSMSX101.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support bitmask for RSS and FDIR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Aug 2018 08:58:11 -0000 10/08/2018 04:31, Xing, Beilei: > Hi Thomas, > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 06/08/2018 07:45, Beilei Xing: > > > This patch adds bitmask support for RSS, FDIR and FDIR flexible > > > payload. > > > > > > Signed-off-by: Beilei Xing > > > > Flow director API is deprecated for almost 2 years: > > http://git.dpdk.org/dpdk/commit/?id=7fdcde6 > > We asked several times to stop using it in i40e. > > It has not been listened. > > We have even accepted a workaround in flow_filtering example for i40e: > > http://git.dpdk.org/dpdk/commit/?id=9a93446 > > We need to stop and move all to a common rte_flow API. > > > > As a consequence, I will be against this patch. > > > > It's not for deprecated flow director API, it's mainly for i40e private API rte_pmd_i40e_inset_set. > This patch is an extend of: > https://patches.dpdk.org/patch/33031/ It is a private API for flow director. I feel you play with me, it's worst.