* [PATCH] vhost/crypto: fix uninitialized variable
@ 2025-05-15 8:10 Gowrishankar Muthukrishnan
2025-05-16 13:43 ` Maxime Coquelin
2025-05-16 14:12 ` Maxime Coquelin
0 siblings, 2 replies; 3+ messages in thread
From: Gowrishankar Muthukrishnan @ 2025-05-15 8:10 UTC (permalink / raw)
To: dev, Maxime Coquelin, Chenbo Xia, Akhil Goyal,
Gowrishankar Muthukrishnan
Cc: anoobj
Fix uninitialized variable as reported in coverity scan.
Coverity-issue: 457449
Fixes: d1b484bf187 ("vhost/crypto: support asymmetric RSA")
Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
---
lib/vhost/vhost_crypto.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/vhost/vhost_crypto.c b/lib/vhost/vhost_crypto.c
index f78daf98d1..66ba5342e2 100644
--- a/lib/vhost/vhost_crypto.c
+++ b/lib/vhost/vhost_crypto.c
@@ -1493,10 +1493,10 @@ vhost_crypto_process_one_req(struct vhost_crypto *vcrypto,
struct vhost_crypto_data_req *vc_req, *vc_req_out;
struct rte_cryptodev_asym_session *asym_session;
struct rte_cryptodev_sym_session *sym_session;
+ struct vhost_crypto_data_req data_req = {0};
struct vhost_crypto_session *vhost_session;
struct vhost_crypto_desc *desc = descs;
uint32_t nb_descs = 0, max_n_descs, i;
- struct vhost_crypto_data_req data_req;
struct virtio_crypto_op_data_req req;
struct virtio_crypto_inhdr *inhdr;
struct vring_desc *src_desc;
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vhost/crypto: fix uninitialized variable
2025-05-15 8:10 [PATCH] vhost/crypto: fix uninitialized variable Gowrishankar Muthukrishnan
@ 2025-05-16 13:43 ` Maxime Coquelin
2025-05-16 14:12 ` Maxime Coquelin
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2025-05-16 13:43 UTC (permalink / raw)
To: Gowrishankar Muthukrishnan, dev, Chenbo Xia, Akhil Goyal; +Cc: anoobj
On 5/15/25 10:10 AM, Gowrishankar Muthukrishnan wrote:
> Fix uninitialized variable as reported in coverity scan.
>
> Coverity-issue: 457449
> Fixes: d1b484bf187 ("vhost/crypto: support asymmetric RSA")
>
> Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
> ---
> lib/vhost/vhost_crypto.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/vhost/vhost_crypto.c b/lib/vhost/vhost_crypto.c
> index f78daf98d1..66ba5342e2 100644
> --- a/lib/vhost/vhost_crypto.c
> +++ b/lib/vhost/vhost_crypto.c
> @@ -1493,10 +1493,10 @@ vhost_crypto_process_one_req(struct vhost_crypto *vcrypto,
> struct vhost_crypto_data_req *vc_req, *vc_req_out;
> struct rte_cryptodev_asym_session *asym_session;
> struct rte_cryptodev_sym_session *sym_session;
> + struct vhost_crypto_data_req data_req = {0};
> struct vhost_crypto_session *vhost_session;
> struct vhost_crypto_desc *desc = descs;
> uint32_t nb_descs = 0, max_n_descs, i;
> - struct vhost_crypto_data_req data_req;
> struct virtio_crypto_op_data_req req;
> struct virtio_crypto_inhdr *inhdr;
> struct vring_desc *src_desc;
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vhost/crypto: fix uninitialized variable
2025-05-15 8:10 [PATCH] vhost/crypto: fix uninitialized variable Gowrishankar Muthukrishnan
2025-05-16 13:43 ` Maxime Coquelin
@ 2025-05-16 14:12 ` Maxime Coquelin
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2025-05-16 14:12 UTC (permalink / raw)
To: Gowrishankar Muthukrishnan, dev, Chenbo Xia, Akhil Goyal; +Cc: anoobj
On 5/15/25 10:10 AM, Gowrishankar Muthukrishnan wrote:
> Fix uninitialized variable as reported in coverity scan.
>
> Coverity-issue: 457449
> Fixes: d1b484bf187 ("vhost/crypto: support asymmetric RSA")
>
> Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
> ---
> lib/vhost/vhost_crypto.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/vhost/vhost_crypto.c b/lib/vhost/vhost_crypto.c
> index f78daf98d1..66ba5342e2 100644
> --- a/lib/vhost/vhost_crypto.c
> +++ b/lib/vhost/vhost_crypto.c
> @@ -1493,10 +1493,10 @@ vhost_crypto_process_one_req(struct vhost_crypto *vcrypto,
> struct vhost_crypto_data_req *vc_req, *vc_req_out;
> struct rte_cryptodev_asym_session *asym_session;
> struct rte_cryptodev_sym_session *sym_session;
> + struct vhost_crypto_data_req data_req = {0};
> struct vhost_crypto_session *vhost_session;
> struct vhost_crypto_desc *desc = descs;
> uint32_t nb_descs = 0, max_n_descs, i;
> - struct vhost_crypto_data_req data_req;
> struct virtio_crypto_op_data_req req;
> struct virtio_crypto_inhdr *inhdr;
> struct vring_desc *src_desc;
Applied to next-virtio/for-net-next.
Thanks,
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-16 14:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-05-15 8:10 [PATCH] vhost/crypto: fix uninitialized variable Gowrishankar Muthukrishnan
2025-05-16 13:43 ` Maxime Coquelin
2025-05-16 14:12 ` Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).