DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"jerinj@marvell.com" <jerinj@marvell.com>,
	"Li, WeiyuanX" <weiyuanx.li@intel.com>,
	"ferruh.yigit@amd.com" <ferruh.yigit@amd.com>,
	"andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>,
	"Morten Brørup" <mb@smartsharesystems.com>,
	david.marchand@redhat.com
Subject: Re: [PATCH] event/sw: fix selftest xstats reset API usage
Date: Wed, 12 Oct 2022 17:09:36 +0200	[thread overview]
Message-ID: <12103968.CDJkKcVGEf@thomas> (raw)
In-Reply-To: <BN0PR11MB5712B572E92483E18BB046EFD7229@BN0PR11MB5712.namprd11.prod.outlook.com>

12/10/2022 15:08, Van Haaren, Harry:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 12/10/2022 14:34, Harry van Haaren:
> > > The eventdev xstats reset API takes an ID of "uint32_t", while
> > > the rest of the xstats APIs require an "unsigned int". On some
> > > platforms these might not be the same bitwidth, however this was
> > > assumed in the code.
> > >
> > > Fix by providing a uint32_t to the xstats_reset() function.
> > 
> > Why adding a comment about the type in the code?
> > We are not adding /* using the right type */ in each line of code.
> 
> Correct; but as the SW PMD was the only selftest code that actually
> uses xstats_reset() I err-ed on the side of warning devs that there's
> some "funky" or inconsistent API requirements here.
> 
> I can respin without if that seems better, but my intention was to
> help future readers..?

It does not really help.
If you want to help, and you think the API is wrong,
then please send a patch to propose a change in the API.



      reply	other threads:[~2022-10-12 15:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-12 12:34 Harry van Haaren
2022-10-12 13:05 ` Thomas Monjalon
2022-10-12 13:08   ` Van Haaren, Harry
2022-10-12 15:09     ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12103968.CDJkKcVGEf@thomas \
    --to=thomas@monjalon.net \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=harry.van.haaren@intel.com \
    --cc=jerinj@marvell.com \
    --cc=mb@smartsharesystems.com \
    --cc=weiyuanx.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).