From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f174.google.com (mail-wr0-f174.google.com [209.85.128.174]) by dpdk.org (Postfix) with ESMTP id B6C2B326B for ; Tue, 4 Apr 2017 22:00:58 +0200 (CEST) Received: by mail-wr0-f174.google.com with SMTP id k6so218639187wre.2 for ; Tue, 04 Apr 2017 13:00:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=NBNP3Ayv8giIY2ChcPomnHG0mVhWymCjJVYblOqqwtA=; b=maMg+bHNbCIltLvE2Ivd6mXk77gnbxkIQVKDeQy2PIi4rIYurtbBhxbbEy8h8yuhfQ +K3D62Njhedhn5auhthejwoTnYD7Zq8M/nYe1MY0rwSgGViBpqPb1k2/2ZrygEnXRCus TBWRTkxbM52DVYNPpOI1pQzSVQeAHP/GKNZ2n5x0UUpLI2adRz6lCt/Dj+7YPrLwChhf +pZt9TR3tQA2VZZos3wMpU8ELnBm1w0caywcgYniBMZQYa+pnQ6FUn/5jy+OMaXqXjVa 6KZpNjqbUWCfjLycuL8keIgc+CIjezR2YC6ihYmNcpZlmhUdPaer2TyQ6aRA8RI/gJur iVwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=NBNP3Ayv8giIY2ChcPomnHG0mVhWymCjJVYblOqqwtA=; b=CzskTxynqcn+VaCyAyN7y64tG8Msdb8bkkh1YNn0QG3UUhSwbiJ9X3Ceterfa6pr58 1IVd6WF2hlLkPt+AewiqcwPza/+sklpdml8RQisllXMwypKPhLxdaHDVU7vbegK1Ox0v qE4B4MxaTrJMK6+/X19ShFSQKcxdsHvnf/kEXFY6Yu7G543zbQGvg6aEpj38xmT77XmW PmCk9aOadnNELPrHFSg6Hv/bxlZcZJ6iPrijVnt3hhG7qkRPNzzxjBGEh6JYYvmcShPs 7RwR/VQZIBh5BK1Q02uwbsCdJ0HdETnzpRGowve4AZ0PXujdzmKES4G6zOH3rstxYXr9 PH8A== X-Gm-Message-State: AFeK/H2looLQVSPe1XBDB1criAwwaukbtNLDQcESu60JYxTgNv7JltRx45pVLsB4sg3iI/0g X-Received: by 10.223.163.28 with SMTP id c28mr20716149wrb.186.1491336058437; Tue, 04 Apr 2017 13:00:58 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id m14sm8949764wrb.13.2017.04.04.13.00.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Apr 2017 13:00:57 -0700 (PDT) From: Thomas Monjalon To: Jasvinder Singh , pablo.de.lara.guarch@intel.com, bruce.richardson@intel.com Cc: dev@dpdk.org, olivier.matz@6wind.com, declan.doherty@intel.com Date: Tue, 04 Apr 2017 22:00:56 +0200 Message-ID: <12125749.0JfrvTu2Hz@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1490890533-92231-2-git-send-email-jasvinder.singh@intel.com> References: <1490873422-13734-2-git-send-email-jasvinder.singh@intel.com> <1490890533-92231-1-git-send-email-jasvinder.singh@intel.com> <1490890533-92231-2-git-send-email-jasvinder.singh@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v9 1/3] librte_net: add crc compute APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2017 20:00:58 -0000 2017-03-30 17:15, Jasvinder Singh: > +/** > + * CRC compute API > + * > + * @param data > + * Pointer to the packet data for CRC computation > + * @param data_len > + * Data length for CRC computation > + * @param type > + * CRC type (enum rte_net_crc_type) > + * > + * @return > + * CRC value > + */ > +uint32_t > +rte_net_crc_calc(const void *data, > + uint32_t data_len, > + enum rte_net_crc_type type); I still think returning a value from a data input is a kind of hash. And this is my wikipedia argument: https://en.wikipedia.org/wiki/List_of_hash_functions "This is a list of hash functions, including cyclic redundancy checks, checksum functions, and cryptographic hash functions." Anyway, I must accept the community decision. Now I would like to see a clear explanations of which algos are in librte_hash, and why we have CRC32c and Toeplitz.