DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] devtools: check wrong svg include in patches
@ 2018-10-31 11:05 Thomas Monjalon
  2018-10-31 15:46 ` Arnon Warshavsky
  2018-10-31 16:28 ` [dpdk-dev] [PATCH v2] devtools: check wrong svg include in guides Thomas Monjalon
  0 siblings, 2 replies; 11+ messages in thread
From: Thomas Monjalon @ 2018-10-31 11:05 UTC (permalink / raw)
  To: dev; +Cc: john.mcnamara, marko.kovacevic, Arnon Warshavsky

Including svg files with the svg extension is a common mistake:
	.. figure:: example.svg
must be
	.. figure:: example.*
So it will work also when building pdf doc with figures converted
to png files.

A check is added in checkpatches.sh.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

PS: it seems this check is not working. Arnon, I need your help please.
Cc: Arnon Warshavsky <arnon@qwilt.com>
---
 devtools/checkpatches.sh | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index bf3114f95..e69b5bc34 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -50,6 +50,12 @@ check_forbidden_additions() {
 		-v EXPRESSIONS="rte_panic\\\( rte_exit\\\(" \
 		-v RET_ON_FAIL=1 \
 		-f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk -
+	# svg figures must be included with wildcard extension
+	# because of png conversion for pdf docs
+	awk -v FOLDERS='doc' \
+		-v EXPRESSIONS=':: *[^ ]*\\.svg' \
+		-v RET_ON_FAIL=1 \
+		-f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk -
 }
 
 number=0
-- 
2.19.0

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2018-11-01 21:25 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-31 11:05 [dpdk-dev] [PATCH] devtools: check wrong svg include in patches Thomas Monjalon
2018-10-31 15:46 ` Arnon Warshavsky
2018-10-31 15:51   ` Thomas Monjalon
2018-10-31 15:55     ` Arnon Warshavsky
2018-10-31 16:28 ` [dpdk-dev] [PATCH v2] devtools: check wrong svg include in guides Thomas Monjalon
2018-11-01  6:45   ` Arnon Warshavsky
2018-11-01  9:27     ` Thomas Monjalon
2018-11-01  9:29       ` Arnon Warshavsky
2018-11-01 13:59         ` Arnon Warshavsky
2018-11-01 14:10           ` Thomas Monjalon
2018-11-01 21:25   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).