From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A188AA0A0C; Wed, 4 Aug 2021 14:27:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 22E8D4014F; Wed, 4 Aug 2021 14:27:42 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 510664003E for ; Wed, 4 Aug 2021 14:27:40 +0200 (CEST) Received: from [192.168.100.116] (unknown [37.139.99.76]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 91CAE7F4DA; Wed, 4 Aug 2021 15:27:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 91CAE7F4DA DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1628080059; bh=SExhIxtelYC9Uv4UzLBdXYAc3i7KNZzoAFhhx4bgqhw=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=Xbct6G/x5hOpzNNmh1WHDtHoyyl33aegLnmV7QDtGgYe6N95YQ85Ueh5OdFTgXZIF gxk3mnMAUIxn37+c76PiSHnOUxEUKVK4RhFCql94apsf83RGn29jEYxqyzMZu5Knhx Qo2iwZlLRDDZD/6MyP+qFtehLt8uID/IFOZ005Dw= To: Xueming Li Cc: dev@dpdk.org, Ray Kinsella References: <20210802131056.2683266-1-xuemingl@nvidia.com> From: Andrew Rybchenko Message-ID: <1213d676-914f-757d-e028-749a92f37cb3@oktetlabs.ru> Date: Wed, 4 Aug 2021 15:27:38 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210802131056.2683266-1-xuemingl@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] doc: announce eth queue release callback parameter change X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/2/21 4:10 PM, Xueming Li wrote: > This patch announces the parameter change of eth_queue_release_t > callback API to eth_dev_ops in DPDK v21.11. > > [1] mail list discussion: > https://mails.dpdk.org/archives/dev/2021-July/215654.html > > Signed-off-by: Xueming Li > --- > doc/guides/rel_notes/deprecation.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index d9c0e65921..c38aebe99d 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -131,6 +131,9 @@ Deprecation Notices > consistent with existing outer header checksum status flag naming, which > should help in reducing confusion about its usage. > > +* ethdev: queue release callback parameter will be changed to device and queue > + ID to align with other queue configureation callback. > + > * i40e: As there are both i40evf and iavf pmd, the functions of them are > duplicated. And now more and more advanced features are developed on iavf. > To keep consistent with kernel driver's name > Isn't it an internal callback and no deprecation notice required to change it? "to align with" is a bit weak justification that so huge change is required (really many sources must be fixed). I guess it could be required for shared RxQ. If so, it should be mentioned.