From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 9D6485934 for ; Fri, 8 Jul 2016 12:03:14 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id n127so9779159wme.1 for ; Fri, 08 Jul 2016 03:03:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=wjCEyEeGwWSXCTc06f9e5CQdkAY8rV9ii9x7b2i2vIc=; b=a9VJOXCrl1gu5BtvsZkuS6IhtU1PVm/cs58GT6tPcGHaLTFpSoBkXFQ94a/WrgtTjX 1ewCB3DY/SBB3CDB3aIaiHDVmmhzJF050x4WkKqczjo6/tYDZ/IFj0lZ+hpfJ2olqy2J QJTyr/psXUpQwAV7XRSX/kFZW16WOm483hbk3oLMnrGF9apbvFscjigFbYFSKF9Fbt0Z nseeXQCUrK4zXcCJzmboa3ZG5W2dtIyrW0b3fPFGmfvdsJsaDaPl+8J7ZlzmtJIup/X/ ed2PoFZuZ5Hrmi0s6yhELZGvG9u/cZ818VL5ln4Q5MJYFZ0+6wlEvEGqGGt6uPJelpTK LOAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=wjCEyEeGwWSXCTc06f9e5CQdkAY8rV9ii9x7b2i2vIc=; b=V0lkDlVp1ovrBsjECfyMEkmiid5v6V/Jx9YAbAfU43Jq41BJg4jbkx6Hcfm2KBsYBQ jRHUbOdJvfp6D5C1CMUTbrNaJNg8qx4t0WYACpyacFIOrDcHMmwShYX9zFwcPWPDJHkV 3lDjXxnfHayw3wQ+zyGNxRgnNJGPd1Y+8wXYjYBn7AATqcE/wBsWTKoMQEISAaZ05M/y MnnN3rJdVh3jvdlZY6iTgDs/FSfeHdc5RzIb2dcrl2VryrptT/JplD24NK5Dvd6B71a6 +Fb8GQspt3vMj7gDg4LuC73PUYxh/p12jFJKyb1mb+DJsnRzh2VRiQMMu+FYPH71AIGl yQLg== X-Gm-Message-State: ALyK8tIP7lf76pQC+wcidEjjsj1KEHThtrHSfTrVHPdLRCXdVL8zzyLd1gtTwn5LG557/7oW X-Received: by 10.28.23.79 with SMTP id 76mr2660235wmx.93.1467972194418; Fri, 08 Jul 2016 03:03:14 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id e16sm2239400wma.12.2016.07.08.03.03.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Jul 2016 03:03:13 -0700 (PDT) From: Thomas Monjalon To: Neil Horman Cc: dev@dpdk.org, Bruce Richardson , "De Lara Guarch, Pablo" , Stephen Hemminger , Panu Matilainen Date: Fri, 08 Jul 2016 12:03:12 +0200 Message-ID: <12140377.vURjlE434K@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1467905863-27038-1-git-send-email-nhorman@tuxdriver.com> References: <1467905863-27038-1-git-send-email-nhorman@tuxdriver.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] crypto: normalize cryptodev pmd names with macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jul 2016 10:03:14 -0000 2016-07-07 11:37, Neil Horman: > -PMD_REGISTER_DRIVER(cryptodev_aesni_mb_pmd_drvi, aesni_mb); > -DRIVER_REGISTER_PARAM_STRING(aesni_gcm, "max_nb_queue_pairs= " > +PMD_REGISTER_DRIVER(cryptodev_aesni_mb_pmd_drv, CRYPTODEV_NAME_AESNI_MB_PMD); > +DRIVER_REGISTER_PARAM_STRING(CRYPTODEV_NAME_AESNI_MB_PMD, "max_nb_queue_pairs= " > "max_nb_sessions= socket_id="); A coding style opinion: The line DRIVER_REGISTER_PARAM_STRING is a bit long and I think it would be nice to have only one param per line with an indent like this: DRIVER_REGISTER_PARAM_STRING(CRYPTODEV_NAME_AESNI_MB_PMD, "max_nb_queue_pairs= " "max_nb_sessions= " "socket_id=");