From: Thomas Monjalon <thomas@monjalon.net>
To: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Cc: dev@dpdk.org, konstantin.ananyev@intel.com,
andrey.chilikin@intel.com, ray.kinsella@intel.com,
yipeng1.wang@intel.com, sameh.gobriel@intel.com,
bruce.richardson@intel.com, david.marchand@redhat.com,
kda@semihalf.com
Subject: Re: [dpdk-dev] [PATCH v2] hash: fix tuple adjustment
Date: Wed, 05 May 2021 12:16:34 +0200 [thread overview]
Message-ID: <12183288.lg1fQFyeHg@thomas> (raw)
In-Reply-To: <1620138304-203463-1-git-send-email-vladimir.medvedkin@intel.com>
04/05/2021 16:25, Vladimir Medvedkin:
> rte_thash_adjust_tuple() uses random to generate a new subtuple if
> fn() callback reports about collision. In some cases random changes
> the subtuple in a way that after complementary bits are applied the
> original tuple is obtained. This patch replaces random with subtuple
> increment.
>
> Fixes: 28ebff11c2dc ("hash: add predictable RSS")
> Cc: vladimir.medvedkin@intel.com
>
> Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> ---
> lib/hash/rte_thash.c | 121 ++++++++++++++++++++++++++++++++++++++++++---------
> 1 file changed, 100 insertions(+), 21 deletions(-)
Waiting for a review.
It is a complex change.
next prev parent reply other threads:[~2021-05-05 10:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 14:07 [dpdk-dev] [PATCH] " Vladimir Medvedkin
2021-05-04 14:25 ` [dpdk-dev] [PATCH v2] " Vladimir Medvedkin
2021-05-05 10:16 ` Thomas Monjalon [this message]
2021-05-05 17:57 ` Wang, Yipeng1
2021-05-05 19:13 ` Stanislaw Kardach
2021-05-06 11:40 ` [dpdk-dev] [PATCH v3] " Vladimir Medvedkin
2021-05-10 13:25 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12183288.lg1fQFyeHg@thomas \
--to=thomas@monjalon.net \
--cc=andrey.chilikin@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=kda@semihalf.com \
--cc=konstantin.ananyev@intel.com \
--cc=ray.kinsella@intel.com \
--cc=sameh.gobriel@intel.com \
--cc=vladimir.medvedkin@intel.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).