From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 6EDA35A6C for ; Thu, 16 Jul 2015 23:26:18 +0200 (CEST) Received: by wgxm20 with SMTP id m20so68188397wgx.3 for ; Thu, 16 Jul 2015 14:26:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=hN4x6gYlmBxrQsdeWFGBYqlbSTrQZubmegdoogxYy+Y=; b=EkXwjG9LsYVIDI+28JY3hGqQHsGpmrWzTHNGSSvdOOWDna2ZBSI9kD+f4gmAPoTQRh Z0bwSIImxXnIAhVaXAoGzAd4LXxZ+NgWKUAxwVbmQkPmA+OOGMG909kt1U/aIyRdeiHt Q6dd1aZauX9M+gMKmLe2WpUjKuAvRZlj7UGeHErUkmLWGims31HOCOXEcKPK6CgKRr/s HoP4M0iwxoZzNxadeVj+UG69MzzxEQtLVRUb0jvnttRWYDJ8oLihpX35qqlHyFiCUR+N F2NBA9VKR7aRyNHWE/dZuTF3DNWNKcDFqUY3d6hk8Kam5T9uzpxc/0rNCLswD7Hq8SY0 vjFw== X-Gm-Message-State: ALoCoQnBlJLn/AF5m9IeNI0tQ8G0Ot46CtCHZZO79bSa4R1LNIUEOM8wCEBkHjrRQLj5OwObFEff X-Received: by 10.194.95.41 with SMTP id dh9mr23024971wjb.55.1437081978335; Thu, 16 Jul 2015 14:26:18 -0700 (PDT) Received: from xps13.localnet (guy78-1-82-235-116-147.fbx.proxad.net. [82.235.116.147]) by smtp.gmail.com with ESMTPSA id dt1sm5200958wib.7.2015.07.16.14.26.16 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Jul 2015 14:26:17 -0700 (PDT) From: Thomas Monjalon To: Liang-Min Larry Wang Date: Thu, 16 Jul 2015 23:25:05 +0200 Message-ID: <12190549.MS8Ux4Gd0m@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1437053137-10460-6-git-send-email-liang-min.wang@intel.com> References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com> <1437053137-10460-1-git-send-email-liang-min.wang@intel.com> <1437053137-10460-6-git-send-email-liang-min.wang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v17 5/5] examples: new example: l2fwd-ethtool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jul 2015 21:26:18 -0000 2015-07-16 09:25, Liang-Min Larry Wang: > The example includes an ethtool library and two applications: > one application is a non- DPDK process (nic-control) > and the other is a DPDK l2fwd applicaiton (l2fwd-app). > The nic-control process sends ethtool alike device management > requests to l2fwd-app through a named pipe IPC. This example > is designed to show how to build a ethtool shim library and > how to use ethtool apis to manage device parameters. The makefiles need some clean-up and it does not build in shared lib mode. Beginning of a cleanup patch to merge with this one: --- a/examples/Makefile +++ b/examples/Makefile @@ -50,12 +50,10 @@ DIRS-y += ip_reassembly DIRS-$(CONFIG_RTE_IP_FRAG) += ip_fragmentation DIRS-y += ipv4_multicast DIRS-$(CONFIG_RTE_LIBRTE_KNI) += kni -DIRS-y += l2fwd-ethtool/lib -DIRS-y += l2fwd-ethtool/nic-control -DIRS-y += l2fwd-ethtool/l2fwd-app DIRS-y += l2fwd DIRS-$(CONFIG_RTE_LIBRTE_IVSHMEM) += l2fwd-ivshmem DIRS-$(CONFIG_RTE_LIBRTE_JOBSTATS) += l2fwd-jobstats +DIRS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += l2fwd-ethtool DIRS-y += l3fwd DIRS-$(CONFIG_RTE_LIBRTE_ACL) += l3fwd-acl DIRS-$(CONFIG_RTE_LIBRTE_POWER) += l3fwd-power --- a/examples/l2fwd-ethtool/Makefile +++ b/examples/l2fwd-ethtool/Makefile @@ -37,7 +37,6 @@ endif RTE_TARGET ?= x86_64-native-linuxapp-gcc include $(RTE_SDK)/mk/rte.vars.mk -unexport RTE_SRCDIR RTE_OUTPUT RTE_EXTMK ifneq ($(CONFIG_RTE_EXEC_ENV),"linuxapp") $(error This application can only operate in a linuxapp environment, \ @@ -46,10 +45,4 @@ endif DIRS-y += lib nic-control l2fwd-app -.PHONY: all clean $(DIRS-y) - -all: $(DIRS-y) -clean: $(DIRS-y) - -$(DIRS-y): - $(MAKE) -C $@ $(MAKECMDGOALS) O=$(RTE_OUTPUT) +include $(RTE_SDK)/mk/rte.extsubdir.mk